Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_route53_resolver_firewall_domain_list List Limit is 1000 items, not 255 #23485

Closed
jordanfelle opened this issue Mar 3, 2022 · 2 comments · Fixed by #23486
Closed

aws_route53_resolver_firewall_domain_list List Limit is 1000 items, not 255 #23485

jordanfelle opened this issue Mar 3, 2022 · 2 comments · Fixed by #23486
Labels
bug Addresses a defect in current functionality. service/route53resolver Issues and PRs that pertain to the route53resolver service.
Milestone

Comments

@jordanfelle
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform CLI and Terraform AWS Provider Version

Terraform 1.1.6
4.3.0

Affected Resource(s)

  • aws_route53_resolver_firewall_domain_list

Terraform Configuration Files

resource "aws_route53_resolver_firewall_domain_list" "test" {
  name = "test"
  domains = ["test1.com",
...
"test256.com"
]
}

Expected Behavior

Up to 1000 domains at a time can be defined per request. The 255 limit is characters per domain

Actual Behavior

You are blocked from having more than 255 domains

References

Api docs define this at https://docs.aws.amazon.com/Route53/latest/APIReference/API_route53resolver_UpdateFirewallDomains.html#API_route53resolver_UpdateFirewallDomains_RequestSyntax

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/route53resolver Issues and PRs that pertain to the route53resolver service. labels Mar 3, 2022
jordanfelle added a commit to jordanfelle/terraform-provider-aws that referenced this issue Mar 3, 2022
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 3, 2022
ewbankkit added a commit that referenced this issue Mar 3, 2022
fix #23485: Remove limit for number of domains in aws_route53_resolver_firewall_domain_list
@github-actions github-actions bot added this to the v4.4.0 milestone Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

This functionality has been released in v4.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/route53resolver Issues and PRs that pertain to the route53resolver service.
Projects
None yet
2 participants