Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/emrserverless_application - new resource #25144

Merged
merged 24 commits into from
Jun 6, 2022
Merged

r/emrserverless_application - new resource #25144

merged 24 commits into from
Jun 6, 2022

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 2, 2022 •
edited

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24734

Output from acceptance testing:

$ make testacc TESTS=TestAccEMRApplication_ PKG=emrserverless
--- PASS: TestAccEMRApplication_basic (91.60s)
--- PASS: TestAccEMRApplication_network (105.40s)
--- PASS: TestAccEMRApplication_initialCapacity (111.58s)
--- PASS: TestAccEMRApplication_maxCapacity (111.58s)
--- PASS: TestAccEMRApplication_disappears (114.36s)
--- PASS: TestAccEMRApplication_tags (131.63s)

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jun 2, 2022
@dacort dacort mentioned this pull request Jun 2, 2022
Closed
dacort
dacort reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@dacort dacort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this PR together! 🎉

internal/service/emrserverless/application.go
Comment on lines +21 to +24
Create: resourceApplicationCreate,
Read: resourceApplicationRead,
Update: resourceApplicationUpdate,
Delete: resourceApplicationDelete,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the Create/Read/etc series of functions are deprecated and you should instead use CreateContext or CreateWithoutTimeout instead (for example).

internal/service/emrserverless/application.go Show resolved Hide resolved
@DrFaust92 DrFaust92 added new-resource Introduces a new resource. new-service Introduces a new service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 2, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Jun 2, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review June 3, 2022 08:53
@DrFaust92 DrFaust92 marked this pull request as draft June 4, 2022 07:37
@DrFaust92 DrFaust92 marked this pull request as ready for review June 4, 2022 20:43
@github-actions github-actions bot added the skaff Issues and pull requested related to the skaff tool label Jun 5, 2022
ewbankkit
ewbankkit approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRApplication_' PKG=emrserverless ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/emrserverless/... -v -count 1 -parallel 2  -run=TestAccEMRApplication_ -timeout 180m
=== RUN   TestAccEMRApplication_basic
=== PAUSE TestAccEMRApplication_basic
=== RUN   TestAccEMRApplication_initialCapacity
=== PAUSE TestAccEMRApplication_initialCapacity
=== RUN   TestAccEMRApplication_maxCapacity
=== PAUSE TestAccEMRApplication_maxCapacity
=== RUN   TestAccEMRApplication_network
=== PAUSE TestAccEMRApplication_network
=== RUN   TestAccEMRApplication_disappears
=== PAUSE TestAccEMRApplication_disappears
=== RUN   TestAccEMRApplication_tags
=== PAUSE TestAccEMRApplication_tags
=== CONT  TestAccEMRApplication_basic
=== CONT  TestAccEMRApplication_network
--- PASS: TestAccEMRApplication_basic (103.20s)
=== CONT  TestAccEMRApplication_tags
--- PASS: TestAccEMRApplication_network (106.65s)
=== CONT  TestAccEMRApplication_disappears
--- PASS: TestAccEMRApplication_disappears (107.41s)
=== CONT  TestAccEMRApplication_maxCapacity
--- PASS: TestAccEMRApplication_tags (115.35s)
=== CONT  TestAccEMRApplication_initialCapacity
--- PASS: TestAccEMRApplication_maxCapacity (100.58s)
--- PASS: TestAccEMRApplication_initialCapacity (102.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrserverless	330.545s

@ewbankkit
Copy link
Contributor 

% make providerlint golangci-lint semall
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...
==> Running Semgrep checks locally (must have semgrep installed)...
Scanning 3963 files with 37 go rules.
  100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|3963/3963 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 37 rules on 3963 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 3963 files with 107 go rules.
  100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|3963/3963 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 107 rules on 3963 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 891 files with 179 go rules.
  100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|891/891 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 180 rules on 891 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 883 files with 197 go rules.
  100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|883/883 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 201 rules on 883 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 1122 files with 198 go rules.
  100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|1122/1122 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1613 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 198 rules on 1122 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading

@ewbankkit ewbankkit mentioned this pull request Jun 6, 2022
Closed
@github-actions github-actions bot added the service/dms Issues and PRs that pertain to the dms service. label Jun 6, 2022
@ewbankkit
Copy link
Contributor

ewbankkit commented Jun 6, 2022 •
edited 

% make test
==> Checking that code complies with gofmt requirements...
go test ./...  -timeout=5m
?   	github.com/hashicorp/terraform-provider-aws	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	6.720s
?   	github.com/hashicorp/terraform-provider-aws/internal/attrmap	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/conns	1.785s
ok  	github.com/hashicorp/terraform-provider-aws/internal/create	1.895s
ok  	github.com/hashicorp/terraform-provider-aws/internal/experimental/nullable	1.960s
?   	github.com/hashicorp/terraform-provider-aws/internal/experimental/sync	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/flex	1.875s
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/allowsubcats	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/checknames	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/customends	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/issuelabels	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/generate/namevaluesfilters	6.975s
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/prlabels	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/servicelabels	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/generate/sweepimp	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/provider	0.961s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/accessanalyzer	11.309s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/account	13.811s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acm	12.832s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/acmpca	38.076s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amp	17.657s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/amplify	17.580s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigateway	12.728s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apigatewayv2	17.014s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appautoscaling	10.610s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	15.883s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appflow	16.180s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations	20.915s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appmesh	21.999s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	9.112s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appstream	6.943s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	9.840s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/athena	6.455s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	11.028s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscalingplans	14.975s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	13.871s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/batch	14.044s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	12.610s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	15.724s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	18.174s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloud9	21.359s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudcontrol	23.726s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation	25.147s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	29.423s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudhsmv2	16.639s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch	14.181s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	12.438s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudwatch	13.808s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codeartifact	11.522s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	9.406s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codecommit	12.204s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codepipeline	6.364s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections	8.627s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarnotifications	10.698s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	14.838s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp	8.315s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/configservice	9.121s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/connect	14.216s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cur	7.829s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dataexchange	15.742s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datapipeline	18.688s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	19.655s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dax	23.429s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/deploy	28.085s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/detective	9.190s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devicefarm	10.864s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/directconnect	15.012s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dlm	12.424s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	12.938s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/docdb	13.489s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ds	17.041s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dynamodb	7.296s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	32.055s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	9.013s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecrpublic	12.847s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	11.527s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	12.667s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/eks	15.155s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	10.307s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticbeanstalk	9.299s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch	14.995s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elastictranscoder	11.058s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elb	18.215s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	28.501s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	14.943s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrcontainers	6.576s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emrserverless	10.380s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	12.932s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	8.594s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fms	10.382s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	13.592s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/gamelift	8.098s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glacier	10.456s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/globalaccelerator	16.557s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	18.273s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/grafana	14.891s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/greengrass	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/guardduty	20.761s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	27.419s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/identitystore	23.178s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder	11.555s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector	10.768s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	11.583s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotanalytics	[no test files]
?   	github.com/hashicorp/terraform-provider-aws/internal/service/iotevents	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	12.314s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafkaconnect	13.441s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/keyspaces	11.137s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesis	7.842s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalytics	8.950s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisanalyticsv2	9.441s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kinesisvideo	9.631s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	14.235s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation	9.571s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	9.063s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexmodels	8.945s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/licensemanager	5.999s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	9.668s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/location	11.042s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/logs	13.418s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie	18.199s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	20.216s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconnect	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediaconvert	8.035s
?   	github.com/hashicorp/terraform-provider-aws/internal/service/medialive	[no test files]
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediapackage	5.366s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mediastore	15.833s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/memorydb	17.815s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	20.059s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mq	21.667s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	24.510s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/neptune	18.481s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	10.218s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager	11.274s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	8.071s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opsworks	10.070s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	11.554s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/outposts	6.256s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pinpoint	9.663s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pricing	6.249s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/qldb	7.980s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/quicksight	5.337s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ram	10.055s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	11.183s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	7.922s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshiftdata	7.789s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroups	10.653s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/resourcegroupstaggingapi	15.639s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53	13.631s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53domains	12.979s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoverycontrolconfig	13.160s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53recoveryreadiness	18.012s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	7.282s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3	13.808s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	7.180s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts	14.092s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	18.680s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/schemas	17.083s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	20.274s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/securityhub	22.887s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/serverlessrepo	22.424s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	10.811s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	7.810s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicequotas	10.033s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ses	8.938s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sfn	10.287s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/shield	9.552s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/signer	11.276s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/simpledb	15.441s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	5.417s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sqs	7.692s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssm	9.831s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ssoadmin	11.684s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/storagegateway	12.546s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sts	12.301s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/swf	14.455s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	15.283s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/timestreamwrite	8.949s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	6.244s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/waf	11.221s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafregional	11.866s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/wafv2	10.885s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/worklink	13.757s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspaces	15.791s
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/xray	14.532s
ok  	github.com/hashicorp/terraform-provider-aws/internal/tags	8.098s
ok  	github.com/hashicorp/terraform-provider-aws/internal/tfresource	45.560s
ok  	github.com/hashicorp/terraform-provider-aws/internal/vault/helper/pgpkeys	8.362s
ok  	github.com/hashicorp/terraform-provider-aws/internal/vault/sdk/helper/jsonutil	8.170s
ok  	github.com/hashicorp/terraform-provider-aws/internal/verify	4.931s
ok  	github.com/hashicorp/terraform-provider-aws/names	4.766s
?   	github.com/hashicorp/terraform-provider-aws/version	[no test files]
% make golangci-lint
==> Checking source code with golangci-lint...

@ewbankkit ewbankkit merged commit 0f9ad0e into hashicorp:main Jun 6, 2022
@github-actions github-actions bot added this to the v4.18.0 milestone Jun 6, 2022
@github-actions
Copy link

This functionality has been released in v4.18.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@DrFaust92 DrFaust92 deleted the emr-serverless branch June 23, 2022 06:10
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dacort dacort dacort left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. new-service Introduces a new service. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. skaff Issues and pull requested related to the skaff tool sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.18.0
Development

Successfully merging this pull request may close these issues.

Feature Request: EMR Serverless support
3 participants
@DrFaust92 @ewbankkit @dacort