Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add data resources aws_outposts_outposts + aws_outposts_asset #25476

Merged
merged 11 commits into from
Jun 22, 2022

Conversation

silvaalbert
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #25475

Output from acceptance testing:

$ make testacc TESTS='TestAccOutpostsAssetsDataSource_id' PKG=outposts TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/outposts/... -v -count 1 -parallel 20 -run='TestAccOutpostsAssetsDataSource_id' -short -timeout 180m
=== RUN   TestAccOutpostsAssetsDataSource_id
=== PAUSE TestAccOutpostsAssetsDataSource_id
=== CONT  TestAccOutpostsAssetsDataSource_id
--- PASS: TestAccOutpostsAssetsDataSource_id (12.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/outposts	15.090s


$ make testacc TESTS='TestAccOutpostsAssetDataSource_id' PKG=outposts TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/outposts/... -v -count 1 -parallel 20 -run='TestAccOutpostsAssetDataSource_id' -short -timeout 180m
=== RUN   TestAccOutpostsAssetDataSource_id
=== PAUSE TestAccOutpostsAssetDataSource_id
=== CONT  TestAccOutpostsAssetDataSource_id
--- PASS: TestAccOutpostsAssetDataSource_id (14.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/outposts	16.782s

...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/outposts Issues and PRs that pertain to the outposts service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Jun 19, 2022
@AdamTylerLynch AdamTylerLynch self-assigned this Jun 20, 2022
Copy link
Collaborator

@AdamTylerLynch AdamTylerLynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready! A few suggested changes.

@silvaalbert
Copy link
Contributor Author

@ewbankkit any chance we can get this merged in? Thanks!

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 22, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOutpostsAsset' PKG=outposts ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/outposts/... -v -count 1 -parallel 2  -run=TestAccOutpostsAsset -timeout 180m
=== RUN   TestAccOutpostsAssetDataSource_id
=== PAUSE TestAccOutpostsAssetDataSource_id
=== RUN   TestAccOutpostsAssetsDataSource_id
=== PAUSE TestAccOutpostsAssetsDataSource_id
=== CONT  TestAccOutpostsAssetDataSource_id
=== CONT  TestAccOutpostsAssetsDataSource_id
=== CONT  TestAccOutpostsAssetDataSource_id
    acctest.go:1308: skipping since no Outposts found
--- SKIP: TestAccOutpostsAssetDataSource_id (1.72s)
=== CONT  TestAccOutpostsAssetsDataSource_id
    acctest.go:1308: skipping since no Outposts found
--- SKIP: TestAccOutpostsAssetsDataSource_id (1.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/outposts	14.588s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f249265 into hashicorp:main Jun 22, 2022
@github-actions github-actions bot added this to the v4.20.0 milestone Jun 22, 2022
@github-actions
Copy link

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/outposts Issues and PRs that pertain to the outposts service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add data sources for outposts listassets api
5 participants