-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add data resources aws_outposts_outposts + aws_outposts_asset #25476
add data resources aws_outposts_outposts + aws_outposts_asset #25476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready! A few suggested changes.
@ewbankkit any chance we can get this merged in? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccOutpostsAsset' PKG=outposts ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/outposts/... -v -count 1 -parallel 2 -run=TestAccOutpostsAsset -timeout 180m
=== RUN TestAccOutpostsAssetDataSource_id
=== PAUSE TestAccOutpostsAssetDataSource_id
=== RUN TestAccOutpostsAssetsDataSource_id
=== PAUSE TestAccOutpostsAssetsDataSource_id
=== CONT TestAccOutpostsAssetDataSource_id
=== CONT TestAccOutpostsAssetsDataSource_id
=== CONT TestAccOutpostsAssetDataSource_id
acctest.go:1308: skipping since no Outposts found
--- SKIP: TestAccOutpostsAssetDataSource_id (1.72s)
=== CONT TestAccOutpostsAssetsDataSource_id
acctest.go:1308: skipping since no Outposts found
--- SKIP: TestAccOutpostsAssetsDataSource_id (1.73s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/outposts 14.588s
@silvaalbert Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates OR Closes #25475
Output from acceptance testing: