Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API pass-through for aws_acmpca_certificate #25520

Closed
pielu opened this issue Jun 21, 2022 · 3 comments · Fixed by #28142
Closed

API pass-through for aws_acmpca_certificate #25520

pielu opened this issue Jun 21, 2022 · 3 comments · Fixed by #28142
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/acmpca Issues and PRs that pertain to the acmpca service.
Milestone

Comments

@pielu
Copy link

pielu commented Jun 21, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Implement API pass-through parameter to allow e.g. subordinate CA to use extensions, like name restriction.

New or Affected Resource(s)

  • aws_acmpca_certificate

Potential Terraform Configuration

resource "aws_acmpca_certificate" "this" {
  certificate_authority_arn      = aws_acmpca_certificate_authority.root.arn
  certificate_signing_request    = aws_acmpca_certificate_authority.this.certificate_signing_request
  signing_algorithm              = "SHA512WITHRSA"
  template_arn                   = "arn:${data.aws_partition.current.partition}:acm-pca:::template/SubordinateCACertificate_PathLen0_APIPassthrough/V1"
  api_passthrough = <<-EOF
{
  "Extensions": {
    "CustomExtensions": [
      {
        "ObjectIdentifier": "2.5.29.30",
        "Value": "bXl0ZXN0LmNvbQ==",
        "Critical": true
      }
    ]
  }
}
EOF


  validity {
    type  = "YEARS"
    value = 15
  }
}

References

@pielu pielu added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 21, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/acmpca Issues and PRs that pertain to the acmpca service. labels Jun 21, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 20, 2022
@StupidScience
Copy link
Contributor

Hi. I'm interested in implementation. Is there any consensus on how api_passthrough parameter should look like? Since e.g. Value in custom extensions should expected to be base64 of valid ASN.1 that can be a bit problematic for user to produce. Should it be encoded by provider or should provider expect user to provide correct value (like originally defined in this issue)?

@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/acmpca Issues and PRs that pertain to the acmpca service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants