-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_acmpca_certificate: Add api_passthrough argument #28142
resource/aws_acmpca_certificate: Add api_passthrough argument #28142
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @StupidScience 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
7046cae
to
a9bca73
Compare
a46da6e
to
1fa17da
Compare
cc @ewbankkit 🙏🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccACMPCACertificate_' PKG=acmpca ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/acmpca/... -v -count 1 -parallel 3 -run=TestAccACMPCACertificate_ -timeout 180m
=== RUN TestAccACMPCACertificate_rootCertificate
=== PAUSE TestAccACMPCACertificate_rootCertificate
=== RUN TestAccACMPCACertificate_rootCertificateWithAPIPassthrough
=== PAUSE TestAccACMPCACertificate_rootCertificateWithAPIPassthrough
=== RUN TestAccACMPCACertificate_subordinateCertificate
=== PAUSE TestAccACMPCACertificate_subordinateCertificate
=== RUN TestAccACMPCACertificate_endEntityCertificate
=== PAUSE TestAccACMPCACertificate_endEntityCertificate
=== RUN TestAccACMPCACertificate_Validity_endDate
=== PAUSE TestAccACMPCACertificate_Validity_endDate
=== RUN TestAccACMPCACertificate_Validity_absolute
=== PAUSE TestAccACMPCACertificate_Validity_absolute
=== CONT TestAccACMPCACertificate_rootCertificate
=== CONT TestAccACMPCACertificate_endEntityCertificate
=== CONT TestAccACMPCACertificate_Validity_absolute
--- PASS: TestAccACMPCACertificate_rootCertificate (38.32s)
=== CONT TestAccACMPCACertificate_subordinateCertificate
--- PASS: TestAccACMPCACertificate_Validity_absolute (55.68s)
=== CONT TestAccACMPCACertificate_Validity_endDate
--- PASS: TestAccACMPCACertificate_endEntityCertificate (59.38s)
=== CONT TestAccACMPCACertificate_rootCertificateWithAPIPassthrough
--- PASS: TestAccACMPCACertificate_subordinateCertificate (36.08s)
--- PASS: TestAccACMPCACertificate_rootCertificateWithAPIPassthrough (31.28s)
--- PASS: TestAccACMPCACertificate_Validity_endDate (43.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/acmpca 131.397s
@StupidScience Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR add support for APIPassthrough argument for
aws_acmpca_certificate
resource that can be provided for certain templates.Relations
Closes #25520
References
https://docs.aws.amazon.com/acm-pca/latest/userguide/PcaIssueCert.html
https://docs.aws.amazon.com/acm-pca/latest/userguide/JavaApi-CustomExtensions.html#Sub_CA_NameConstraints
Output from Acceptance Testing