#26048 add record_size_kib to aws_fsx_openzfs_volume #26049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @pwillie 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
justinretzolk
added
enhancement
|
Hi @pwillie - thanks for raising this PR, could you please add a changelog entry? |
|
Hi @bschaatsbergen - changelog added (although think I referenced the issue rather than pull request. Is that ok?) |
Preferably we reference the pull request - if you don't mind changing it, that would be great. |
|
Good to know. Updated. |
|
LGTM 🚀 - lets wait for a core contributor to merge it The tests that failed here also fail on main |
bschaatsbergen
approved these changes
Jul 30, 2022
|
Thanks for the review @bschaatsbergen |
% make testacc TESTARGS='-run=TestAccFSxOpenzfsVolume_' PKG=fsx ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 2 -run=TestAccFSxOpenzfsVolume_ -timeout 180m
=== RUN TestAccFSxOpenzfsVolume_basic
=== PAUSE TestAccFSxOpenzfsVolume_basic
=== RUN TestAccFSxOpenzfsVolume_parentVolume
=== PAUSE TestAccFSxOpenzfsVolume_parentVolume
=== RUN TestAccFSxOpenzfsVolume_tags
=== PAUSE TestAccFSxOpenzfsVolume_tags
=== RUN TestAccFSxOpenzfsVolume_copyTags
=== PAUSE TestAccFSxOpenzfsVolume_copyTags
=== RUN TestAccFSxOpenzfsVolume_name
=== PAUSE TestAccFSxOpenzfsVolume_name
=== RUN TestAccFSxOpenzfsVolume_dataCompressionType
=== PAUSE TestAccFSxOpenzfsVolume_dataCompressionType
=== RUN TestAccFSxOpenzfsVolume_readOnly
=== PAUSE TestAccFSxOpenzfsVolume_readOnly
=== RUN TestAccFSxOpenzfsVolume_recordSizeKib
=== PAUSE TestAccFSxOpenzfsVolume_recordSizeKib
=== RUN TestAccFSxOpenzfsVolume_storageCapacity
=== PAUSE TestAccFSxOpenzfsVolume_storageCapacity
=== RUN TestAccFSxOpenzfsVolume_nfsExports
=== PAUSE TestAccFSxOpenzfsVolume_nfsExports
=== RUN TestAccFSxOpenzfsVolume_userAndGroupQuotas
=== PAUSE TestAccFSxOpenzfsVolume_userAndGroupQuotas
=== CONT TestAccFSxOpenzfsVolume_basic
=== CONT TestAccFSxOpenzfsVolume_readOnly
--- PASS: TestAccFSxOpenzfsVolume_basic (933.18s)
=== CONT TestAccFSxOpenzfsVolume_copyTags
--- PASS: TestAccFSxOpenzfsVolume_readOnly (1079.16s)
=== CONT TestAccFSxOpenzfsVolume_dataCompressionType
--- PASS: TestAccFSxOpenzfsVolume_copyTags (1066.28s)
=== CONT TestAccFSxOpenzfsVolume_name
--- PASS: TestAccFSxOpenzfsVolume_dataCompressionType (1067.53s)
=== CONT TestAccFSxOpenzfsVolume_nfsExports
=== CONT TestAccFSxOpenzfsVolume_userAndGroupQuotas
--- PASS: TestAccFSxOpenzfsVolume_name (1108.95s)
--- PASS: TestAccFSxOpenzfsVolume_nfsExports (1081.44s)
=== CONT TestAccFSxOpenzfsVolume_tags
=== CONT TestAccFSxOpenzfsVolume_userAndGroupQuotas
openzfs_volume_test.go:412: Step 1/3 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
stdout
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_fsx_openzfs_volume.test will be updated in-place
~ resource "aws_fsx_openzfs_volume" "test" {
id = "fsvol-0dfe5f622b4dbaee2"
name = "tf-acc-test-6341542772351364948"
tags = {}
# (10 unchanged attributes hidden)
- user_and_group_quotas {
- id = 0 -> null
- storage_capacity_quota_gib = 0 -> null
- type = "GROUP" -> null
}
- user_and_group_quotas {
- id = 0 -> null
- storage_capacity_quota_gib = 0 -> null
- type = "USER" -> null
}
# (2 unchanged blocks hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccFSxOpenzfsVolume_tags (922.15s)
=== CONT TestAccFSxOpenzfsVolume_storageCapacity
--- FAIL: TestAccFSxOpenzfsVolume_userAndGroupQuotas (979.88s)
=== CONT TestAccFSxOpenzfsVolume_recordSizeKib
--- PASS: TestAccFSxOpenzfsVolume_recordSizeKib (1117.72s)
=== CONT TestAccFSxOpenzfsVolume_parentVolume
--- PASS: TestAccFSxOpenzfsVolume_storageCapacity (1158.71s)
--- PASS: TestAccFSxOpenzfsVolume_parentVolume (1026.34s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/fsx 6317.256s
FAIL
make: *** [testacc] Error 1Failures are unrelated to this change and occur in nightly CI: % make testacc TESTARGS='-run=TestAccFSxOpenzfsFileSystem_' PKG=fsx ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 2 -run=TestAccFSxOpenzfsFileSystem_ -timeout 180m
=== RUN TestAccFSxOpenzfsFileSystem_basic
=== PAUSE TestAccFSxOpenzfsFileSystem_basic
=== RUN TestAccFSxOpenzfsFileSystem_diskIops
=== PAUSE TestAccFSxOpenzfsFileSystem_diskIops
=== RUN TestAccFSxOpenzfsFileSystem_disappears
=== PAUSE TestAccFSxOpenzfsFileSystem_disappears
=== RUN TestAccFSxOpenzfsFileSystem_rootVolume
=== PAUSE TestAccFSxOpenzfsFileSystem_rootVolume
=== RUN TestAccFSxOpenzfsFileSystem_securityGroupIDs
=== PAUSE TestAccFSxOpenzfsFileSystem_securityGroupIDs
=== RUN TestAccFSxOpenzfsFileSystem_tags
=== PAUSE TestAccFSxOpenzfsFileSystem_tags
=== RUN TestAccFSxOpenzfsFileSystem_copyTags
=== PAUSE TestAccFSxOpenzfsFileSystem_copyTags
=== RUN TestAccFSxOpenzfsFileSystem_throughput
=== PAUSE TestAccFSxOpenzfsFileSystem_throughput
=== RUN TestAccFSxOpenzfsFileSystem_storageType
=== PAUSE TestAccFSxOpenzfsFileSystem_storageType
=== RUN TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime
=== RUN TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays
=== RUN TestAccFSxOpenzfsFileSystem_kmsKeyID
=== PAUSE TestAccFSxOpenzfsFileSystem_kmsKeyID
=== RUN TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime
=== RUN TestAccFSxOpenzfsFileSystem_throughputCapacity
=== PAUSE TestAccFSxOpenzfsFileSystem_throughputCapacity
=== RUN TestAccFSxOpenzfsFileSystem_storageCapacity
=== PAUSE TestAccFSxOpenzfsFileSystem_storageCapacity
=== CONT TestAccFSxOpenzfsFileSystem_basic
=== CONT TestAccFSxOpenzfsFileSystem_storageType
=== CONT TestAccFSxOpenzfsFileSystem_basic
openzfs_file_system_test.go:34: Step 1/2 error: Check failed: Check 31/31 error: aws_fsx_openzfs_file_system.test: Attribute 'root_volume_configuration.0.user_and_group_quotas.#' expected "0", got "2"
--- FAIL: TestAccFSxOpenzfsFileSystem_basic (835.51s)
=== CONT TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxOpenzfsFileSystem_storageType (906.93s)
=== CONT TestAccFSxOpenzfsFileSystem_storageCapacity
--- PASS: TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime (920.81s)
=== CONT TestAccFSxOpenzfsFileSystem_throughputCapacity
--- PASS: TestAccFSxOpenzfsFileSystem_storageCapacity (1058.28s)
=== CONT TestAccFSxOpenzfsFileSystem_securityGroupIDs
--- PASS: TestAccFSxOpenzfsFileSystem_throughputCapacity (1581.71s)
=== CONT TestAccFSxOpenzfsFileSystem_throughput
--- PASS: TestAccFSxOpenzfsFileSystem_securityGroupIDs (1658.27s)
=== CONT TestAccFSxOpenzfsFileSystem_copyTags
--- PASS: TestAccFSxOpenzfsFileSystem_copyTags (961.95s)
=== CONT TestAccFSxOpenzfsFileSystem_tags
--- PASS: TestAccFSxOpenzfsFileSystem_throughput (1532.54s)
=== CONT TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxOpenzfsFileSystem_tags (896.15s)
=== CONT TestAccFSxOpenzfsFileSystem_kmsKeyID
--- PASS: TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays (1034.84s)
=== CONT TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime
--- PASS: TestAccFSxOpenzfsFileSystem_kmsKeyID (936.06s)
=== CONT TestAccFSxOpenzfsFileSystem_disappears
--- PASS: TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime (920.33s)
=== CONT TestAccFSxOpenzfsFileSystem_rootVolume
openzfs_file_system_test.go:153: Step 1/5 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
stdout
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# aws_fsx_openzfs_file_system.test will be updated in-place
~ resource "aws_fsx_openzfs_file_system" "test" {
id = "fs-02f5f4243890ced4b"
tags = {
"Name" = "tf-acc-test-378952906849157547"
}
# (17 unchanged attributes hidden)
~ root_volume_configuration {
# (4 unchanged attributes hidden)
- user_and_group_quotas {
- id = 0 -> null
- storage_capacity_quota_gib = 0 -> null
- type = "GROUP" -> null
}
- user_and_group_quotas {
- id = 0 -> null
- storage_capacity_quota_gib = 0 -> null
- type = "USER" -> null
}
# (2 unchanged blocks hidden)
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccFSxOpenzfsFileSystem_disappears (810.46s)
=== CONT TestAccFSxOpenzfsFileSystem_diskIops
--- FAIL: TestAccFSxOpenzfsFileSystem_rootVolume (865.53s)
--- PASS: TestAccFSxOpenzfsFileSystem_diskIops (789.74s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/fsx 8021.959s
FAIL
make: *** [testacc] Error 1Failures are unrelated to this change and have been noted in other PRs. |
|
@pwillie Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #26048
Output from acceptance testing: