support updating fsx openzfs storage, throughput, and iops

[troy-f]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25716
Based on PR #24002

Output from acceptance testing:

$ make testacc TESTS=TestAccFSxOpenzfsFileSystem_ PKG=fsx ACCTEST_PARALLELISM=2 ACCTEST_TIMEOUT=720m

--- PASS: TestAccFSxOpenzfsFileSystem_diskIops (925.97s)
--- PASS: TestAccFSxOpenzfsFileSystem_storageCapacity (780.80s)

[github-actions]

Welcome @troy-f 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccFSxOpenzfsFileSystem_' PKG=fsx ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxOpenzfsFileSystem_ -timeout 180m
=== RUN   TestAccFSxOpenzfsFileSystem_basic
=== PAUSE TestAccFSxOpenzfsFileSystem_basic
=== RUN   TestAccFSxOpenzfsFileSystem_diskIops
=== PAUSE TestAccFSxOpenzfsFileSystem_diskIops
=== RUN   TestAccFSxOpenzfsFileSystem_disappears
=== PAUSE TestAccFSxOpenzfsFileSystem_disappears
=== RUN   TestAccFSxOpenzfsFileSystem_rootVolume
=== PAUSE TestAccFSxOpenzfsFileSystem_rootVolume
=== RUN   TestAccFSxOpenzfsFileSystem_securityGroupIDs
=== PAUSE TestAccFSxOpenzfsFileSystem_securityGroupIDs
=== RUN   TestAccFSxOpenzfsFileSystem_tags
=== PAUSE TestAccFSxOpenzfsFileSystem_tags
=== RUN   TestAccFSxOpenzfsFileSystem_copyTags
=== PAUSE TestAccFSxOpenzfsFileSystem_copyTags
=== RUN   TestAccFSxOpenzfsFileSystem_throughput
=== PAUSE TestAccFSxOpenzfsFileSystem_throughput
=== RUN   TestAccFSxOpenzfsFileSystem_storageType
=== PAUSE TestAccFSxOpenzfsFileSystem_storageType
=== RUN   TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxOpenzfsFileSystem_kmsKeyID
=== PAUSE TestAccFSxOpenzfsFileSystem_kmsKeyID
=== RUN   TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccFSxOpenzfsFileSystem_throughputCapacity
=== PAUSE TestAccFSxOpenzfsFileSystem_throughputCapacity
=== RUN   TestAccFSxOpenzfsFileSystem_storageCapacity
=== PAUSE TestAccFSxOpenzfsFileSystem_storageCapacity
=== CONT  TestAccFSxOpenzfsFileSystem_basic
=== CONT  TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime
=== CONT  TestAccFSxOpenzfsFileSystem_storageType
=== CONT  TestAccFSxOpenzfsFileSystem_basic
    openzfs_file_system_test.go:34: Step 1/2 error: Check failed: Check 30/30 error: aws_fsx_openzfs_file_system.test: Attribute 'root_volume_configuration.0.user_and_group_quotas.#' expected "0", got "2"
--- PASS: TestAccFSxOpenzfsFileSystem_storageType (702.59s)
=== CONT  TestAccFSxOpenzfsFileSystem_storageCapacity
--- FAIL: TestAccFSxOpenzfsFileSystem_basic (723.39s)
=== CONT  TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxOpenzfsFileSystem_dailyAutomaticBackupStartTime (872.76s)
=== CONT  TestAccFSxOpenzfsFileSystem_kmsKeyID
--- PASS: TestAccFSxOpenzfsFileSystem_kmsKeyID (720.81s)
=== CONT  TestAccFSxOpenzfsFileSystem_securityGroupIDs
--- PASS: TestAccFSxOpenzfsFileSystem_storageCapacity (975.13s)
=== CONT  TestAccFSxOpenzfsFileSystem_throughput
--- PASS: TestAccFSxOpenzfsFileSystem_automaticBackupRetentionDays (1015.66s)
=== CONT  TestAccFSxOpenzfsFileSystem_copyTags
--- PASS: TestAccFSxOpenzfsFileSystem_copyTags (797.45s)
=== CONT  TestAccFSxOpenzfsFileSystem_tags
--- PASS: TestAccFSxOpenzfsFileSystem_securityGroupIDs (1533.39s)
=== CONT  TestAccFSxOpenzfsFileSystem_disappears
--- PASS: TestAccFSxOpenzfsFileSystem_throughput (1550.01s)
=== CONT  TestAccFSxOpenzfsFileSystem_rootVolume
--- PASS: TestAccFSxOpenzfsFileSystem_tags (741.30s)
=== CONT  TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime
=== CONT  TestAccFSxOpenzfsFileSystem_rootVolume
    openzfs_file_system_test.go:152: Step 1/5 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_fsx_openzfs_file_system.test will be updated in-place
          ~ resource "aws_fsx_openzfs_file_system" "test" {
                id                              = "fs-09e7a74ed7b570bb3"
                tags                            = {
                    "Name" = "tf-acc-test-2519637767182146990"
                }
                # (17 unchanged attributes hidden)
        
        
              ~ root_volume_configuration {
                    # (3 unchanged attributes hidden)
        
        
                  - user_and_group_quotas {
                      - id                         = 0 -> null
                      - storage_capacity_quota_gib = 0 -> null
                      - type                       = "GROUP" -> null
                    }
                  - user_and_group_quotas {
                      - id                         = 0 -> null
                      - storage_capacity_quota_gib = 0 -> null
                      - type                       = "USER" -> null
                    }
                    # (2 unchanged blocks hidden)
                }
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- PASS: TestAccFSxOpenzfsFileSystem_disappears (808.68s)
=== CONT  TestAccFSxOpenzfsFileSystem_throughputCapacity
--- FAIL: TestAccFSxOpenzfsFileSystem_rootVolume (757.52s)
=== CONT  TestAccFSxOpenzfsFileSystem_diskIops
--- PASS: TestAccFSxOpenzfsFileSystem_weeklyMaintenanceStartTime (849.88s)
--- PASS: TestAccFSxOpenzfsFileSystem_diskIops (923.59s)
--- PASS: TestAccFSxOpenzfsFileSystem_throughputCapacity (1358.69s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	5300.796s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change.

[ewbankkit]

@troy-f Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.