r/fsx_ontap_file_system - Support updating storage_capacity, throughput_capacity, disk_iops_configuration

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #23983
Closes #23982
Closes #23861

Output from acceptance testing:

$ make testacc TESTS=TestAccFSxOntapFileSystem_ PKG=fsx

--- PASS: TestAccFSxOntapFileSystem_endpointIPAddressRange (2030.71s)
--- PASS: TestAccFSxOntapFileSystem_basic (2051.03s)
--- PASS: TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime (2109.52s)
--- PASS: TestAccFSxOntapFileSystem_fsxAdminPassword (2173.09s)
--- PASS: TestAccFSxOntapFileSystem_disappears (2212.25s)
--- PASS: TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime (2234.94s)
--- PASS: TestAccFSxOntapFileSystem_storageCapacity (2235.10s)
--- PASS: TestAccFSxOntapFileSystem_routeTableIDs (2235.11s)
--- PASS: TestAccFSxOntapFileSystem_automaticBackupRetentionDays (2313.13s)
--- PASS: TestAccFSxOntapFileSystem_tags (2439.78s)
--- PASS: TestAccFSxOntapFileSystem_kmsKeyID (2477.77s)
--- PASS: TestAccFSxOntapFileSystem_diskIops (2174.13s)
--- PASS: TestAccFSxOntapFileSystem_throughputCapacity (3168.08s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTS=TestAccFSxOntapFileSystem_ PKG=fsx ACCTEST_PARALLELISM=2 ACCTEST_TIMEOUT=720m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/fsx/... -v -count 1 -parallel 2 -run='TestAccFSxOntapFileSystem_'  -timeout 720m
=== RUN   TestAccFSxOntapFileSystem_basic
=== PAUSE TestAccFSxOntapFileSystem_basic
=== RUN   TestAccFSxOntapFileSystem_fsxAdminPassword
=== PAUSE TestAccFSxOntapFileSystem_fsxAdminPassword
=== RUN   TestAccFSxOntapFileSystem_endpointIPAddressRange
=== PAUSE TestAccFSxOntapFileSystem_endpointIPAddressRange
=== RUN   TestAccFSxOntapFileSystem_diskIops
=== PAUSE TestAccFSxOntapFileSystem_diskIops
=== RUN   TestAccFSxOntapFileSystem_disappears
=== PAUSE TestAccFSxOntapFileSystem_disappears
=== RUN   TestAccFSxOntapFileSystem_securityGroupIDs
=== PAUSE TestAccFSxOntapFileSystem_securityGroupIDs
=== RUN   TestAccFSxOntapFileSystem_routeTableIDs
=== PAUSE TestAccFSxOntapFileSystem_routeTableIDs
=== RUN   TestAccFSxOntapFileSystem_tags
=== PAUSE TestAccFSxOntapFileSystem_tags
=== RUN   TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
=== PAUSE TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
=== RUN   TestAccFSxOntapFileSystem_automaticBackupRetentionDays
=== PAUSE TestAccFSxOntapFileSystem_automaticBackupRetentionDays
=== RUN   TestAccFSxOntapFileSystem_kmsKeyID
=== PAUSE TestAccFSxOntapFileSystem_kmsKeyID
=== RUN   TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
=== PAUSE TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
=== RUN   TestAccFSxOntapFileSystem_throughputCapacity
=== PAUSE TestAccFSxOntapFileSystem_throughputCapacity
=== RUN   TestAccFSxOntapFileSystem_storageCapacity
=== PAUSE TestAccFSxOntapFileSystem_storageCapacity
=== CONT  TestAccFSxOntapFileSystem_basic
=== CONT  TestAccFSxOntapFileSystem_tags
--- PASS: TestAccFSxOntapFileSystem_basic (2070.34s)
=== CONT  TestAccFSxOntapFileSystem_storageCapacity
--- PASS: TestAccFSxOntapFileSystem_tags (2112.19s)
=== CONT  TestAccFSxOntapFileSystem_throughputCapacity
--- PASS: TestAccFSxOntapFileSystem_storageCapacity (2233.40s)
=== CONT  TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime
--- PASS: TestAccFSxOntapFileSystem_throughputCapacity (3751.62s)
=== CONT  TestAccFSxOntapFileSystem_kmsKeyID
--- PASS: TestAccFSxOntapFileSystem_dailyAutomaticBackupStartTime (2125.86s)
=== CONT  TestAccFSxOntapFileSystem_automaticBackupRetentionDays
--- PASS: TestAccFSxOntapFileSystem_kmsKeyID (1996.81s)
=== CONT  TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime
--- PASS: TestAccFSxOntapFileSystem_automaticBackupRetentionDays (2131.41s)
=== CONT  TestAccFSxOntapFileSystem_routeTableIDs
--- PASS: TestAccFSxOntapFileSystem_weeklyMaintenanceStartTime (2134.65s)
=== CONT  TestAccFSxOntapFileSystem_securityGroupIDs
--- PASS: TestAccFSxOntapFileSystem_routeTableIDs (2235.04s)
=== CONT  TestAccFSxOntapFileSystem_endpointIPAddressRange
--- PASS: TestAccFSxOntapFileSystem_endpointIPAddressRange (2316.55s)
=== CONT  TestAccFSxOntapFileSystem_diskIops
--- PASS: TestAccFSxOntapFileSystem_securityGroupIDs (4501.38s)
=== CONT  TestAccFSxOntapFileSystem_fsxAdminPassword
--- PASS: TestAccFSxOntapFileSystem_diskIops (2139.55s)
=== CONT  TestAccFSxOntapFileSystem_disappears
--- PASS: TestAccFSxOntapFileSystem_fsxAdminPassword (2033.79s)
--- PASS: TestAccFSxOntapFileSystem_disappears (2271.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	17527.925s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.