fix(ec2_eip): Fix default tags not set, #25567

[sbocinec]

Signed-off-by: Stano Bocinec stano@redpanda.com

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25567

Output from acceptance testing:

$ make testacc TESTS=TestAccEC2EIP_Tags PKG=ec2 AWS_REGION=eu-north-1                                                                  ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2EIP_Tags'  -timeout 180m
=== RUN   TestAccEC2EIP_TagsEC2VPC_withVPCTrue
=== PAUSE TestAccEC2EIP_TagsEC2VPC_withVPCTrue
=== RUN   TestAccEC2EIP_TagsEC2VPC_withoutVPCTrue
=== PAUSE TestAccEC2EIP_TagsEC2VPC_withoutVPCTrue
=== RUN   TestAccEC2EIP_TagsEC2Classic_withVPCTrue
=== PAUSE TestAccEC2EIP_TagsEC2Classic_withVPCTrue
=== RUN   TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue
=== PAUSE TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue
=== CONT  TestAccEC2EIP_TagsEC2VPC_withVPCTrue
=== CONT  TestAccEC2EIP_TagsEC2Classic_withVPCTrue
=== CONT  TestAccEC2EIP_TagsEC2VPC_withoutVPCTrue
=== CONT  TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue
=== CONT  TestAccEC2EIP_TagsEC2Classic_withVPCTrue
    ec2_classic.go:62: this test can only run in EC2-Classic, platforms available in us-east-1: ["VPC"]
--- SKIP: TestAccEC2EIP_TagsEC2Classic_withVPCTrue (4.19s)
=== CONT  TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue
    ec2_classic.go:62: this test can only run in EC2-Classic, platforms available in us-east-1: ["VPC"]
--- SKIP: TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue (4.19s)
--- PASS: TestAccEC2EIP_TagsEC2VPC_withVPCTrue (39.31s)
--- PASS: TestAccEC2EIP_TagsEC2VPC_withoutVPCTrue (39.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	39.370s
...

Rationale

The default_tags set on the provider level are not applied on the aws_eip resource created. This bug fires when there are only default_tags set as the resource implementation is actually not properly checking length of merged tags (default + resource level). This PR fixes this

[github-actions]

Welcome @sbocinec 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2EIP_Tags' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccEC2EIP_Tags -timeout 180m
=== RUN   TestAccEC2EIP_TagsEC2VPC_withVPCTrue
=== PAUSE TestAccEC2EIP_TagsEC2VPC_withVPCTrue
=== RUN   TestAccEC2EIP_TagsEC2VPC_withoutVPCTrue
=== PAUSE TestAccEC2EIP_TagsEC2VPC_withoutVPCTrue
=== RUN   TestAccEC2EIP_TagsEC2Classic_withVPCTrue
=== PAUSE TestAccEC2EIP_TagsEC2Classic_withVPCTrue
=== RUN   TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue
=== PAUSE TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue
=== CONT  TestAccEC2EIP_TagsEC2VPC_withVPCTrue
=== CONT  TestAccEC2EIP_TagsEC2Classic_withVPCTrue
--- PASS: TestAccEC2EIP_TagsEC2Classic_withVPCTrue (18.93s)
=== CONT  TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue
--- PASS: TestAccEC2EIP_TagsEC2Classic_withoutVPCTrue (3.23s)
=== CONT  TestAccEC2EIP_TagsEC2VPC_withoutVPCTrue
--- PASS: TestAccEC2EIP_TagsEC2VPC_withVPCTrue (27.20s)
--- PASS: TestAccEC2EIP_TagsEC2VPC_withoutVPCTrue (26.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	52.178s

[github-actions]

This functionality has been released in v4.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.