Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2_eip): Fix default tags not set, #25567 #26308

Merged
merged 2 commits into from
Aug 22, 2022
Merged

fix(ec2_eip): Fix default tags not set, #25567 #26308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8860132
fix(ec2_eip): Fix default tags not set, #25567
sbocinec Aug 15, 2022
890f738
Add CHANGELOG entry.
ewbankkit Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/26308.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_eip: Include any provider-level configured `default_tags` on resource Create
```
2 changes: 1 addition & 1 deletion internal/service/ec2/ec2_eip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ func resourceEIPCreate(d *schema.ResourceData, meta interface{}) error {
Domain: aws.String(domainOpt),
}

if v := d.Get("tags").(map[string]interface{}); len(v) > 0 {
if len(tags) > 0 {
supportedPlatforms := meta.(*conns.AWSClient).SupportedPlatforms
if domainOpt != ec2.DomainTypeVpc && len(supportedPlatforms) > 0 && conns.HasEC2Classic(supportedPlatforms) {
return fmt.Errorf("tags cannot be set for a standard-domain EIP - must be a VPC-domain EIP")
Expand Down