aws_dms_endpoint redis target settings bug fix

[peresypkinroman]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Closes #26266

Output from acceptance testing:

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Welcome @peresypkinroman 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[peresypkinroman]

Notes

• Moved server_name and port to redis_settings block as it is referred in aws docs . Do not know if top level server_name and port are obligatory to terraform aws provider. AWS body json stores them in redis_settings as defined in Specifying endpoint settings for Redis as a target
• marked Required necessary fields
• marked ssl_security_protocol as Required. Let's force users to specify it explicitly. It is not required in aws docs

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSEndpoint_redis\|TestAccDMSEndpoint_basic\|TestAccDMSEndpoint_S3_basic' PKG=dms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 2  -run=TestAccDMSEndpoint_redis\|TestAccDMSEndpoint_basic\|TestAccDMSEndpoint_S3_basic -timeout 180m
=== RUN   TestAccDMSEndpoint_basic
=== PAUSE TestAccDMSEndpoint_basic
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_redis
=== PAUSE TestAccDMSEndpoint_redis
=== CONT  TestAccDMSEndpoint_basic
=== CONT  TestAccDMSEndpoint_redis
--- PASS: TestAccDMSEndpoint_redis (44.91s)
=== CONT  TestAccDMSEndpoint_S3_basic
--- PASS: TestAccDMSEndpoint_basic (45.45s)
--- PASS: TestAccDMSEndpoint_S3_basic (48.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	97.411s

[ewbankkit]

@peresypkinroman Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.29.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.