Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_apprunner_vpc_ingress_connection #27600

Merged

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Nov 2, 2022

Description

Add support for AppRunner private endpoint using VPC ingress connection

Relations

Closes #27576

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccAppRunnerVPCIngressConnection_ PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerVPCIngressConnection_'  -timeout 180m
=== RUN   TestAccAppRunnerVPCIngressConnection_basic
=== PAUSE TestAccAppRunnerVPCIngressConnection_basic
=== RUN   TestAccAppRunnerVPCIngressConnection_disappears
=== PAUSE TestAccAppRunnerVPCIngressConnection_disappears
=== RUN   TestAccAppRunnerVPCIngressConnection_tags
=== PAUSE TestAccAppRunnerVPCIngressConnection_tags
=== CONT  TestAccAppRunnerVPCIngressConnection_basic
=== CONT  TestAccAppRunnerVPCIngressConnection_tags
=== CONT  TestAccAppRunnerVPCIngressConnection_disappears
--- PASS: TestAccAppRunnerVPCIngressConnection_basic (444.91s)
--- PASS: TestAccAppRunnerVPCIngressConnection_disappears (460.85s)
--- PASS: TestAccAppRunnerVPCIngressConnection_tags (469.17s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  470.973s

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/apprunner Issues and PRs that pertain to the apprunner service. needs-triage Waiting for first response or review from a maintainer. labels Nov 2, 2022
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Nov 2, 2022
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Nov 2, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 2, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review November 2, 2022 21:12
@bschaatsbergen
Copy link
Member Author

Ready for review 👍

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppRunnerVPCIngressConnection_' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerVPCIngressConnection_ -timeout 180m
=== RUN   TestAccAppRunnerVPCIngressConnection_basic
=== PAUSE TestAccAppRunnerVPCIngressConnection_basic
=== RUN   TestAccAppRunnerVPCIngressConnection_disappears
=== PAUSE TestAccAppRunnerVPCIngressConnection_disappears
=== RUN   TestAccAppRunnerVPCIngressConnection_tags
=== PAUSE TestAccAppRunnerVPCIngressConnection_tags
=== CONT  TestAccAppRunnerVPCIngressConnection_basic
=== CONT  TestAccAppRunnerVPCIngressConnection_tags
--- PASS: TestAccAppRunnerVPCIngressConnection_basic (544.63s)
=== CONT  TestAccAppRunnerVPCIngressConnection_disappears
--- PASS: TestAccAppRunnerVPCIngressConnection_tags (734.57s)
--- PASS: TestAccAppRunnerVPCIngressConnection_disappears (531.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	1085.361s
% make testacc TESTARGS='-run=TestAccAppRunnerService_ImageRepository_basic' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerService_ImageRepository_basic -timeout 180m
=== RUN   TestAccAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAppRunnerService_ImageRepository_basic
=== CONT  TestAccAppRunnerService_ImageRepository_basic
--- PASS: TestAccAppRunnerService_ImageRepository_basic (275.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	283.778s
% make testacc TESTARGS='-run=TestAccAppRunnerService_ImageRepository_networkConfiguration' PKG=apprunner ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 2  -run=TestAccAppRunnerService_ImageRepository_networkConfiguration -timeout 180m
=== RUN   TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== CONT  TestAccAppRunnerService_ImageRepository_networkConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_networkConfiguration (569.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	574.911s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a5dca97 into hashicorp:main Nov 3, 2022
@github-actions github-actions bot added this to the v4.38.0 milestone Nov 3, 2022
@bschaatsbergen bschaatsbergen deleted the r/vpc-ingress-connection-app-runner branch November 3, 2022 15:03
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This functionality has been released in v4.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/apprunner Issues and PRs that pertain to the apprunner service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: AppRunner VPC Ingress Connection (private endpoint)
3 participants