Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for creating private services with VPC ingress connection #2

Merged

Conversation

bryantbiggs
Copy link
Member

Description

Motivation and Context

  • Allows users to create private services to be used within a VPC and not publicly accessible

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member Author

Ps - might need to enable branch protection to require a review on this repo

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antonbabenko
Copy link
Member

Ps - might need to enable branch protection to require a review on this repo

Agree, I will fix it on Monday for some newer repos, too.

@antonbabenko antonbabenko merged commit 214af5c into terraform-aws-modules:master Nov 4, 2022
antonbabenko pushed a commit that referenced this pull request Nov 4, 2022
## [1.1.0](v1.0.1...v1.1.0) (2022-11-04)

### Features

* Add support for creating private services with VPC ingress connection ([#2](#2)) ([214af5c](214af5c))
@antonbabenko
Copy link
Member

This PR is included in version 1.1.0 🎉

@bryantbiggs bryantbiggs deleted the feat/private-service branch November 4, 2022 11:21
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants