Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_appflow_connector_profile sapo_data logon_language validation error #28550

Closed
jclRatepay opened this issue Dec 23, 2022 · 3 comments · Fixed by #28608
Closed

[Bug]: aws_appflow_connector_profile sapo_data logon_language validation error #28550

jclRatepay opened this issue Dec 23, 2022 · 3 comments · Fixed by #28608
Labels
bug Addresses a defect in current functionality. service/appflow Issues and PRs that pertain to the appflow service.
Milestone

Comments

@jclRatepay
Copy link
Contributor

jclRatepay commented Dec 23, 2022

Terraform Core Version

1.3.6

AWS Provider Version

4.48.0

Affected Resource(s)

  • aws_appflow_connector_profile

Expected Behavior

When specifying a valid sapo_data.logon_language value (e.g. EN) for the Connector Profile (aws_appflow_connector_profile.connector_profile_config.0.connector_profile_properties.0.sapo_data.0.logon_language) it should be applied just as if would have set exactly this value when setting up the Connector via the AWS Mgmt. Console

Actual Behavior

When trying to set up the connector with the (luckily optional) logon_language field set to e.g. "EN" it fails with a bit weird validation error message - so currently one is enforced to not include this field in the Terraform resource. However, when setting the value via AWS Mgmt. Console the change/different value is recognized correctly.
Weird error message because as one can see it is complaining about a completely different field. But without specifying a value for the logon_language field everything works as expected.

Relevant Error/Panic Output Snippet

│ Error: invalid value for connector_profile_config.0.connector_profile_properties.0.sapo_data.0.logon_language (must contain only alphanumeric characters and the underscore (_) character)
│ 
│   with module.sap_connector.aws_appflow_connector_profile.private_sap_odata_connector[0],
│   on ../connectors/sap/main.tf line 276, in resource "aws_appflow_connector_profile" "private_sap_odata_connector":
│  276:         private_link_service_name = aws_vpc_endpoint_service.sap_odata_endpoint_service[0].service_name

Terraform Configuration Files

resource "aws_appflow_connector_profile" "private_sap_odata_connector" {
  count      = var.connection_mode == local.connection_mode.private ? 1 : 0
  depends_on = [time_sleep.wait_for_sap_odata_endpoint_service_verification[0]]

  name            =  var.name
  connection_mode = "Private"
  connector_type  = "SAPOData"

  connector_profile_config {
    connector_profile_credentials {
      sapo_data {
        basic_auth_credentials {
            username = local.basic_auth_credentials_json[local.auth_credential_secret_keys.basic.username]
            password = local.basic_auth_credentials_json[local.auth_credential_secret_keys.basic.password]
        }
      }
    }

    connector_profile_properties {
      sapo_data {
        private_link_service_name = aws_vpc_endpoint_service.sap_odata_endpoint_service[0].service_name
        application_host_url      = "https://${aws_vpc_endpoint_service.sap_odata_endpoint_service[0].private_dns_name}"
        port_number               = aws_lb_listener.sap_odata_endpoint_service_nlb_listener[0].port
        application_service_path  = var.sap_service_path
        client_number             = var.sap_client_number
        logon_language            = var.sap_logon_language
      }
    }
  }
}

Steps to Reproduce

terraform plan

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

Yes

@jclRatepay jclRatepay added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Dec 23, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/appflow Issues and PRs that pertain to the appflow service. label Dec 23, 2022
@jclRatepay jclRatepay changed the title [Bug]: [Bug]: aws_appflow_connector_profile sapo_data logon_language validation error Dec 23, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 3, 2023
@github-actions github-actions bot added this to the v4.55.0 milestone Feb 10, 2023
@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appflow Issues and PRs that pertain to the appflow service.
Projects
None yet
2 participants