Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in validation regex of aws_appflow_connector_profile resource #28608

Conversation

jclRatepay
Copy link
Contributor

Description

Fixed bug in validation regex of "aws_appflow_connector_profile" resource causing any given value for the "connector_profile_config.0.connector_profile_properties.0.sapo_data.0.logon_language" field to be denied

Relations

Closes #28550

References

Output from Acceptance Testing

Checking the available acceptance tests I quickly realized that due to the huge amount of possible argument combinations on the one hand and the necessity for having a huge bunch of third party applications like Salesforce or SAP available no specific tests for that scenario exists.
However, to test the fix I used my local development environment and checked whether setting an AppFlow Connector's SAP logon language via the updated Terraform Provider code is now possible when using a valid value (e.g. EN), and it worked as expected and is not failing with validation errors during planning anymore.

…ce causing any given value for the sapo_data's profile properties logon_language field to be denied
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/appflow Issues and PRs that pertain to the appflow service. labels Dec 29, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=appflow TESTS=TestAccAppFlowConnectorProfile_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowConnectorProfile_'  -timeout 180m
=== RUN   TestAccAppFlowConnectorProfile_basic
=== PAUSE TestAccAppFlowConnectorProfile_basic
=== RUN   TestAccAppFlowConnectorProfile_update
=== PAUSE TestAccAppFlowConnectorProfile_update
=== RUN   TestAccAppFlowConnectorProfile_disappears
=== PAUSE TestAccAppFlowConnectorProfile_disappears
=== CONT  TestAccAppFlowConnectorProfile_basic
=== CONT  TestAccAppFlowConnectorProfile_disappears
=== CONT  TestAccAppFlowConnectorProfile_update
--- PASS: TestAccAppFlowConnectorProfile_disappears (241.68s)
--- PASS: TestAccAppFlowConnectorProfile_update (289.88s)
--- PASS: TestAccAppFlowConnectorProfile_basic (319.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appflow    322.786s

@jar-b jar-b merged commit 0557678 into hashicorp:main Feb 10, 2023
@jar-b
Copy link
Member

jar-b commented Feb 10, 2023

Thanks for your contribution, @jclRatepay! 👍

@github-actions github-actions bot added this to the v4.55.0 milestone Feb 10, 2023
@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appflow Issues and PRs that pertain to the appflow service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_appflow_connector_profile sapo_data logon_language validation error
3 participants