Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Enable ThresholdExpression in aws_ce_anomaly_subscription #28571

Closed
ad-m-ss opened this issue Dec 23, 2022 · 3 comments · Fixed by #28573
Closed

[Enhancement]: Enable ThresholdExpression in aws_ce_anomaly_subscription #28571

ad-m-ss opened this issue Dec 23, 2022 · 3 comments · Fixed by #28573
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ce Issues and PRs that pertain to the ce service.
Milestone

Comments

@ad-m-ss
Copy link

ad-m-ss commented Dec 23, 2022

Description

AWS deprecated property "Threshold" in AnomalySubscription of AWS Cost Anomaly Detector. They recommend using ThresholdExpression instead, but this is unsupported by Terraform provider.

Affected Resource(s) and/or Data Source(s)

  • resource aws_ce_anomaly_subscription

Potential Terraform Configuration

resource "aws_ce_anomaly_subscription" "realtime_subscription" {
  name      = "RealtimeAnomalySubscription"
  threshold_expression = jsonencode({ "Or": [ { "Dimensions": { "Key": "ANOMALY_TOTAL_IMPACT_ABSOLUTE", "MatchOptions": [ "GREATER_THAN_OR_EQUAL" ], "Values": [ "100" ] } }, { "Dimensions": { "Key": "ANOMALY_TOTAL_IMPACT_PERCENTAGE", "MatchOptions": [ "GREATER_THAN_OR_EQUAL" ], "Values": [ "100" ] } } ] })
  frequency = "IMMEDIATE"

  monitor_arn_list = [
    aws_ce_anomaly_monitor.anomaly_monitor.arn,
  ]

  subscriber {
    type    = "SNS"
    address = aws_sns_topic.cost_anomaly_updates.arn
  }

  depends_on = [
    aws_sns_topic_policy.default,
  ]
}

References

https://docs.aws.amazon.com/aws-cost-management/latest/APIReference/API_AnomalySubscription.html

Would you like to implement a fix?

No

@ad-m-ss ad-m-ss added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Dec 23, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/ce Issues and PRs that pertain to the ce service. label Dec 23, 2022
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Dec 24, 2022
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 18, 2023
@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ce Issues and PRs that pertain to the ce service.
Projects
None yet
2 participants