Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ce_anomaly_subscripton - add threshold_expression and deprecate threshold #28573

Merged
merged 8 commits into from
Jan 18, 2023

Conversation

DrFaust92
Copy link
Collaborator

Description

Relations

Closes #28571

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccCEAnomalySubscription_ PKG=ce

--- PASS: TestAccCEAnomalySubscription_disappears (26.03s)
--- PASS: TestAccCEAnomalySubscription_basic (29.81s)
--- PASS: TestAccCEAnomalySubscription_thresholdExpression (30.07s)
--- PASS: TestAccCEAnomalySubscription_Frequency (46.56s)
--- PASS: TestAccCEAnomalySubscription_Threshold (48.53s)
--- PASS: TestAccCEAnomalySubscription_MonitorARNList (49.49s)
--- PASS: TestAccCEAnomalySubscription_Tags (64.24s)
--- PASS: TestAccCEAnomalySubscription_Subscriber (92.84s)

@DrFaust92 DrFaust92 changed the title r/ce_anomaly_subscripton - add threshold expression and deprecate threshold` r/ce_anomaly_subscripton - add threshold expression and deprecate threshold Dec 24, 2022
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ce Issues and PRs that pertain to the ce service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 24, 2022
@DrFaust92 DrFaust92 changed the title r/ce_anomaly_subscripton - add threshold expression and deprecate threshold r/ce_anomaly_subscripton - add threshold_expression and deprecate threshold Dec 24, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 24, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review December 24, 2022 15:30
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCEAnomalySubscription_' PKG=ce ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 3  -run=TestAccCEAnomalySubscription_ -timeout 180m
=== RUN   TestAccCEAnomalySubscription_basic
=== PAUSE TestAccCEAnomalySubscription_basic
=== RUN   TestAccCEAnomalySubscription_thresholdExpression
=== PAUSE TestAccCEAnomalySubscription_thresholdExpression
=== RUN   TestAccCEAnomalySubscription_disappears
=== PAUSE TestAccCEAnomalySubscription_disappears
=== RUN   TestAccCEAnomalySubscription_Frequency
=== PAUSE TestAccCEAnomalySubscription_Frequency
=== RUN   TestAccCEAnomalySubscription_MonitorARNList
=== PAUSE TestAccCEAnomalySubscription_MonitorARNList
=== RUN   TestAccCEAnomalySubscription_Subscriber
=== PAUSE TestAccCEAnomalySubscription_Subscriber
=== RUN   TestAccCEAnomalySubscription_Threshold
=== PAUSE TestAccCEAnomalySubscription_Threshold
=== RUN   TestAccCEAnomalySubscription_Tags
=== PAUSE TestAccCEAnomalySubscription_Tags
=== CONT  TestAccCEAnomalySubscription_basic
=== CONT  TestAccCEAnomalySubscription_MonitorARNList
=== CONT  TestAccCEAnomalySubscription_disappears
--- PASS: TestAccCEAnomalySubscription_disappears (28.27s)
=== CONT  TestAccCEAnomalySubscription_thresholdExpression
--- PASS: TestAccCEAnomalySubscription_basic (31.38s)
=== CONT  TestAccCEAnomalySubscription_Threshold
--- PASS: TestAccCEAnomalySubscription_MonitorARNList (43.49s)
=== CONT  TestAccCEAnomalySubscription_Tags
--- PASS: TestAccCEAnomalySubscription_thresholdExpression (18.45s)
=== CONT  TestAccCEAnomalySubscription_Frequency
--- PASS: TestAccCEAnomalySubscription_Threshold (30.84s)
=== CONT  TestAccCEAnomalySubscription_Subscriber
--- PASS: TestAccCEAnomalySubscription_Frequency (30.97s)
--- PASS: TestAccCEAnomalySubscription_Tags (42.84s)
--- PASS: TestAccCEAnomalySubscription_Subscriber (60.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	127.604s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d271761 into hashicorp:main Jan 18, 2023
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 18, 2023
@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ce Issues and PRs that pertain to the ce service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Enable ThresholdExpression in aws_ce_anomaly_subscription
2 participants