Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_rds_cluster Multi-AZ Cluster performance insights #29414

Closed
tedsmitt opened this issue Feb 15, 2023 · 6 comments · Fixed by #29415
Closed

[Enhancement]: aws_rds_cluster Multi-AZ Cluster performance insights #29414

tedsmitt opened this issue Feb 15, 2023 · 6 comments · Fixed by #29415
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@tedsmitt
Copy link

tedsmitt commented Feb 15, 2023

Description

Add the option to enable performance insights (and associated settings) for a Multi-AZ RDS Cluster.

I have already prepared the code for this, and will submit this shortly.

Affected Resource(s) and/or Data Source(s)

aws_rds_cluster

Potential Terraform Configuration

resource "aws_rds_cluster" "mysql" {
  ...

  performance_insights_enabled          = true
  performance_insights_kms_key_id       = aws_kms_key.test.arn
  performance_insights_retention_period = 31
}

References

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/create-multi-az-db-cluster.html#create-multi-az-db-cluster-settings
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_PerfInsights.Enabling.html

Would you like to implement a fix?

Yes

@tedsmitt tedsmitt added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Feb 15, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/rds Issues and PRs that pertain to the rds service. label Feb 15, 2023
tedsmitt pushed a commit to tedsmitt/terraform-provider-aws that referenced this issue Feb 15, 2023
tedsmitt pushed a commit to tedsmitt/terraform-provider-aws that referenced this issue Feb 15, 2023
tedsmitt pushed a commit to tedsmitt/terraform-provider-aws that referenced this issue Feb 15, 2023
@tedsmitt tedsmitt changed the title [Enhancement]: aws_rds_cluster Multi-AZ Cluster performance insights [Enhancement]: aws_rds_cluster Multi-AZ Cluster performance insights Feb 15, 2023
tedsmitt pushed a commit to tedsmitt/terraform-provider-aws that referenced this issue Feb 15, 2023
tedsmitt pushed a commit to tedsmitt/terraform-provider-aws that referenced this issue Feb 15, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Mar 29, 2023
@nApucco
Copy link

nApucco commented Oct 10, 2023

What is the holdup with this feature? (It seems the PR has some conflicts and needs a rebase/fix.)

Without this feature, Performance Insights for RDS Multi-AZ Clusters need to be manually enabled.

@Syndorik
Copy link

We're a year later, any news on this? It seems that we're forced to apply the changes manually for the moment

Copy link

github-actions bot commented Aug 1, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.61.0 milestone Aug 1, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants