Add Performance Insights options to aws_rds_cluster resource

[tedsmitt]

Description

This PR adds the following options to the aws_rds_cluster resource

performance_insights_enabled
performance_insights_kms_key_id
performance_insights_retention_period

This option is only valid for Multi-AZ RDS Clusters, and isn't applicable for Aurora.

Relations

Closes #29414

References

docs.aws.amazon.com/AmazonRDS/latest/UserGuide/create-multi-az-db-cluster.html#create-multi-az-db-cluster-settings
docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_PerfInsights.Enabling.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccRDSCluster_performanceInsights* PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSCluster_performanceInsights*'  -timeout 180m
=== RUN   TestAccRDSCluster_performanceInsightsEnabled
=== PAUSE TestAccRDSCluster_performanceInsightsEnabled
=== RUN   TestAccRDSCluster_performanceInsightsKMSKeyID
=== PAUSE TestAccRDSCluster_performanceInsightsKMSKeyID
=== RUN   TestAccRDSCluster_performanceInsightsRetentionPeriod
=== PAUSE TestAccRDSCluster_performanceInsightsRetentionPeriod
=== CONT  TestAccRDSCluster_performanceInsightsEnabled
=== CONT  TestAccRDSCluster_performanceInsightsRetentionPeriod
=== CONT  TestAccRDSCluster_performanceInsightsKMSKeyID
--- PASS: TestAccRDSCluster_performanceInsightsRetentionPeriod (1945.58s)
--- PASS: TestAccRDSCluster_performanceInsightsKMSKeyID (1966.16s)
--- PASS: TestAccRDSCluster_performanceInsightsEnabled (2479.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        2481.203s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSCluster_performanceInsights\|TestAccRDSCluster_basic' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSCluster_performanceInsights\|TestAccRDSCluster_basic -timeout 360m
=== RUN   TestAccRDSCluster_basic
=== PAUSE TestAccRDSCluster_basic
=== RUN   TestAccRDSCluster_performanceInsightsEnabled
=== PAUSE TestAccRDSCluster_performanceInsightsEnabled
=== RUN   TestAccRDSCluster_performanceInsightsKMSKeyID
=== PAUSE TestAccRDSCluster_performanceInsightsKMSKeyID
=== RUN   TestAccRDSCluster_performanceInsightsRetentionPeriod
=== PAUSE TestAccRDSCluster_performanceInsightsRetentionPeriod
=== CONT  TestAccRDSCluster_basic
=== CONT  TestAccRDSCluster_performanceInsightsKMSKeyID
=== CONT  TestAccRDSCluster_performanceInsightsEnabled
--- PASS: TestAccRDSCluster_basic (155.57s)
=== CONT  TestAccRDSCluster_performanceInsightsRetentionPeriod
--- PASS: TestAccRDSCluster_performanceInsightsKMSKeyID (1685.78s)
--- PASS: TestAccRDSCluster_performanceInsightsRetentionPeriod (1836.05s)
--- PASS: TestAccRDSCluster_performanceInsightsEnabled (2139.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2144.389s

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRDSInstanceAutomatedBackupsReplication_\|TestAccRDSEventCategoriesDataSource_' PKG=rds ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSInstanceAutomatedBackupsReplication_\|TestAccRDSEventCategoriesDataSource_ -timeout 720m
=== RUN   TestAccRDSEventCategoriesDataSource_basic
=== PAUSE TestAccRDSEventCategoriesDataSource_basic
=== RUN   TestAccRDSEventCategoriesDataSource_sourceType
=== PAUSE TestAccRDSEventCategoriesDataSource_sourceType
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_basic
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_basic
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
=== RUN   TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== PAUSE TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
=== CONT  TestAccRDSEventCategoriesDataSource_basic
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_disappears
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_basic
--- PASS: TestAccRDSEventCategoriesDataSource_basic (7.13s)
=== CONT  TestAccRDSEventCategoriesDataSource_sourceType
--- PASS: TestAccRDSEventCategoriesDataSource_sourceType (6.63s)
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_disappears (1151.89s)
=== CONT  TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_kmsEncrypted (1163.13s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_basic (1194.55s)
--- PASS: TestAccRDSInstanceAutomatedBackupsReplication_retentionPeriod (1205.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	2362.742s

[ewbankkit]

@tedsmitt Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.