Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add support for QuickSight dataset refresh properties #30744

Closed
g-dx opened this issue Apr 14, 2023 · 4 comments · Fixed by #30778
Closed

[Enhancement]: Add support for QuickSight dataset refresh properties #30744

g-dx opened this issue Apr 14, 2023 · 4 comments · Fixed by #30778
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/quicksight Issues and PRs that pertain to the quicksight service.
Milestone

Comments

@g-dx
Copy link
Contributor

g-dx commented Apr 14, 2023

Description

Now that the aws_quicksight_ingestion resource has landed it should be possible to use the PutDataSetRefreshProperties API to fully configure incremental refresh via Terraform.

Affected Resource(s) and/or Data Source(s)

aws_quicksight_data_set

Potential Terraform Configuration

resource "aws_quicksight_data_set" "test" {

  data_set_id    = "test"

  // ... snip ...

  refresh_properties {
    refresh_configuration {
      incremental_refresh {
        lookback_window {
          column_name = "col"
          size        = 12
          size_unit   = "HOUR" // HOUR | DAY | WEEK
        }
      }
    }
  }
}

Alternatively, this could be implemented as a new resource:

resource "aws_quicksight_data_set_refresh_properties" "test" {
  data_set_id = "id"
  
  refresh_configuration {
    incremental_refresh {
      lookback_window {
        column_name = "col"
        size        = 12
        size_unit   = "HOUR" // HOUR | DAY | WEEK
      }
    }
  }
}

Not sure what direction would be most appropriate.

References

Relates to #10990

Would you like to implement a fix?

Yes

@g-dx g-dx added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Apr 14, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/quicksight Issues and PRs that pertain to the quicksight service. label Apr 14, 2023
@g-dx
Copy link
Contributor Author

g-dx commented Apr 17, 2023

After experimenting with the APIs it seems that the most developer friendly experience is to make this an addition to the aws_quicksight_data_set rather than a new resource. This is because refresh properties are only supported for data sets with an import_mode of SPICE.

This can be validated if the properties are specified as part of the existing resource rather than a new one.

g-dx added a commit to g-dx/terraform-provider-aws that referenced this issue Apr 17, 2023
g-dx added a commit to g-dx/terraform-provider-aws that referenced this issue Apr 17, 2023
g-dx added a commit to g-dx/terraform-provider-aws that referenced this issue Apr 18, 2023
g-dx added a commit to g-dx/terraform-provider-aws that referenced this issue Apr 18, 2023
g-dx added a commit to g-dx/terraform-provider-aws that referenced this issue Apr 18, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Apr 19, 2023
g-dx added a commit to g-dx/terraform-provider-aws that referenced this issue Apr 27, 2023
g-dx added a commit to g-dx/terraform-provider-aws that referenced this issue May 2, 2023
g-dx added a commit to g-dx/terraform-provider-aws that referenced this issue May 11, 2023
jar-b added a commit that referenced this issue May 11, 2023
…es (#30778)

* aws_quicksight_data_set: Add support for configuring refresh properties

Closes #30744

* r/aws_quicksight_data_set(test): add refresh settings test setup notes

* docs: QUICKSIGHT_ATHENA_TESTING_ENABLED acctest var

---------

Co-authored-by: Jared Baker <jared.baker@hashicorp.com>
@github-actions github-actions bot added this to the v4.67.0 milestone May 11, 2023
@github-actions
Copy link

This functionality has been released in v4.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

danielw-aws pushed a commit to danielw-aws/terraform-provider-aws that referenced this issue May 31, 2023
…es (hashicorp#30778)

* aws_quicksight_data_set: Add support for configuring refresh properties

Closes hashicorp#30744

* r/aws_quicksight_data_set(test): add refresh settings test setup notes

* docs: QUICKSIGHT_ATHENA_TESTING_ENABLED acctest var

---------

Co-authored-by: Jared Baker <jared.baker@hashicorp.com>
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants