Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]: aws_db_instance does not document the new identifier parameter #31854

Closed
jwoytek opened this issue Jun 8, 2023 · 5 comments
Closed

[Docs]: aws_db_instance does not document the new identifier parameter #31854

jwoytek opened this issue Jun 8, 2023 · 5 comments

Comments

@jwoytek
Copy link

jwoytek commented Jun 8, 2023

Documentation Link

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#attributes-reference

Description

PR #31232 changed the ID configuration for RDS resources. There is a new (and currently undocumented) parameter named identifier which returns the instance identifier. This was formerly returned by id, which now returns the same thing as db_resource_identifier.

References

PR #31232

Would you like to implement a fix?

None
@jwoytek jwoytek added documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@jwoytek jwoytek mentioned this issue Jun 8, 2023
Closed
1 task
@justinretzolk
Copy link
Member

Hey @jwoytek 👋 Thank you for taking the time to raise this! I took a look, and it looks like the identifier argument is indeed documented; it's in the arguments section rather than attributes, since it can optionally be set in the Terraform configuration. This used to be the same value as what was set for id, but that's what changed with version 5.0.0 -- the id attribute is now the same value as the resource_id attribute.

@justinretzolk justinretzolk added waiting-response Maintainers are waiting on response from community or contributor. and removed documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. labels Jun 8, 2023
@jwoytek
Copy link
Author

jwoytek commented Jun 9, 2023

I'm sorry I missed that--I was looking in the attributes section while looking at a bug I found in terraform-aws-modules/terraform-aws-rds. Thank you for looking into this!

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Jun 9, 2023
@justinretzolk
Copy link
Member

No worries, it happens @jwoytek! 🙂 I'll go ahead and close this one out. Have a great weekend!

jwoytek referenced this issue in jwoytek/terraform-aws-rds Jun 21, 2023
@jwoytek
update to follow change in aws_db_instance id
3ca00c6 
aws_db_instance was updated by hashicorp/terraform-provider-aws#31232
such that the `id` attribute now tracks the resource ID, and the
identifier is now returned in a new attribute named `identifier`.

The resource ID is already available in `instance_resource_id`. This
fix allows existing users to continue using this module with no
changes and preserves the original function of the `id` attribute
in this module.

Fixes terraform-aws-modules#495.
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwoytek @justinretzolk