Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds/instance: NEW ID configuration #31232

Merged
merged 19 commits into from
May 13, 2023
Merged

rds/instance: NEW ID configuration #31232

merged 19 commits into from
May 13, 2023

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 5, 2023 •
edited by jar-b
Loading

Description

Relations

Closes #16782
Closes #507
Closes #31169

References

Output from Acceptance Testing

(Failures unrelated to these changes.)

% make t T=TestAccRDSInstance_ K=rds P=5 ACCTEST_TIMEOUT=780m
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 5 -run='TestAccRDSInstance_'  -timeout 780m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_manage_password
=== PAUSE TestAccRDSInstance_manage_password
=== RUN   TestAccRDSInstance_identifierPrefix
=== PAUSE TestAccRDSInstance_identifierPrefix
=== RUN   TestAccRDSInstance_identifierGenerated
=== PAUSE TestAccRDSInstance_identifierGenerated
=== RUN   TestAccRDSInstance_disappears
=== PAUSE TestAccRDSInstance_disappears
=== RUN   TestAccRDSInstance_tags
=== PAUSE TestAccRDSInstance_tags
=== RUN   TestAccRDSInstance_onlyMajorVersion
=== PAUSE TestAccRDSInstance_onlyMajorVersion
=== RUN   TestAccRDSInstance_kmsKey
=== PAUSE TestAccRDSInstance_kmsKey
=== RUN   TestAccRDSInstance_customIAMInstanceProfile
=== PAUSE TestAccRDSInstance_customIAMInstanceProfile
=== RUN   TestAccRDSInstance_subnetGroup
=== PAUSE TestAccRDSInstance_subnetGroup
=== RUN   TestAccRDSInstance_networkType
=== PAUSE TestAccRDSInstance_networkType
=== RUN   TestAccRDSInstance_optionGroup
=== PAUSE TestAccRDSInstance_optionGroup
=== RUN   TestAccRDSInstance_iamAuth
=== PAUSE TestAccRDSInstance_iamAuth
=== RUN   TestAccRDSInstance_allowMajorVersionUpgrade
=== PAUSE TestAccRDSInstance_allowMajorVersionUpgrade
=== RUN   TestAccRDSInstance_dbSubnetGroupName
=== PAUSE TestAccRDSInstance_dbSubnetGroupName
=== RUN   TestAccRDSInstance_DBSubnetGroupName_ramShared
=== PAUSE TestAccRDSInstance_DBSubnetGroupName_ramShared
=== RUN   TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_deletionProtection
=== PAUSE TestAccRDSInstance_deletionProtection
=== RUN   TestAccRDSInstance_finalSnapshotIdentifier
=== PAUSE TestAccRDSInstance_finalSnapshotIdentifier
=== RUN   TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
=== PAUSE TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
=== RUN   TestAccRDSInstance_isAlreadyBeingDeleted
=== PAUSE TestAccRDSInstance_isAlreadyBeingDeleted
=== RUN   TestAccRDSInstance_maxAllocatedStorage
=== PAUSE TestAccRDSInstance_maxAllocatedStorage
=== RUN   TestAccRDSInstance_password
=== PAUSE TestAccRDSInstance_password
=== RUN   TestAccRDSInstance_ManagedMasterPassword_managed
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managed
=== RUN   TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
=== RUN   TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== PAUSE TestAccRDSInstance_ManagedMasterPassword_convertToManaged
=== RUN   TestAccRDSInstance_ReplicateSourceDB_basic
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_basic
=== RUN   TestAccRDSInstance_ReplicateSourceDB_namePrefix
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_namePrefix
=== RUN   TestAccRDSInstance_ReplicateSourceDB_nameGenerated
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_nameGenerated
=== RUN   TestAccRDSInstance_ReplicateSourceDB_addLater
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_addLater
=== RUN   TestAccRDSInstance_ReplicateSourceDB_allocatedStorage
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_allocatedStorage
=== RUN   TestAccRDSInstance_ReplicateSourceDB_iops
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_iops
=== RUN   TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops
=== RUN   TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade
=== RUN   TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade
=== RUN   TestAccRDSInstance_ReplicateSourceDB_availabilityZone
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_availabilityZone
=== RUN   TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod
=== RUN   TestAccRDSInstance_ReplicateSourceDB_backupWindow
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_backupWindow
=== RUN   TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName
=== RUN   TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_ramShared
=== PAUSE TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_ramShared
=== RUN   TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_ReplicateSourceDB_deletionProtection
    acctest.go:78: CreateDBInstanceReadReplica API currently ignores DeletionProtection=true with SourceDBInstanceIdentifier set
--- SKIP: TestAccRDSInstance_ReplicateSourceDB_deletionProtection (0.00s)
=== RUN   TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled
=== RUN   TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow
=== RUN   TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage
=== RUN   TestAccRDSInstance_ReplicateSourceDB_monitoring
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_monitoring
=== RUN   TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists
=== RUN   TestAccRDSInstance_ReplicateSourceDB_multiAZ
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_multiAZ
=== RUN   TestAccRDSInstance_ReplicateSourceDB_networkType
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_networkType
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica
=== RUN   TestAccRDSInstance_ReplicateSourceDB_port
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_port
=== RUN   TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier
=== RUN   TestAccRDSInstance_ReplicateSourceDB_replicaMode
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_replicaMode
=== RUN   TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep
=== RUN   TestAccRDSInstance_S3Import_basic
    acctest.go:78: RestoreDBInstanceFromS3 cannot restore from MySQL version 5.6
--- SKIP: TestAccRDSInstance_S3Import_basic (0.00s)
=== RUN   TestAccRDSInstance_SnapshotIdentifier_basic
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_basic
=== RUN   TestAccRDSInstance_SnapshotIdentifier_namePrefix
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_namePrefix
=== RUN   TestAccRDSInstance_SnapshotIdentifier_nameGenerated
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_nameGenerated
=== RUN   TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
=== RUN   TestAccRDSInstance_SnapshotIdentifier_allocatedStorage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_allocatedStorage
=== RUN   TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_io1Storage
=== RUN   TestAccRDSInstance_SnapshotIdentifier_allowMajorVersionUpgrade
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_allowMajorVersionUpgrade
=== RUN   TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade
=== RUN   TestAccRDSInstance_SnapshotIdentifier_availabilityZone
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_availabilityZone
=== RUN   TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride
=== RUN   TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset
=== RUN   TestAccRDSInstance_SnapshotIdentifier_backupWindow
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_backupWindow
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
=== RUN   TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
=== RUN   TestAccRDSInstance_SnapshotIdentifier_deletionProtection
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_deletionProtection
=== RUN   TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled
=== RUN   TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow
=== RUN   TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage
=== RUN   TestAccRDSInstance_SnapshotIdentifier_monitoring
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_monitoring
=== RUN   TestAccRDSInstance_SnapshotIdentifier_multiAZ
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_multiAZ
=== RUN   TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer
=== RUN   TestAccRDSInstance_SnapshotIdentifier_parameterGroupName
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_parameterGroupName
=== RUN   TestAccRDSInstance_SnapshotIdentifier_port
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_port
=== RUN   TestAccRDSInstance_SnapshotIdentifier_tags
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_tags
=== RUN   TestAccRDSInstance_SnapshotIdentifier_tagsRemove
    acctest.go:78: To be fixed: https://github.com/hashicorp/terraform-provider-aws/issues/26808
--- SKIP: TestAccRDSInstance_SnapshotIdentifier_tagsRemove (0.00s)
=== RUN   TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs
=== RUN   TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags
=== RUN   TestAccRDSInstance_monitoringInterval
=== PAUSE TestAccRDSInstance_monitoringInterval
=== RUN   TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled
=== PAUSE TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled
=== RUN   TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved
=== PAUSE TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved
=== RUN   TestAccRDSInstance_MonitoringRoleARN_removedToEnabled
=== PAUSE TestAccRDSInstance_MonitoringRoleARN_removedToEnabled
=== RUN   TestAccRDSInstance_separateIopsUpdate
=== PAUSE TestAccRDSInstance_separateIopsUpdate
=== RUN   TestAccRDSInstance_portUpdate
=== PAUSE TestAccRDSInstance_portUpdate
=== RUN   TestAccRDSInstance_MSSQL_tz
=== PAUSE TestAccRDSInstance_MSSQL_tz
=== RUN   TestAccRDSInstance_MSSQL_domain
=== PAUSE TestAccRDSInstance_MSSQL_domain
=== RUN   TestAccRDSInstance_MSSQL_domainSnapshotRestore
=== PAUSE TestAccRDSInstance_MSSQL_domainSnapshotRestore
=== RUN   TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion
=== PAUSE TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion
=== RUN   TestAccRDSInstance_minorVersion
=== PAUSE TestAccRDSInstance_minorVersion
=== RUN   TestAccRDSInstance_cloudWatchLogsExport
=== PAUSE TestAccRDSInstance_cloudWatchLogsExport
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle
=== RUN   TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql
=== PAUSE TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql
=== RUN   TestAccRDSInstance_noDeleteAutomatedBackups
=== PAUSE TestAccRDSInstance_noDeleteAutomatedBackups
=== RUN   TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled
=== PAUSE TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled
=== RUN   TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled
=== PAUSE TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled
=== RUN   TestAccRDSInstance_performanceInsightsKMSKeyID
=== PAUSE TestAccRDSInstance_performanceInsightsKMSKeyID
=== RUN   TestAccRDSInstance_performanceInsightsRetentionPeriod
=== PAUSE TestAccRDSInstance_performanceInsightsRetentionPeriod
=== RUN   TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled
=== PAUSE TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled
=== RUN   TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled
=== PAUSE TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled
=== RUN   TestAccRDSInstance_caCertificateIdentifier
=== PAUSE TestAccRDSInstance_caCertificateIdentifier
=== RUN   TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
=== RUN   TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
=== RUN   TestAccRDSInstance_RestoreToPointInTime_monitoring
=== PAUSE TestAccRDSInstance_RestoreToPointInTime_monitoring
=== RUN   TestAccRDSInstance_NationalCharacterSet_oracle
=== PAUSE TestAccRDSInstance_NationalCharacterSet_oracle
=== RUN   TestAccRDSInstance_NoNationalCharacterSet_oracle
=== PAUSE TestAccRDSInstance_NoNationalCharacterSet_oracle
=== RUN   TestAccRDSInstance_coIPEnabled
=== PAUSE TestAccRDSInstance_coIPEnabled
=== RUN   TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== PAUSE TestAccRDSInstance_CoIPEnabled_disabledToEnabled
=== RUN   TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== PAUSE TestAccRDSInstance_CoIPEnabled_enabledToDisabled
=== RUN   TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== PAUSE TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
=== RUN   TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== PAUSE TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
=== RUN   TestAccRDSInstance_license
=== PAUSE TestAccRDSInstance_license
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
=== RUN   TestAccRDSInstance_BlueGreenDeployment_tags
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_tags
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
=== RUN   TestAccRDSInstance_BlueGreenDeployment_deletionProtection
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_deletionProtection
=== RUN   TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== PAUSE TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
=== RUN   TestAccRDSInstance_gp3MySQL
=== PAUSE TestAccRDSInstance_gp3MySQL
=== RUN   TestAccRDSInstance_gp3Postgres
=== PAUSE TestAccRDSInstance_gp3Postgres
=== RUN   TestAccRDSInstance_gp3SQLServer
=== PAUSE TestAccRDSInstance_gp3SQLServer
=== RUN   TestAccRDSInstance_storageThroughput
=== PAUSE TestAccRDSInstance_storageThroughput
=== RUN   TestAccRDSInstance_storageTypePostgres
=== PAUSE TestAccRDSInstance_storageTypePostgres
=== RUN   TestAccRDSInstance_newIdentifier
=== PAUSE TestAccRDSInstance_newIdentifier
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared
=== CONT  TestAccRDSInstance_ReplicateSourceDB_networkType
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName
--- PASS: TestAccRDSInstance_basic (371.82s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_backupWindow
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupName (1065.38s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameRAMShared (1162.27s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride
--- PASS: TestAccRDSInstance_ReplicateSourceDB_networkType (1619.36s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_availabilityZone
--- PASS: TestAccRDSInstance_MySQL_snapshotRestoreWithEngineVersion (1686.82s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupWindow (1425.51s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_allowMajorVersionUpgrade
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodUnset (1530.22s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_io1Storage
--- PASS: TestAccRDSInstance_SnapshotIdentifier_availabilityZone (1191.85s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_allocatedStorage
--- PASS: TestAccRDSInstance_SnapshotIdentifier_backupRetentionPeriodOverride (1694.64s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved
--- PASS: TestAccRDSInstance_SnapshotIdentifier_autoMinorVersionUpgrade (1215.14s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_nameGenerated
--- PASS: TestAccRDSInstance_SnapshotIdentifier_allowMajorVersionUpgrade (1681.76s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_namePrefix
--- PASS: TestAccRDSInstance_SnapshotIdentifier_nameGenerated (937.29s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_basic
--- PASS: TestAccRDSInstance_SnapshotIdentifier_namePrefix (1071.35s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep
--- PASS: TestAccRDSInstance_SnapshotIdentifier_io1Storage (1488.58s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_replicaMode
--- PASS: TestAccRDSInstance_SnapshotIdentifier_AssociationRemoved (1278.65s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier
    instance_test.go:2092: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: multiple RDS Certificates match the criteria; try changing search query
        
          with data.aws_rds_certificate.latest,
          on terraform_plugin_test.tf line 15, in data "aws_rds_certificate" "latest":
          15: data "aws_rds_certificate" "latest" {
        
--- FAIL: TestAccRDSInstance_ReplicateSourceDB_caCertificateIdentifier (6.98s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_SnapshotIdentifier_allocatedStorage (1891.62s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth
--- PASS: TestAccRDSInstance_SnapshotIdentifier_basic (1247.07s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth
--- PASS: TestAccRDSInstance_ReplicateSourceDB_vpcSecurityGroupIDs (1509.04s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_port
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameDifferentSetOnBoth (1619.87s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica
--- PASS: TestAccRDSInstance_ReplicateSourceDB_replicaMode (2563.71s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSameSetOnBoth (1627.13s)
=== CONT  TestAccRDSInstance_MSSQL_domainSnapshotRestore
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupTwoStep (2812.37s)
=== CONT  TestAccRDSInstance_MSSQL_domain
--- PASS: TestAccRDSInstance_ReplicateSourceDB_port (1372.31s)
=== CONT  TestAccRDSInstance_MSSQL_tz
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameSetOnReplica (1714.85s)
=== CONT  TestAccRDSInstance_portUpdate
--- PASS: TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDs (1107.50s)
=== CONT  TestAccRDSInstance_separateIopsUpdate
--- PASS: TestAccRDSInstance_portUpdate (710.70s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_removedToEnabled
--- PASS: TestAccRDSInstance_separateIopsUpdate (671.61s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved
--- PASS: TestAccRDSInstance_MSSQL_tz (1650.61s)
=== CONT  TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled
--- PASS: TestAccRDSInstance_MonitoringRoleARN_removedToEnabled (617.71s)
=== CONT  TestAccRDSInstance_monitoringInterval
--- PASS: TestAccRDSInstance_MonitoringRoleARN_enabledToRemoved (822.08s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags
--- PASS: TestAccRDSInstance_MonitoringRoleARN_enabledToDisabled (855.51s)
=== CONT  TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey
--- PASS: TestAccRDSInstance_MSSQL_domainSnapshotRestore (3112.06s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_multiAZ
--- PASS: TestAccRDSInstance_ManagedMasterPassword_managedSpecificKMSKey (523.83s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists
--- PASS: TestAccRDSInstance_MSSQL_domain (3416.11s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_monitoring
--- PASS: TestAccRDSInstance_monitoringInterval (1384.79s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage
--- PASS: TestAccRDSInstance_SnapshotIdentifier_vpcSecurityGroupIDsTags (1113.84s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow
--- PASS: TestAccRDSInstance_ReplicateSourceDB_maxAllocatedStorage (1318.68s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled
--- PASS: TestAccRDSInstance_ReplicateSourceDB_monitoring_sourceAlreadyExists (1660.14s)
=== CONT  TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_ReplicateSourceDB_monitoring (1574.05s)
=== CONT  TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_ramShared
--- PASS: TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_ramShared (2072.48s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName
--- PASS: TestAccRDSInstance_ReplicateSourceDB_maintenanceWindow (1390.53s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_backupWindow
--- PASS: TestAccRDSInstance_ReplicateSourceDB_dbSubnetGroupName (1865.93s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod
--- PASS: TestAccRDSInstance_ReplicateSourceDB_multiAZ (2073.20s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_availabilityZone
--- PASS: TestAccRDSInstance_ReplicateSourceDB_iamDatabaseAuthenticationEnabled (1433.87s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade
--- PASS: TestAccRDSInstance_ReplicateSourceDB_backupWindow (1451.46s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue
--- PASS: TestAccRDSInstance_ReplicateSourceDB_availabilityZone (1640.43s)
=== CONT  TestAccRDSInstance_coIPEnabled
    acctest.go:1061: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_coIPEnabled (0.51s)
=== CONT  TestAccRDSInstance_newIdentifier
--- PASS: TestAccRDSInstance_ReplicateSourceDB_backupRetentionPeriod (1877.37s)
=== CONT  TestAccRDSInstance_storageTypePostgres
--- PASS: TestAccRDSInstance_ReplicateSourceDBDBSubnetGroupName_vpcSecurityGroupIDs (1994.46s)
=== CONT  TestAccRDSInstance_storageThroughput
--- PASS: TestAccRDSInstance_newIdentifier (662.72s)
=== CONT  TestAccRDSInstance_gp3SQLServer
--- PASS: TestAccRDSInstance_storageTypePostgres (732.22s)
=== CONT  TestAccRDSInstance_gp3Postgres
--- PASS: TestAccRDSInstance_storageThroughput (778.30s)
=== CONT  TestAccRDSInstance_gp3MySQL
--- PASS: TestAccRDSInstance_ReplicateSourceDB_autoMinorVersionUpgrade (1540.94s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection
--- PASS: TestAccRDSInstance_ReplicateSourceDB_parameterGroupNameReplicaCopiesValue (1668.97s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_deletionProtection
--- PASS: TestAccRDSInstance_gp3Postgres (755.75s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups
--- PASS: TestAccRDSInstance_gp3SQLServer (1024.08s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica
--- PASS: TestAccRDSInstance_gp3MySQL (809.37s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass
--- PASS: TestAccRDSInstance_BlueGreenDeployment_deletionProtection (2055.43s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_tags
--- PASS: TestAccRDSInstance_BlueGreenDeployment_tags (697.16s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateInstanceClass (2394.89s)
=== CONT  TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndEnableBackups (2597.85s)
=== CONT  TestAccRDSInstance_license
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateAndPromoteReplica (3442.94s)
=== CONT  TestAccRDSInstance_CoIPEnabled_snapshotIdentifier
    acctest.go:1061: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_snapshotIdentifier (0.50s)
=== CONT  TestAccRDSInstance_CoIPEnabled_restoreToPointInTime
    acctest.go:1061: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_restoreToPointInTime (0.18s)
=== CONT  TestAccRDSInstance_CoIPEnabled_enabledToDisabled
    acctest.go:1061: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_enabledToDisabled (0.20s)
=== CONT  TestAccRDSInstance_CoIPEnabled_disabledToEnabled
    acctest.go:1061: skipping since no Outposts found
--- SKIP: TestAccRDSInstance_CoIPEnabled_disabledToEnabled (0.18s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_addLater
--- PASS: TestAccRDSInstance_license (977.50s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateParameterGroup (2228.41s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateEngineVersion (2250.31s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_iops
--- PASS: TestAccRDSInstance_BlueGreenDeployment_updateWithDeletionProtection (4159.42s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_allocatedStorage
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allowMajorVersionUpgrade (1359.58s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_namePrefix
--- PASS: TestAccRDSInstance_ReplicateSourceDB_addLater (1468.47s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_nameGenerated
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allocatedStorage (1413.93s)
=== CONT  TestAccRDSInstance_iamAuth
--- PASS: TestAccRDSInstance_ReplicateSourceDB_allocatedStorageAndIops (1703.36s)
=== CONT  TestAccRDSInstance_ManagedMasterPassword_managed
--- PASS: TestAccRDSInstance_ReplicateSourceDB_nameGenerated (1566.68s)
=== CONT  TestAccRDSInstance_password
--- PASS: TestAccRDSInstance_ReplicateSourceDB_iops (1795.41s)
=== CONT  TestAccRDSInstance_maxAllocatedStorage
--- PASS: TestAccRDSInstance_ReplicateSourceDB_namePrefix (1692.10s)
=== CONT  TestAccRDSInstance_isAlreadyBeingDeleted
--- PASS: TestAccRDSInstance_iamAuth (482.42s)
=== CONT  TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot
--- PASS: TestAccRDSInstance_ManagedMasterPassword_managed (480.53s)
=== CONT  TestAccRDSInstance_finalSnapshotIdentifier
--- PASS: TestAccRDSInstance_isAlreadyBeingDeleted (488.84s)
=== CONT  TestAccRDSInstance_deletionProtection
--- PASS: TestAccRDSInstance_password (588.08s)
=== CONT  TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs
--- PASS: TestAccRDSInstance_maxAllocatedStorage (817.15s)
=== CONT  TestAccRDSInstance_DBSubnetGroupName_ramShared
--- PASS: TestAccRDSInstance_FinalSnapshotIdentifier_skipFinalSnapshot (671.82s)
=== CONT  TestAccRDSInstance_dbSubnetGroupName
--- PASS: TestAccRDSInstance_deletionProtection (479.81s)
=== CONT  TestAccRDSInstance_allowMajorVersionUpgrade
--- PASS: TestAccRDSInstance_DBSubnetGroupName_vpcSecurityGroupIDs (527.36s)
=== CONT  TestAccRDSInstance_onlyMajorVersion
--- PASS: TestAccRDSInstance_finalSnapshotIdentifier (947.37s)
=== CONT  TestAccRDSInstance_optionGroup
--- PASS: TestAccRDSInstance_DBSubnetGroupName_ramShared (543.58s)
=== CONT  TestAccRDSInstance_networkType
--- PASS: TestAccRDSInstance_dbSubnetGroupName (510.89s)
=== CONT  TestAccRDSInstance_subnetGroup
--- PASS: TestAccRDSInstance_allowMajorVersionUpgrade (550.77s)
=== CONT  TestAccRDSInstance_customIAMInstanceProfile
--- PASS: TestAccRDSInstance_onlyMajorVersion (508.93s)
=== CONT  TestAccRDSInstance_kmsKey
--- PASS: TestAccRDSInstance_optionGroup (493.29s)
=== CONT  TestAccRDSInstance_performanceInsightsKMSKeyID
--- PASS: TestAccRDSInstance_kmsKey (536.16s)
=== CONT  TestAccRDSInstance_NoNationalCharacterSet_oracle
--- PASS: TestAccRDSInstance_subnetGroup (924.62s)
=== CONT  TestAccRDSInstance_NationalCharacterSet_oracle
--- PASS: TestAccRDSInstance_networkType (1086.73s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_monitoring
--- PASS: TestAccRDSInstance_NoNationalCharacterSet_oracle (853.83s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceResourceID
--- PASS: TestAccRDSInstance_performanceInsightsKMSKeyID (1191.92s)
=== CONT  TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier
--- PASS: TestAccRDSInstance_NationalCharacterSet_oracle (965.48s)
=== CONT  TestAccRDSInstance_caCertificateIdentifier
    instance_test.go:4213: Step 1/1 error: Error running pre-apply refresh: exit status 1
        
        Error: multiple RDS Certificates match the criteria; try changing search query
        
          with data.aws_rds_certificate.latest,
          on terraform_plugin_test.tf line 15, in data "aws_rds_certificate" "latest":
          15: data "aws_rds_certificate" "latest" {
        
--- FAIL: TestAccRDSInstance_caCertificateIdentifier (6.74s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled
--- PASS: TestAccRDSInstance_RestoreToPointInTime_monitoring (1624.10s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceIdentifier (1352.85s)
=== CONT  TestAccRDSInstance_performanceInsightsRetentionPeriod
--- PASS: TestAccRDSInstance_RestoreToPointInTime_sourceResourceID (1421.22s)
=== CONT  TestAccRDSInstance_ReplicateSourceDB_basic
--- PASS: TestAccRDSInstance_customIAMInstanceProfile (2897.54s)
=== CONT  TestAccRDSInstance_manage_password
--- PASS: TestAccRDSInstance_SnapshotIdentifier_performanceInsightsEnabled (1412.78s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_monitoring
--- PASS: TestAccRDSInstance_manage_password (517.03s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_tags
--- PASS: TestAccRDSInstance_performanceInsightsRetentionPeriod (1126.92s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_port
--- PASS: TestAccRDSInstance_ReplicateSourceDB_performanceInsightsEnabled (1713.55s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_parameterGroupName
--- PASS: TestAccRDSInstance_ReplicateSourceDB_basic (1671.35s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer
--- PASS: TestAccRDSInstance_SnapshotIdentifier_tags (1162.16s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_multiAZ
--- PASS: TestAccRDSInstance_SnapshotIdentifier_monitoring (1631.65s)
=== CONT  TestAccRDSInstance_ManagedMasterPassword_convertToManaged
--- PASS: TestAccRDSInstance_SnapshotIdentifier_port (964.22s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled
--- PASS: TestAccRDSInstance_ManagedMasterPassword_convertToManaged (629.16s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage
--- PASS: TestAccRDSInstance_SnapshotIdentifier_parameterGroupName (1271.59s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow
--- PASS: TestAccRDSInstance_SnapshotIdentifier_iamDatabaseAuthenticationEnabled (1106.16s)
=== CONT  TestAccRDSInstance_tags
--- PASS: TestAccRDSInstance_SnapshotIdentifier_multiAZ (1882.81s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle
--- PASS: TestAccRDSInstance_tags (584.05s)
=== CONT  TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled
--- PASS: TestAccRDSInstance_SnapshotIdentifier_maintenanceWindow (1225.46s)
=== CONT  TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled
--- PASS: TestAccRDSInstance_SnapshotIdentifier_maxAllocatedStorage (1333.55s)
=== CONT  TestAccRDSInstance_noDeleteAutomatedBackups
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_oracle (961.15s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql
--- PASS: TestAccRDSInstance_PerformanceInsightsEnabled_disabledToEnabled (756.53s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs
--- PASS: TestAccRDSInstance_noDeleteAutomatedBackups (769.28s)
=== CONT  TestAccRDSInstance_SnapshotIdentifier_deletionProtection
--- PASS: TestAccRDSInstance_PerformanceInsightsEnabled_enabledToDisabled (932.92s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_postgresql (571.11s)
=== CONT  TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_mySQL (1053.45s)
=== CONT  TestAccRDSInstance_identifierPrefix
--- PASS: TestAccRDSInstance_SnapshotIdentifier_dbSubnetGroupNameVPCSecurityGroupIDs (1231.67s)
=== CONT  TestAccRDSInstance_cloudWatchLogsExport
--- PASS: TestAccRDSInstance_EnabledCloudWatchLogsExports_msSQL (797.84s)
=== CONT  TestAccRDSInstance_minorVersion
--- PASS: TestAccRDSInstance_SnapshotIdentifier_deletionProtection (1308.47s)
=== CONT  TestAccRDSInstance_identifierGenerated
--- PASS: TestAccRDSInstance_identifierPrefix (573.97s)
=== CONT  TestAccRDSInstance_disappears
--- PASS: TestAccRDSInstance_SnapshotIdentifier_multiAZSQLServer (4720.36s)
--- PASS: TestAccRDSInstance_minorVersion (491.35s)
--- PASS: TestAccRDSInstance_identifierGenerated (503.87s)
--- PASS: TestAccRDSInstance_cloudWatchLogsExport (612.58s)
--- PASS: TestAccRDSInstance_disappears (494.04s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/rds	32914.575s
% make t T=TestAccRDSInstanceRoleAssociation_ K=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSInstanceRoleAssociation_'  -timeout 180m
=== RUN   TestAccRDSInstanceRoleAssociation_basic
=== PAUSE TestAccRDSInstanceRoleAssociation_basic
=== RUN   TestAccRDSInstanceRoleAssociation_disappears
=== PAUSE TestAccRDSInstanceRoleAssociation_disappears
=== CONT  TestAccRDSInstanceRoleAssociation_basic
=== CONT  TestAccRDSInstanceRoleAssociation_disappears
--- PASS: TestAccRDSInstanceRoleAssociation_disappears (941.00s)
--- PASS: TestAccRDSInstanceRoleAssociation_basic (1006.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1008.628s
% make t T='TestAccRDSEventSubscription_|TestAccRDSProxyTarget_' K=rds 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSEventSubscription_|TestAccRDSProxyTarget_'  -timeout 180m
=== RUN   TestAccRDSEventSubscription_basic
=== PAUSE TestAccRDSEventSubscription_basic
=== RUN   TestAccRDSEventSubscription_disappears
=== PAUSE TestAccRDSEventSubscription_disappears
=== RUN   TestAccRDSEventSubscription_Name_generated
=== PAUSE TestAccRDSEventSubscription_Name_generated
=== RUN   TestAccRDSEventSubscription_namePrefix
=== PAUSE TestAccRDSEventSubscription_namePrefix
=== RUN   TestAccRDSEventSubscription_tags
=== PAUSE TestAccRDSEventSubscription_tags
=== RUN   TestAccRDSEventSubscription_categories
=== PAUSE TestAccRDSEventSubscription_categories
=== RUN   TestAccRDSEventSubscription_sourceIDs
=== PAUSE TestAccRDSEventSubscription_sourceIDs
=== RUN   TestAccRDSProxyTarget_instance
=== PAUSE TestAccRDSProxyTarget_instance
=== RUN   TestAccRDSProxyTarget_cluster
=== PAUSE TestAccRDSProxyTarget_cluster
=== RUN   TestAccRDSProxyTarget_disappears
=== PAUSE TestAccRDSProxyTarget_disappears
=== CONT  TestAccRDSEventSubscription_basic
=== CONT  TestAccRDSEventSubscription_categories
=== CONT  TestAccRDSEventSubscription_namePrefix
=== CONT  TestAccRDSEventSubscription_tags
=== CONT  TestAccRDSEventSubscription_Name_generated
=== CONT  TestAccRDSEventSubscription_disappears
=== CONT  TestAccRDSProxyTarget_disappears
=== CONT  TestAccRDSProxyTarget_cluster
=== CONT  TestAccRDSProxyTarget_instance
=== CONT  TestAccRDSEventSubscription_sourceIDs
--- PASS: TestAccRDSProxyTarget_instance (701.41s)
--- PASS: TestAccRDSProxyTarget_disappears (704.68s)
--- PASS: TestAccRDSEventSubscription_disappears (82.97s)
--- PASS: TestAccRDSEventSubscription_basic (89.38s)
--- PASS: TestAccRDSEventSubscription_Name_generated (89.44s)
--- PASS: TestAccRDSEventSubscription_namePrefix (89.60s)
--- PASS: TestAccRDSEventSubscription_sourceIDs (101.99s)
--- PASS: TestAccRDSEventSubscription_tags (117.02s)
--- PASS: TestAccRDSEventSubscription_categories (196.79s)
--- PASS: TestAccRDSProxyTarget_cluster (509.80s)

@github-actions
Copy link

github-actions bot commented May 5, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ssm Issues and PRs that pertain to the ssm service. and removed size/L Managed by automation to categorize the size of a PR. labels May 5, 2023
@YakDriver YakDriver added this to the v5.0.0 milestone May 8, 2023
@YakDriver YakDriver force-pushed the f-db-instance-identifier-not-forcenew branch from c36a71c to 665ad7a Compare May 10, 2023 17:01
@ewbankkit ewbankkit added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label May 11, 2023
@YakDriver YakDriver changed the base branch from prerelease/5.x to main May 12, 2023 17:29
@YakDriver YakDriver force-pushed the f-db-instance-identifier-not-forcenew branch from 017f77e to a7cb14b Compare May 12, 2023 19:10
@YakDriver YakDriver merged commit 2e9279e into main May 13, 2023
@YakDriver YakDriver deleted the f-db-instance-identifier-not-forcenew branch May 13, 2023 04:15
github-actions bot pushed a commit that referenced this pull request May 13, 2023
Update CHANGELOG.md for #31232
a13a04f
@jar-b jar-b mentioned this pull request May 24, 2023
Closed
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@justinretzolk justinretzolk mentioned this pull request Jun 8, 2023
Merged
This was referenced Jun 8, 2023
Closed
Closed
jwoytek added a commit to jwoytek/terraform-aws-rds that referenced this pull request Jun 20, 2023
@jwoytek
update to follow change in aws_db_instance id
3ca00c6 
aws_db_instance was updated by hashicorp/terraform-provider-aws#31232
such that the `id` attribute now tracks the resource ID, and the
identifier is now returned in a new attribute named `identifier`.

The resource ID is already available in `instance_resource_id`. This
fix allows existing users to continue using this module with no
changes and preserves the original function of the `id` attribute
in this module.

Fixes terraform-aws-modules#495.
@jwoytek jwoytek mentioned this pull request Jun 20, 2023
Closed
3 tasks
@bryantbiggs bryantbiggs mentioned this pull request Jun 25, 2023
Merged
3 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. service/rds Issues and PRs that pertain to the rds service. service/ssm Issues and PRs that pertain to the ssm service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

r/aws_db_instance: Remove name changing identifier in RDS (aws_db_instance) will destroy/create the db
2 participants
@YakDriver @ewbankkit