Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Replace random password generation with manage master password, min AWS provider version increased to 5.0, id output replaced with identifier #489

Merged
merged 4 commits into from
Jun 25, 2023
Merged

feat!: Replace random password generation with manage master password, min AWS provider version increased to 5.0, id output replaced with identifier #489

merged 4 commits into from
Jun 25, 2023

Conversation

decayofmind
Copy link
Contributor

@decayofmind decayofmind commented Apr 5, 2023 •
edited by bryantbiggs
Loading

Description

Motivation and Context

Support of this new feature allows users to offload master password lifecycle completely to AWS, including rotation and avoid storing credentials in state file.

Breaking Changes

  • Yes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@decayofmind decayofmind force-pushed the add-manage-master-user-password-support branch from 8349eeb to 25488a0 Compare April 5, 2023 12:49
gruckion
gruckion reviewed May 4, 2023
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@bryantbiggs
Copy link
Member

similar to what we did with the Aurora module, we'll want to remove the random password generation here terraform-aws-modules/terraform-aws-rds-aurora#335

This will be a breaking change but its the proper solution for keeping secrets secure, out of Terraform state, and allow them to more easily be rotated without Terraform interference

@asinghggt
Copy link

any update on this?

@yannickvr yannickvr mentioned this pull request May 25, 2023
Closed
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 12, 2023
@bryantbiggs bryantbiggs added wip and removed stale labels Jun 12, 2023
@decayofmind decayofmind force-pushed the add-manage-master-user-password-support branch from 25488a0 to c9a7462 Compare June 19, 2023 21:31
@decayofmind @gruckion
Update main.tf
d30999b 
Co-authored-by: Stephen Rayner <stephen.r.rayner@gmail.com>
@rlmartin
Copy link

Any updates on this?

@bryantbiggs bryantbiggs changed the title feat: Add support for manage_master_user_password feat!: Replace random password generation with manage master password, min AWS provider version increased to 5.0, id output replaced with identifier Jun 25, 2023
@bryantbiggs bryantbiggs merged commit c66cd73 into terraform-aws-modules:master Jun 25, 2023
antonbabenko pushed a commit that referenced this pull request Jun 25, 2023
@semantic-release-bot
chore(release): version 6.0.0 [skip ci]
ec9c2e3 
## [6.0.0](v5.9.0...v6.0.0) (2023-06-25)

### ⚠ BREAKING CHANGES

* Replace random password generation with manage master password, min AWS provider version increased to 5.0, `id` output replaced with `identifier` (#489)

### Features

* Replace random password generation with manage master password, min AWS provider version increased to 5.0, `id` output replaced with `identifier` ([#489](#489)) ([c66cd73](c66cd73))
@antonbabenko
Copy link
Member

This PR is included in version 6.0.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gruckion gruckion gruckion left review comments

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@decayofmind @bryantbiggs @asinghggt @rlmartin @antonbabenko @gruckion