r/aws_quicksight_dashboard: various bug fixes

[jackarmorgie]

Description

Fixing various bugs with the aws_quicksight_dashboard resource

Relations

Closes #33108
Closes #33632
Closes #33222
Closes #33753
Closes #33754
Closes #33755
Closes #33756
Closes #33759
Closes #33776
Closes #33777
Closes #33907

References

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDashboard'  -timeout 360m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]
=== RUN   TestAccQuickSightDashboard_basic
=== PAUSE TestAccQuickSightDashboard_basic
=== RUN   TestAccQuickSightDashboard_disappears
=== PAUSE TestAccQuickSightDashboard_disappears
=== RUN   TestAccQuickSightDashboard_sourceEntity
=== PAUSE TestAccQuickSightDashboard_sourceEntity
=== RUN   TestAccQuickSightDashboard_updateVersionNumber
=== PAUSE TestAccQuickSightDashboard_updateVersionNumber
=== RUN   TestAccQuickSightDashboard_dashboardSpecificConfig
=== PAUSE TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT  TestAccQuickSightDashboard_basic
=== CONT  TestAccQuickSightDashboard_updateVersionNumber
=== CONT  TestAccQuickSightDashboard_sourceEntity
=== CONT  TestAccQuickSightDashboard_dashboardSpecificConfig
=== CONT  TestAccQuickSightDashboard_disappears
--- PASS: TestAccQuickSightDashboard_disappears (61.75s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (64.63s)
--- PASS: TestAccQuickSightDashboard_basic (68.44s)
--- PASS: TestAccQuickSightDashboard_sourceEntity (73.66s)
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (133.83s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 133.907s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @jackarmorgie 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jackarmorgie]

I have realised that these changes also affect the aws_quicksight_template and aws_quicksight_analysis resources, so have included them in the changelog

[mukund-gohil-atos]

Hi all,
Can we get this branch merged. It seems to be resolving 2-3 bugs that I am currently getting while trying to deploy quicksight dashboard. What ETA can I expect for this merge ?

@jackarmorgie ,
Thank you for your contribution to identify and provide resolution to many bugs that i am currently facing. There is one more bug in visuals of Pie chart. There are options to select SMALL, MEDIUM, LARGE, WHOLE but the terraform provider is not accepting WHOLE keyword. Can you also check if that issue is also covered in here ?

[jar-b]

LGTM 🎉

% make testacc PKG=quicksight TESTS="TestAccQuickSightAnalysis_|TestAccQuickSightDashboard_|TestAccQuickSightTemplate_" ACCTEST_PARALLELISM=8
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 8 -run='TestAccQuickSightAnalysis_|TestAccQuickSightDashboard_|TestAccQuickSightTemplate_'  -timeout 360m
?       github.com/hashicorp/terraform-provider-aws/internal/service/quicksight/schema  [no test files]

--- PASS: TestAccQuickSightAnalysis_forceDelete (476.33s)
=== CONT  TestAccQuickSightDashboard_basic
--- PASS: TestAccQuickSightAnalysis_basic (490.05s)
=== CONT  TestAccQuickSightTemplate_sourceEntity
--- PASS: TestAccQuickSightDashboard_disappears (494.01s)
=== CONT  TestAccQuickSightAnalysis_Definition_calculatedFields
--- PASS: TestAccQuickSightDashboard_sourceEntity (531.50s)
=== CONT  TestAccQuickSightTemplate_disappears
--- PASS: TestAccQuickSightTemplate_table (763.35s)
=== CONT  TestAccQuickSightTemplate_barChart
--- PASS: TestAccQuickSightTemplate_update (811.67s)
=== CONT  TestAccQuickSightAnalysis_update
--- PASS: TestAccQuickSightDashboard_updateVersionNumber (918.91s)
=== CONT  TestAccQuickSightAnalysis_parametersConfig
--- PASS: TestAccQuickSightTemplate_sourceEntity (481.71s)
=== CONT  TestAccQuickSightAnalysis_sourceEntity
--- PASS: TestAccQuickSightDashboard_basic (498.27s)
=== CONT  TestAccQuickSightTemplate_basic
--- PASS: TestAccQuickSightAnalysis_Definition_calculatedFields (497.20s)
=== CONT  TestAccQuickSightAnalysis_disappears
--- PASS: TestAccQuickSightTemplate_disappears (464.11s)
=== CONT  TestAccQuickSightDashboard_dashboardSpecificConfig
--- PASS: TestAccQuickSightTemplate_tags (1095.95s)
--- PASS: TestAccQuickSightTemplate_barChart (455.66s)
--- PASS: TestAccQuickSightAnalysis_parametersConfig (450.46s)
--- PASS: TestAccQuickSightTemplate_basic (403.11s)
--- PASS: TestAccQuickSightDashboard_dashboardSpecificConfig (417.24s)
--- PASS: TestAccQuickSightAnalysis_disappears (423.31s)
--- PASS: TestAccQuickSightAnalysis_sourceEntity (454.71s)
--- PASS: TestAccQuickSightAnalysis_update (727.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 1542.047s

[jar-b]

Thanks for all the fixes, @jackarmorgie! Much appreciated! 👍

[github-actions]

This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.