[Enhancement]: Support EFS destination filesystem ID for EFS replication configuration

[yaronya]

Description

Brand new from 11/27: https://aws.amazon.com/blogs/aws/replication-failback-and-increased-iops-are-new-for-amazon-efs/

AWS now supports EFS replication to an existing EFS, and won't force you to replicate your source EFS into a new EFS. This would save me a bunch 😅 💸

Affected Resource(s) and/or Data Source(s)

aws_efs_replication_configuration

Potential Terraform Configuration

The `destination` block of `aws_efs_replication_configuration` should support a new `file_system_id` attribute alongside all the attributes it already supports and are inherited from the API structure

References

API reference: https://docs.aws.amazon.com/efs/latest/ug/API_CreateReplicationConfiguration.html

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[yaronya]

I'm interested in working on this issue, and already have a forked branch ongoing - just give me the signal 😄

[yaronya]

@justinretzolk while testing my PR I noticed that the aws_efs_file_system resource is missing the ability to control the new replication overwrite protection setting. This setting must be disabled first in order to set the file system as replication destination.

Is it ok that I'll add it to the aws_efs_file_system resource and data resource as well as a part of this issue? (In a different PR, of course)

[github-actions]

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.