Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protection attribute to aws_efs_file_system resource & data resource #35029

Merged
merged 12 commits into from
Jan 3, 2024

Conversation

yaronya
Copy link
Contributor

@yaronya yaronya commented Dec 21, 2023

Description

AWS had recently added a new capability to EFS called "replication overwrite protection".
In the API, there' a new FileSytemProtection attribute.
This PR is required in order to complete #34955

Relations

Relates #34863

References

Output from Acceptance Testing

╰─❯ make testacc TESTS=TestAccEFSFileSystem_protection PKG=efs

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSFileSystem_protection'  -timeout 360m
=== RUN   TestAccEFSFileSystem_protection
=== PAUSE TestAccEFSFileSystem_protection
=== CONT  TestAccEFSFileSystem_protection
--- PASS: TestAccEFSFileSystem_protection (26.38s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        28.659s

╰─❯ make testacc TESTS=TestAccEFSFileSystem_basic PKG=efs     

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSFileSystem_basic'  -timeout 360m
=== RUN   TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== CONT  TestAccEFSFileSystem_basic
--- PASS: TestAccEFSFileSystem_basic (25.77s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        28.028s

╰─❯ make testacc TESTS=TestAccEFSFileSystemDataSource_id PKG=efs

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSFileSystemDataSource_id'  -timeout 360m
=== RUN   TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== CONT  TestAccEFSFileSystemDataSource_id
--- PASS: TestAccEFSFileSystemDataSource_id (24.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        26.235s

╰─❯ make testacc TESTS=TestAccEFSFileSystemDataSource_name PKG=efs

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSFileSystemDataSource_name'  -timeout 360m
=== RUN   TestAccEFSFileSystemDataSource_name
=== PAUSE TestAccEFSFileSystemDataSource_name
=== CONT  TestAccEFSFileSystemDataSource_name
--- PASS: TestAccEFSFileSystemDataSource_name (23.62s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        25.880s

╰─❯ make testacc TESTS=TestAccEFSFileSystemDataSource_tags PKG=efs

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 20 -run='TestAccEFSFileSystemDataSource_tags'  -timeout 360m
=== RUN   TestAccEFSFileSystemDataSource_tags
=== PAUSE TestAccEFSFileSystemDataSource_tags
=== CONT  TestAccEFSFileSystemDataSource_tags
--- PASS: TestAccEFSFileSystemDataSource_tags (24.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/efs        26.836s

yaronya and others added 8 commits December 19, 2023 16:39
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
Signed-off-by: Yaron Yarimi <yaron.yarimi@env0.com>
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/efs Issues and PRs that pertain to the efs service. labels Dec 21, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 21, 2023
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEFSFileSystem_protection\|TestAccEFSFileSystem_basic\|TestAccEFSFileSystemDataSource_id' PKG=efs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 2  -run=TestAccEFSFileSystem_protection\|TestAccEFSFileSystem_basic\|TestAccEFSFileSystemDataSource_id -timeout 360m
=== RUN   TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN   TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN   TestAccEFSFileSystem_protection
=== PAUSE TestAccEFSFileSystem_protection
=== CONT  TestAccEFSFileSystemDataSource_id
=== CONT  TestAccEFSFileSystem_protection
--- PASS: TestAccEFSFileSystemDataSource_id (25.51s)
=== CONT  TestAccEFSFileSystem_basic
--- PASS: TestAccEFSFileSystem_protection (40.61s)
--- PASS: TestAccEFSFileSystem_basic (26.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/efs	57.594s

@ewbankkit
Copy link
Contributor

@yaronya Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 61fd851 into hashicorp:main Jan 3, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.32.0 milestone Jan 3, 2024
Copy link

This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants