Feature request: cross_zone_load_balancing support for aws_lb

[nodesocket]

Can you add the following new directive and support for cross_zone_load_balancing in the aws_lb resource? This was recently released https://aws.amazon.com/about-aws/whats-new/2018/02/network-load-balancer-now-supports-cross-zone-load-balancing/.

[bflad]

You'll be happy to know there is an open PR already. 😄
#3537

I'll mark it to close this ticket when its merged.

[bflad]

Support has been merged into master and will release with v1.11.0 of the AWS provider, likely in about a week. 🎉

[nodesocket]

Awesome. Thanks. 🍾

[bflad]

This has been released in version 1.11.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[israel-tk]

This is somewhat causing issues for me. I'm using an ALB, which does not support this attribute, but Terraform still says:

  ~ module.app.aws_alb.internal_load_balancer
      enable_cross_zone_load_balancing: "" => "false"

See #4168.

Shouldn't Terraform ignore this attribute for ALBs?

[Puneeth-n]

@israel-tk can you share your config?

[israel-tk]

I'm using AWS plugin terraform-provider-aws_v1.13.0_x4 and terraform 0.10.8.

This is the relevant part of the config (slightly edited for privacy reasons):

resource "aws_alb" "internal_load_balancer" {
  name     = "${var.cluster_name}-intelb-app"
  internal = "true"
  security_groups = ["${var.app_sg_id}"]
  subnets = ["${var.app_subnet1_id}",
             "${var.app_subnet2_id}"]
  enable_deletion_protection = false

  tags {
    Name = "${var.cluster_name}-intelb-app"
  }

  lifecycle {
    prevent_destroy = true
  }
}

[Puneeth-n]

The thing is enable_cross_zone_load_balancing is only updated in case of a network load balancer and is ignored otherwise.

https://github.com/terraform-providers/terraform-provider-aws/blob/39fd5e106ce709ef7747fecadf01ebc0d1c7230c/aws/resource_aws_lb.go#L389

I also see that there is a DiffSuppressFunc function. However, I am not sure how it works.

https://github.com/terraform-providers/terraform-provider-aws/blob/39fd5e106ce709ef7747fecadf01ebc0d1c7230c/aws/resource_aws_lb.go#L170

CC: @bflad

[bflad]

The fix for suppressing non-applicable attributes in aws_lb diffs was made in #4032 and released in version 1.14.0 of the AWS provider.

[israel-tk]

Awesome, thanks a lot and sorry for the noise!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!