Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform try to change enable_cross_zone_load_balancing and allow_overwrite parameters #4168

Closed
israel-tk opened this issue Apr 11, 2018 · 9 comments
Milestone

Comments

@israel-tk
Copy link

israel-tk commented Apr 11, 2018

Seems an issue very similar to #4065 but for different resources and parameters.

On plan, example:

  ~ module.app.aws_alb.internal_load_balancer
      enable_cross_zone_load_balancing: "" => "false"
  ~ module.dns.aws_route53_record.internal_record
      allow_overwrite:                  "" => "true"

@aaithal?

@Puneeth-n
Copy link
Contributor

Which version of the plugin?

@israel-tk
Copy link
Author

AWS plugin terraform-provider-aws_v1.13.0_x4, terraform 0.10.8

@Puneeth-n
Copy link
Contributor

Puneeth-n commented Apr 11, 2018

Well, in your plan, it is defaulting to false and true. So you should change your configuration accordingly. Check the PR #3854 and the corresponding bug it closes #3848

@israel-tk
Copy link
Author

But does it make sense that these attributes are empty by default? I understand they were added recently to Terraform, but the default returned by AWS should be true or false in most cases, not blank.

Isn't this similar to #4065 at all?

@Puneeth-n
Copy link
Contributor

Puneeth-n commented Apr 11, 2018

@israel-tk Oh AWS changes their API response from time to time. Sometimes they send sane defaults, sometimes nil. Check #4065 for example. They changed the API response twice in a day! 😅 I fixed one yesterday #4148

@israel-tk
Copy link
Author

OK so I'm closing this ticket as it's an AWS issue, not a Terraform one. :)

@israel-tk
Copy link
Author

However according to https://docs.aws.amazon.com/elasticloadbalancing/latest/userguide/how-elastic-load-balancing-works.html "With Application Load Balancers, cross-zone load balancing is always enabled.".

I don't think the attribute enable_cross_zone_load_balancing should be available for application load balancers in Terraform. Is this a bug in the provider? If so, I can open another ticket about this.

@bflad
Copy link
Contributor

bflad commented Apr 11, 2018

The fix for suppressing non-applicable attributes in aws_lb diffs was made in #4032 and released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

If that fix is not working we can reopen this issue.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants