Remove unused code from target_listener module #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code in
chef-repo
never specifies a value for the variablecreate_listener
, so this variable always gets the default valuetrue
in the module’s code.This PR removes the unused variable, along with all the code that is unused as a result of its removal.
My goal is to simplify the code in this repository related to application load balancers, so that we can create a fully-functiona load balancer with one
module
declaration, instead of the three that we use today. This is the first step towards that goal.The diff in the planshot is due to AWS changing their API response, which is why
enable_cross_zone_load_balancing
is gone as an attribute — per this issue and AWS’s documentation: