Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Terraform crash for AWS Kinesis Firehose #4148

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fixes Terraform crash for AWS Kinesis Firehose #4148

merged 1 commit into from
Apr 10, 2018

Conversation

Puneeth-n
Copy link
Contributor

@Puneeth-n Puneeth-n commented Apr 10, 2018 •
edited
Loading

fixes #4109

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Apr 10, 2018
@Puneeth-n Puneeth-n changed the title [WIP] fixes terraform crash [WIP] fixes terraform crash for AWS Kinesis Firehose Apr 10, 2018
@Puneeth-n Puneeth-n changed the title [WIP] fixes terraform crash for AWS Kinesis Firehose [WIP] Fixes Terraform crash for AWS Kinesis Firehose Apr 10, 2018
@bflad
Copy link
Contributor

bflad commented Apr 10, 2018

I think this can be a one line fix:

https://github.com/terraform-providers/terraform-provider-aws/blob/20adea2e019a209563352f05f498cd265d6a2789/aws/resource_aws_kinesis_firehose_delivery_stream.go#L179

@bflad bflad added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/firehose Issues and PRs that pertain to the firehose service. labels Apr 10, 2018
@Puneeth-n Puneeth-n changed the title [WIP] Fixes Terraform crash for AWS Kinesis Firehose Fixes Terraform crash for AWS Kinesis Firehose Apr 10, 2018
@Puneeth-n Puneeth-n force-pushed the chore/fix-firehose-terraform-crash branch from 36a9a80 to 1a39e9e Compare April 10, 2018 19:00
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Apr 10, 2018
@Puneeth-n
Copy link
Contributor Author

@bflad done. I'm running acceptance tests. will update once it is done.

@bflad
Copy link
Contributor

bflad commented Apr 10, 2018

@Puneeth-n thank you very much! Sorry I meant to look into this yesterday and submit the fix. 😅

@bflad
Copy link
Contributor

bflad commented Apr 10, 2018

I'll also kick off the tests on our side just to verify this with what testing we do have.

@bflad bflad added this to the v1.14.1 milestone Apr 10, 2018
@bflad bflad self-requested a review April 10, 2018 19:07
@Puneeth-n
Copy link
Contributor Author

@bflad here are the tests:

AWS_REGION=eu-west-1 TF_ACC=1 go test ./... -v -run=TestAccAWSKinesisFirehoseDeliveryStream_ -timeout 120m -parallel=4
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_importBasic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_importBasic (138.34s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3basic (131.52s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3KinesisStreamSource (122.38s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3WithCloudwatchLogging (119.20s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_s3ConfigUpdates (249.11s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3basic (145.06s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3KmsKeyArn (307.46s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidProcessorType
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidProcessorType (1.67s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidParameterName
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3InvalidParameterName (1.74s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ExtendedS3Updates (158.22s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_RedshiftConfigUpdates (983.75s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_SplunkConfigUpdates (159.78s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_ElasticsearchConfigUpdates (1133.50s)
=== RUN   TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration
--- PASS: TestAccAWSKinesisFirehoseDeliveryStream_missingProcessingConfiguration (134.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3786.024s
root@5a926ca22be9:/go/src/github.com/terraform-providers/terraform-provider-aws#

@Puneeth-n
Copy link
Contributor Author

@bflad No worries. :) We wanna move to NodeJs 8.10 and this was a real blocker for us so looked into it today. Thanks for the review 🚀 Any idea when 1.14.1 will be released?

@bflad
Copy link
Contributor

bflad commented Apr 10, 2018

I'm planning on releasing v1.14.1 tomorrow 😄

bflad
bflad approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you again 🚀

@bflad bflad merged commit bc7a3cb into hashicorp:master Apr 10, 2018
bflad added a commit that referenced this pull request Apr 10, 2018
@bflad
Update CHANGELOG for #4148
fbfd6a0
@Puneeth-n Puneeth-n mentioned this pull request Apr 11, 2018
Closed
@bflad
Copy link
Contributor

bflad commented Apr 11, 2018

This has been released in version 1.14.1 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
@Puneeth-n Puneeth-n deleted the chore/fix-firehose-terraform-crash branch April 7, 2020 05:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/firehose Issues and PRs that pertain to the firehose service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.14.1
Development

Successfully merging this pull request may close these issues.

Terraform plugin 1.14.0 crashing
2 participants
@Puneeth-n @bflad