Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_securitylake_subscriber supports only one source #36688

Closed
kclinden opened this issue Apr 2, 2024 · 4 comments · Fixed by #36268
Closed

[Bug]: aws_securitylake_subscriber supports only one source #36688

kclinden opened this issue Apr 2, 2024 · 4 comments · Fixed by #36268
Assignees
Labels
bug Addresses a defect in current functionality. service/securitylake Issues and PRs that pertain to the securitylake service.
Milestone

Comments

@kclinden
Copy link

kclinden commented Apr 2, 2024

Terraform Core Version

Terraform v1.7.5

AWS Provider Version

registry.terraform.io/hashicorp/aws v5.43.0

Affected Resource(s)

#Subscriber
resource "aws_securitylake_subscriber" "foo" {
  subscriber_name        = "foo"
  access_type            = "S3"
  subscriber_description = "Allow foo to access data"

  source {
    aws_log_source_resource {
      source_name    = "SH_FINDINGS"
      source_version = "2.0"
    }
    aws_log_source_resource {
       source_name    = "ROUTE53"
       source_version = "2.0"
    }
  }
  subscriber_identity {
    external_id = "foo"
    principal   = "000123456789"
  }
}

Expected Behavior

Sources should take an array of LogSourceResource objects.
https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateSubscriber.html

Actual Behavior

│ Error: Invalid Attribute Value

│ with aws_securitylake_subscriber.cribl,
│ on main.tf line 88, in resource "aws_securitylake_subscriber" "foo":
│ 88: source {

│ Attribute source[0].aws_log_source_resource list must contain at most 1 elements, got: 2

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

n/a

Steps to Reproduce

terraform init
terraform plan

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

Based on the API it looks like sources should be an array of objects. I also tried multiple source blocks but got the same result.

sources = [
  aws_log_source_resource {},
  aws_log_source_resource {}
]

Would you like to implement a fix?

None

@kclinden kclinden added the bug Addresses a defect in current functionality. label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/securitylake Issues and PRs that pertain to the securitylake service. label Apr 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 2, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Apr 3, 2024
@gdavison gdavison self-assigned this May 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2024
Copy link

github-actions bot commented May 3, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.49.0 milestone May 3, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 10, 2024
Copy link

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/securitylake Issues and PRs that pertain to the securitylake service.
Projects
None yet
3 participants