Fix aws_securitylake_subscriber to accept more than one source blocks

[lawliet89]

Description

Fix aws_securitylake_subscriber to accept more than one source blocks

• The API reference mentions a list of log sources: https://docs.aws.amazon.com/security-lake/latest/APIReference/API_CreateSubscriber.html#securitylake-CreateSubscriber-request-sources
• CLI aws securitylake get-subscriber for a subscriber created via the Console return multiple sources

{
    "subscriber": {
        "accessTypes": [
            "LAKEFORMATION"
        ],
        "createdAt": "2023-07-17T02:56:50.655560+00:00",
        "resourceShareArn": "arn:aws:ram:ap-southeast-1:xxxxxx:resource-share/xxx",
        "resourceShareName": "LakeFormation-xxxx",
        "sources": [
            {
                "awsLogSource": {
                    "sourceName": "CLOUD_TRAIL_MGMT",
                    "sourceVersion": "2.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "LAMBDA_EXECUTION",
                    "sourceVersion": "2.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "EKS_AUDIT",
                    "sourceVersion": "2.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "ROUTE53",
                    "sourceVersion": "2.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "SH_FINDINGS",
                    "sourceVersion": "2.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "VPC_FLOW",
                    "sourceVersion": "2.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "S3_DATA",
                    "sourceVersion": "2.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "CLOUD_TRAIL_MGMT",
                    "sourceVersion": "1.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "LAMBDA_EXECUTION",
                    "sourceVersion": "1.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "S3_DATA",
                    "sourceVersion": "1.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "VPC_FLOW",
                    "sourceVersion": "1.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "ROUTE53",
                    "sourceVersion": "1.0"
                }
            },
            {
                "awsLogSource": {
                    "sourceName": "SH_FINDINGS",
                    "sourceVersion": "1.0"
                }
            }
        ],
        "subscriberArn": "arn:aws:securitylake:ap-southeast-1:xxxx:subscriber/xxxx",
        "subscriberDescription": "",
        "subscriberId": "xxx",
        "subscriberIdentity": {
            "externalId": "xxx",
            "principal": "xxx"
        },
        "subscriberName": "example",
        "subscriberStatus": "ACTIVE",
        "updatedAt": "2024-03-01T02:52:42.318384+00:00"
    }

Closes #36688

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[edgar-avetisyan-vay]

Hi, when we are expecting this to be merged?

[gdavison]

Thanks for the PR, @lawliet89.

I added a test for multiple sources, so I had to make a number of changes to other resources. I also changed sources from a List to Set, since order doesn't matter.

--- PASS: TestAccSecurityLake_serial (1839.56s)
--- PASS: TestAccSecurityLake_serial/SubscriberNotification (294.61s)
--- PASS: TestAccSecurityLake_serial/SubscriberNotification/https (61.40s)
--- PASS: TestAccSecurityLake_serial/SubscriberNotification/disappears (64.29s)
--- PASS: TestAccSecurityLake_serial/SubscriberNotification/update (109.56s)
--- PASS: TestAccSecurityLake_serial/SubscriberNotification/basic (59.36s)
--- PASS: TestAccSecurityLake_serial/AWSLogSource (333.46s)
--- PASS: TestAccSecurityLake_serial/AWSLogSource/basic (53.88s)
--- PASS: TestAccSecurityLake_serial/AWSLogSource/disappears (44.63s)
--- PASS: TestAccSecurityLake_serial/AWSLogSource/multiple (89.59s)
--- PASS: TestAccSecurityLake_serial/AWSLogSource/multiRegion (84.90s)
--- PASS: TestAccSecurityLake_serial/AWSLogSource/sourceVersion (60.46s)
--- PASS: TestAccSecurityLake_serial/CustomLogSource (291.51s)
--- PASS: TestAccSecurityLake_serial/CustomLogSource/basic (49.82s)
--- PASS: TestAccSecurityLake_serial/CustomLogSource/disappears (47.63s)
--- PASS: TestAccSecurityLake_serial/CustomLogSource/eventClasses (77.64s)
--- PASS: TestAccSecurityLake_serial/CustomLogSource/multiple (53.29s)
--- PASS: TestAccSecurityLake_serial/CustomLogSource/sourceVersion (63.13s)
--- PASS: TestAccSecurityLake_serial/DataLake (349.35s)
--- PASS: TestAccSecurityLake_serial/DataLake/basic (44.45s)
--- PASS: TestAccSecurityLake_serial/DataLake/disappears (42.28s)
--- PASS: TestAccSecurityLake_serial/DataLake/tags (61.22s)
--- PASS: TestAccSecurityLake_serial/DataLake/lifecycle (48.26s)
--- PASS: TestAccSecurityLake_serial/DataLake/lifecycleUpdate (77.22s)
--- PASS: TestAccSecurityLake_serial/DataLake/replication (75.93s)
--- PASS: TestAccSecurityLake_serial/Subscriber (570.64s)
--- PASS: TestAccSecurityLake_serial/Subscriber/basic (49.37s)
--- PASS: TestAccSecurityLake_serial/Subscriber/customLogs (60.16s)
--- PASS: TestAccSecurityLake_serial/Subscriber/disappears (54.07s)
--- PASS: TestAccSecurityLake_serial/Subscriber/multipleSources (145.40s)
--- PASS: TestAccSecurityLake_serial/Subscriber/tags (72.68s)
--- PASS: TestAccSecurityLake_serial/Subscriber/updated (65.75s)
--- PASS: TestAccSecurityLake_serial/Subscriber/migrateSource (72.73s)
--- PASS: TestAccSecurityLake_serial/Subscriber/accessType (50.48s)

[github-actions]

This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.