Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: Support for AWS Backup "logically air-gapped vault" #38768

Closed
rymancl opened this issue Aug 8, 2024 · 4 comments · Fixed by #39098
Closed

[New Resource]: Support for AWS Backup "logically air-gapped vault" #38768

rymancl opened this issue Aug 8, 2024 · 4 comments · Fixed by #39098
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service.
Milestone

Comments

@rymancl
Copy link

rymancl commented Aug 8, 2024

Description

Announcement from AWS: https://aws.amazon.com/about-aws/whats-new/2024/08/general-availability-aws-backup-logically-air-gapped-vault/

Dev Guide: https://docs.aws.amazon.com/aws-backup/latest/devguide/logicallyairgappedvault.html

Blog Post: https://aws.amazon.com/blogs/storage/building-cyber-resiliency-with-aws-backup-logically-air-gapped-vault/

Requested Resource(s) and/or Data Source(s)

  • aws_lag_backup_vault
    • Note: Requesting this as a new resource/data-source as opposed to enhancement to aws_backup_vault as it uses a separate API to create. If you all disagree, feel free to alter.

Potential Terraform Configuration

resource "aws_lag_backup_vault" "example" {
  name = "example_lag_backup_vault"
}

References

AWS CLI [Create]: https://awscli.amazonaws.com/v2/documentation/api/latest/reference/backup/create-logically-air-gapped-backup-vault.html

Go SDK [Create]: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/backup#Client.CreateLogicallyAirGappedBackupVault

Looks like there is no special API for [Delete] and it used the standard DeleteBackupVault: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/backup#Client.DeleteBackupVault

Would you like to implement a fix?

No

Copy link

github-actions bot commented Aug 8, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 8, 2024
@aristosvo
Copy link
Contributor

aristosvo commented Aug 8, 2024

I would like to implement this. But hey, open to any kind of collaboration! 💪

  • I'll first investigate implementing it as a separate resource to validate its behavior, based on that I'll check whether it needs integration in the existing resource (probably not).
  • In my opinion, based on limited experience, this looks like a separate resource to me, mainly triggered by the fact that it is created by a separate API call.

Update: Ran into an issue, VaultState is not exposed on Describe/List actions, just on CreateLogicallyAirGappedBackupVaultOutput. This makes implementation of this resource with the SDK at this moment in time impossible.

Update 2: Combined Go SDK fix branch and feature branch on the Terraform Provider are currently working, but are not releasable as such. The AWS SDK team has raised an internal issue towards Backup team.

@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 8, 2024
Copy link

github-actions bot commented Oct 2, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.70.0 milestone Oct 2, 2024
Copy link

github-actions bot commented Oct 4, 2024

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/backup Issues and PRs that pertain to the backup service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants