[New resource] AWS Backup logically air gapped vault #39098

aristosvo · 2024-08-30T19:15:53Z

Description

Creates a new resource, logically air gapped vault: aws_backup_logically_air_gapped_vault. Implemented as a separate resource, which seemed like the go-to as inputs are different from a normal vault.

Relations

Closes #38768
Depends on #39112

References

Output from Acceptance Testing

% make testacc TESTS=TestAccBackupLAGVault PKG=backup
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccBackupLAGVault'  -timeout 360m
=== RUN   TestAccBackupLAGVault_basic
=== PAUSE TestAccBackupLAGVault_basic
=== RUN   TestAccBackupLAGVault_disappears
=== PAUSE TestAccBackupLAGVault_disappears
=== RUN   TestAccBackupLAGVault_tags
=== PAUSE TestAccBackupLAGVault_tags
=== CONT  TestAccBackupLAGVault_basic
=== CONT  TestAccBackupLAGVault_tags
=== CONT  TestAccBackupLAGVault_disappears
--- PASS: TestAccBackupLAGVault_basic (153.31s)
--- PASS: TestAccBackupLAGVault_disappears (160.38s)
--- PASS: TestAccBackupLAGVault_tags (170.88s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup    175.325s
...

github-actions · 2024-08-30T19:16:06Z

Community Note

Voting for Prioritization

Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
Please see our prioritization guide for information on how we prioritize.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

github-actions · 2024-08-30T19:16:10Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

% make testacc TESTARGS='-run=TestAccBackupLogicallyAirGappedVault_' PKG=backup ACCTEST_PARALLELISM=2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 2 -run=TestAccBackupLogicallyAirGappedVault_ -timeout 360m === RUN TestAccBackupLogicallyAirGappedVault_basic === PAUSE TestAccBackupLogicallyAirGappedVault_basic === RUN TestAccBackupLogicallyAirGappedVault_disappears === PAUSE TestAccBackupLogicallyAirGappedVault_disappears === RUN TestAccBackupLogicallyAirGappedVault_tags === PAUSE TestAccBackupLogicallyAirGappedVault_tags === CONT TestAccBackupLogicallyAirGappedVault_basic === CONT TestAccBackupLogicallyAirGappedVault_tags --- PASS: TestAccBackupLogicallyAirGappedVault_basic (158.36s) === CONT TestAccBackupLogicallyAirGappedVault_disappears --- PASS: TestAccBackupLogicallyAirGappedVault_tags (164.34s) --- PASS: TestAccBackupLogicallyAirGappedVault_disappears (145.31s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 309.059s

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBackupLogicallyAirGappedVault_' PKG=backup ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 2  -run=TestAccBackupLogicallyAirGappedVault_ -timeout 360m
=== RUN   TestAccBackupLogicallyAirGappedVault_basic
=== PAUSE TestAccBackupLogicallyAirGappedVault_basic
=== RUN   TestAccBackupLogicallyAirGappedVault_disappears
=== PAUSE TestAccBackupLogicallyAirGappedVault_disappears
=== RUN   TestAccBackupLogicallyAirGappedVault_tags
=== PAUSE TestAccBackupLogicallyAirGappedVault_tags
=== CONT  TestAccBackupLogicallyAirGappedVault_basic
=== CONT  TestAccBackupLogicallyAirGappedVault_tags
--- PASS: TestAccBackupLogicallyAirGappedVault_basic (158.36s)
=== CONT  TestAccBackupLogicallyAirGappedVault_disappears
--- PASS: TestAccBackupLogicallyAirGappedVault_tags (164.34s)
--- PASS: TestAccBackupLogicallyAirGappedVault_disappears (145.31s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	309.059s

% make testacc TESTARGS='-run=TestAccBackupFramework_serial' PKG=backup    
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 20  -run=TestAccBackupFramework_serial -timeout 360m
=== RUN   TestAccBackupFramework_serial
=== PAUSE TestAccBackupFramework_serial
=== CONT  TestAccBackupFramework_serial
=== RUN   TestAccBackupFramework_serial/Resource
=== RUN   TestAccBackupFramework_serial/Resource/UpdateControlInputParameters
=== RUN   TestAccBackupFramework_serial/Resource/UpdateControls
=== RUN   TestAccBackupFramework_serial/Resource/basic
=== RUN   TestAccBackupFramework_serial/Resource/disappears
=== RUN   TestAccBackupFramework_serial/Resource/tags
=== RUN   TestAccBackupFramework_serial/Resource/UpdateControlScope
    framework_test.go:162: Step 5/7 error: After applying this test step, the non-refresh plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_backup_framework.test will be updated in-place
          ~ resource "aws_backup_framework" "test" {
                id                = "tf_acc_test_38qbor1"
                name              = "tf_acc_test_38qbor1"
                tags              = {
                    "Name" = "tf_acc_test_38qbor1"
                }
                # (6 unchanged attributes hidden)
        
              - control {
                  - name = "BACKUP_RESOURCES_PROTECTED_BY_BACKUP_PLAN" -> null
        
                  - scope {
                      - compliance_resource_ids   = [] -> null
                      - compliance_resource_types = [
                          - "Aurora",
                          - "DynamoDB",
                          - "EBS",
                          - "EC2",
                          - "EFS",
                          - "FSx",
                          - "RDS",
                          - "S3",
                          - "Storage Gateway",
                          - "VirtualMachine",
                        ] -> null
                      - tags                      = {
                          - "Name" = "example"
                        } -> null
                    }
                }
              + control {
                  + name = "BACKUP_RESOURCES_PROTECTED_BY_BACKUP_PLAN"
        
                  + scope {
                      + compliance_resource_ids   = (known after apply)
                      + compliance_resource_types = (known after apply)
                      + tags                      = {
                          + "Name" = "example"
                        }
                    }
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
=== RUN   TestAccBackupFramework_serial/DataSource
=== RUN   TestAccBackupFramework_serial/DataSource/basic
--- FAIL: TestAccBackupFramework_serial (817.18s)
    --- FAIL: TestAccBackupFramework_serial/Resource (715.39s)
        --- PASS: TestAccBackupFramework_serial/Resource/UpdateControlInputParameters (75.64s)
        --- PASS: TestAccBackupFramework_serial/Resource/UpdateControls (163.35s)
        --- PASS: TestAccBackupFramework_serial/Resource/basic (91.84s)
        --- PASS: TestAccBackupFramework_serial/Resource/disappears (31.45s)
        --- PASS: TestAccBackupFramework_serial/Resource/tags (98.95s)
        --- FAIL: TestAccBackupFramework_serial/Resource/UpdateControlScope (254.16s)
    --- PASS: TestAccBackupFramework_serial/DataSource (101.79s)
        --- PASS: TestAccBackupFramework_serial/DataSource/basic (101.79s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/backup	822.462s
FAIL
make: *** [testacc] Error 1

Failure is occurring in CI and is unrelated to this change.

% make testacc TESTARGS='-run=TestAccBackupGlobalSettings_serial' PKG=backup
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 20  -run=TestAccBackupGlobalSettings_serial -timeout 360m
=== RUN   TestAccBackupGlobalSettings_serial
=== PAUSE TestAccBackupGlobalSettings_serial
=== CONT  TestAccBackupGlobalSettings_serial
=== RUN   TestAccBackupGlobalSettings_serial/basic
--- PASS: TestAccBackupGlobalSettings_serial (31.61s)
    --- PASS: TestAccBackupGlobalSettings_serial/basic (31.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	37.011s

% make testacc TESTARGS='-run=TestAccBackupPlan_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupPlan_ -timeout 360m
=== RUN   TestAccBackupPlan_basic
=== PAUSE TestAccBackupPlan_basic
=== RUN   TestAccBackupPlan_withTags
=== PAUSE TestAccBackupPlan_withTags
=== RUN   TestAccBackupPlan_withRules
=== PAUSE TestAccBackupPlan_withRules
=== RUN   TestAccBackupPlan_withLifecycle
=== PAUSE TestAccBackupPlan_withLifecycle
=== RUN   TestAccBackupPlan_withRecoveryPointTags
=== PAUSE TestAccBackupPlan_withRecoveryPointTags
=== RUN   TestAccBackupPlan_RuleCopyAction_sameRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_sameRegion
=== RUN   TestAccBackupPlan_RuleCopyAction_noLifecycle
=== PAUSE TestAccBackupPlan_RuleCopyAction_noLifecycle
=== RUN   TestAccBackupPlan_RuleCopyAction_multiple
=== PAUSE TestAccBackupPlan_RuleCopyAction_multiple
=== RUN   TestAccBackupPlan_RuleCopyAction_crossRegion
=== PAUSE TestAccBackupPlan_RuleCopyAction_crossRegion
=== RUN   TestAccBackupPlan_advancedBackupSetting
=== PAUSE TestAccBackupPlan_advancedBackupSetting
=== RUN   TestAccBackupPlan_enableContinuousBackup
=== PAUSE TestAccBackupPlan_enableContinuousBackup
=== RUN   TestAccBackupPlan_disappears
=== PAUSE TestAccBackupPlan_disappears
=== CONT  TestAccBackupPlan_basic
=== CONT  TestAccBackupPlan_withLifecycle
=== CONT  TestAccBackupPlan_RuleCopyAction_noLifecycle
--- PASS: TestAccBackupPlan_basic (15.01s)
=== CONT  TestAccBackupPlan_RuleCopyAction_sameRegion
--- PASS: TestAccBackupPlan_RuleCopyAction_noLifecycle (31.39s)
=== CONT  TestAccBackupPlan_advancedBackupSetting
--- PASS: TestAccBackupPlan_RuleCopyAction_sameRegion (30.38s)
=== CONT  TestAccBackupPlan_disappears
--- PASS: TestAccBackupPlan_withLifecycle (47.53s)
=== CONT  TestAccBackupPlan_enableContinuousBackup
--- PASS: TestAccBackupPlan_advancedBackupSetting (21.68s)
=== CONT  TestAccBackupPlan_withRules
--- PASS: TestAccBackupPlan_disappears (11.33s)
=== CONT  TestAccBackupPlan_RuleCopyAction_crossRegion
--- PASS: TestAccBackupPlan_enableContinuousBackup (13.37s)
=== CONT  TestAccBackupPlan_withTags
--- PASS: TestAccBackupPlan_RuleCopyAction_crossRegion (20.89s)
=== CONT  TestAccBackupPlan_RuleCopyAction_multiple
--- PASS: TestAccBackupPlan_withRules (29.86s)
=== CONT  TestAccBackupPlan_withRecoveryPointTags
--- PASS: TestAccBackupPlan_withTags (29.71s)
--- PASS: TestAccBackupPlan_RuleCopyAction_multiple (13.64s)
--- PASS: TestAccBackupPlan_withRecoveryPointTags (29.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	118.071s

% make testacc TESTARGS='-run=TestAccBackupPlanDataSource_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupPlanDataSource_ -timeout 360m
=== RUN   TestAccBackupPlanDataSource_basic
=== PAUSE TestAccBackupPlanDataSource_basic
=== CONT  TestAccBackupPlanDataSource_basic
--- PASS: TestAccBackupPlanDataSource_basic (11.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	17.317s

% make testacc TESTARGS='-run=TestAccBackupRegionSettings_serial' PKG=backup
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 20  -run=TestAccBackupRegionSettings_serial -timeout 360m
=== RUN   TestAccBackupRegionSettings_serial
=== PAUSE TestAccBackupRegionSettings_serial
=== CONT  TestAccBackupRegionSettings_serial
=== RUN   TestAccBackupRegionSettings_serial/basic
--- PASS: TestAccBackupRegionSettings_serial (27.22s)
    --- PASS: TestAccBackupRegionSettings_serial/basic (27.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	32.657s

% make testacc TESTARGS='-run=TestAccBackupReportPlan_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupReportPlan_ -timeout 360m
=== RUN   TestAccBackupReportPlan_basic
=== PAUSE TestAccBackupReportPlan_basic
=== RUN   TestAccBackupReportPlan_updateTags
=== PAUSE TestAccBackupReportPlan_updateTags
=== RUN   TestAccBackupReportPlan_updateReportDeliveryChannel
=== PAUSE TestAccBackupReportPlan_updateReportDeliveryChannel
=== RUN   TestAccBackupReportPlan_updateReportSettings
=== PAUSE TestAccBackupReportPlan_updateReportSettings
=== RUN   TestAccBackupReportPlan_disappears
=== PAUSE TestAccBackupReportPlan_disappears
=== CONT  TestAccBackupReportPlan_basic
=== CONT  TestAccBackupReportPlan_updateReportSettings
=== CONT  TestAccBackupReportPlan_updateReportDeliveryChannel
--- PASS: TestAccBackupReportPlan_basic (32.48s)
=== CONT  TestAccBackupReportPlan_disappears
--- PASS: TestAccBackupReportPlan_updateReportSettings (32.57s)
=== CONT  TestAccBackupReportPlan_updateTags
--- PASS: TestAccBackupReportPlan_updateReportDeliveryChannel (33.30s)
--- PASS: TestAccBackupReportPlan_disappears (17.55s)
--- PASS: TestAccBackupReportPlan_updateTags (44.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	82.037s

% make testacc TESTARGS='-run=TestAccBackupReportPlanDataSource_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupReportPlanDataSource_ -timeout 360m
=== RUN   TestAccBackupReportPlanDataSource_basic
=== PAUSE TestAccBackupReportPlanDataSource_basic
=== RUN   TestAccBackupReportPlanDataSource_reportSettings
=== PAUSE TestAccBackupReportPlanDataSource_reportSettings
=== CONT  TestAccBackupReportPlanDataSource_basic
=== CONT  TestAccBackupReportPlanDataSource_reportSettings
--- PASS: TestAccBackupReportPlanDataSource_basic (19.31s)
--- PASS: TestAccBackupReportPlanDataSource_reportSettings (20.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	25.515s

% make testacc TESTARGS='-run=TestAccBackupSelection_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupSelection_ -timeout 360m
=== RUN   TestAccBackupSelection_basic
=== PAUSE TestAccBackupSelection_basic
=== RUN   TestAccBackupSelection_disappears
=== PAUSE TestAccBackupSelection_disappears
=== RUN   TestAccBackupSelection_withTags
=== PAUSE TestAccBackupSelection_withTags
=== RUN   TestAccBackupSelection_conditionsWithTags
=== PAUSE TestAccBackupSelection_conditionsWithTags
=== RUN   TestAccBackupSelection_withResources
=== PAUSE TestAccBackupSelection_withResources
=== RUN   TestAccBackupSelection_withNotResources
=== PAUSE TestAccBackupSelection_withNotResources
=== RUN   TestAccBackupSelection_updateTag
=== PAUSE TestAccBackupSelection_updateTag
=== CONT  TestAccBackupSelection_basic
=== CONT  TestAccBackupSelection_withResources
=== CONT  TestAccBackupSelection_updateTag
--- PASS: TestAccBackupSelection_basic (15.10s)
=== CONT  TestAccBackupSelection_withTags
--- PASS: TestAccBackupSelection_updateTag (23.60s)
=== CONT  TestAccBackupSelection_conditionsWithTags
--- PASS: TestAccBackupSelection_withTags (13.98s)
=== CONT  TestAccBackupSelection_withNotResources
--- PASS: TestAccBackupSelection_withResources (36.13s)
=== CONT  TestAccBackupSelection_disappears
--- PASS: TestAccBackupSelection_conditionsWithTags (13.99s)
--- PASS: TestAccBackupSelection_withNotResources (14.09s)
--- PASS: TestAccBackupSelection_disappears (12.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	53.795s

% make testacc TESTARGS='-run=TestAccBackupSelectionDataSource_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupSelectionDataSource_ -timeout 360m
=== RUN   TestAccBackupSelectionDataSource_basic
=== PAUSE TestAccBackupSelectionDataSource_basic
=== CONT  TestAccBackupSelectionDataSource_basic
--- PASS: TestAccBackupSelectionDataSource_basic (12.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	18.132s

% make testacc TESTARGS='-run=TestAccBackupVaultLockConfiguration_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupVaultLockConfiguration_ -timeout 360m
=== RUN   TestAccBackupVaultLockConfiguration_basic
=== PAUSE TestAccBackupVaultLockConfiguration_basic
=== RUN   TestAccBackupVaultLockConfiguration_disappears
=== PAUSE TestAccBackupVaultLockConfiguration_disappears
=== CONT  TestAccBackupVaultLockConfiguration_basic
=== CONT  TestAccBackupVaultLockConfiguration_disappears
--- PASS: TestAccBackupVaultLockConfiguration_disappears (12.06s)
--- PASS: TestAccBackupVaultLockConfiguration_basic (14.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	19.353s

% make testacc TESTARGS='-run=TestAccBackupVaultNotifications_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupVaultNotifications_ -timeout 360m
=== RUN   TestAccBackupVaultNotifications_basic
=== PAUSE TestAccBackupVaultNotifications_basic
=== RUN   TestAccBackupVaultNotifications_disappears
=== PAUSE TestAccBackupVaultNotifications_disappears
=== CONT  TestAccBackupVaultNotifications_basic
=== CONT  TestAccBackupVaultNotifications_disappears
--- PASS: TestAccBackupVaultNotifications_disappears (12.70s)
--- PASS: TestAccBackupVaultNotifications_basic (14.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	20.118s

% make testacc TESTARGS='-run=TestAccBackupVaultPolicy_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupVaultPolicy_ -timeout 360m
=== RUN   TestAccBackupVaultPolicy_basic
=== PAUSE TestAccBackupVaultPolicy_basic
=== RUN   TestAccBackupVaultPolicy_eventualConsistency
=== PAUSE TestAccBackupVaultPolicy_eventualConsistency
=== RUN   TestAccBackupVaultPolicy_disappears
=== PAUSE TestAccBackupVaultPolicy_disappears
=== RUN   TestAccBackupVaultPolicy_Disappears_vault
=== PAUSE TestAccBackupVaultPolicy_Disappears_vault
=== RUN   TestAccBackupVaultPolicy_ignoreEquivalent
=== PAUSE TestAccBackupVaultPolicy_ignoreEquivalent
=== CONT  TestAccBackupVaultPolicy_basic
=== CONT  TestAccBackupVaultPolicy_Disappears_vault
=== CONT  TestAccBackupVaultPolicy_ignoreEquivalent
--- PASS: TestAccBackupVaultPolicy_Disappears_vault (12.69s)
=== CONT  TestAccBackupVaultPolicy_disappears
--- PASS: TestAccBackupVaultPolicy_ignoreEquivalent (15.96s)
=== CONT  TestAccBackupVaultPolicy_eventualConsistency
--- PASS: TestAccBackupVaultPolicy_basic (22.73s)
--- PASS: TestAccBackupVaultPolicy_disappears (11.63s)
--- PASS: TestAccBackupVaultPolicy_eventualConsistency (21.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	43.077s

% make testacc TESTARGS='-run=TestAccBackupVault_' PKG=backup ACCTEST_PARALLELISM=3     
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupVault_ -timeout 360m
=== RUN   TestAccBackupVault_basic
=== PAUSE TestAccBackupVault_basic
=== RUN   TestAccBackupVault_disappears
=== PAUSE TestAccBackupVault_disappears
=== RUN   TestAccBackupVault_tags
=== PAUSE TestAccBackupVault_tags
=== RUN   TestAccBackupVault_withKMSKey
=== PAUSE TestAccBackupVault_withKMSKey
=== RUN   TestAccBackupVault_forceDestroyEmpty
=== PAUSE TestAccBackupVault_forceDestroyEmpty
=== RUN   TestAccBackupVault_forceDestroyWithRecoveryPoint
=== PAUSE TestAccBackupVault_forceDestroyWithRecoveryPoint
=== CONT  TestAccBackupVault_basic
=== CONT  TestAccBackupVault_withKMSKey
=== CONT  TestAccBackupVault_tags
--- PASS: TestAccBackupVault_basic (13.71s)
=== CONT  TestAccBackupVault_forceDestroyWithRecoveryPoint
--- PASS: TestAccBackupVault_withKMSKey (15.53s)
=== CONT  TestAccBackupVault_disappears
--- PASS: TestAccBackupVault_disappears (10.79s)
=== CONT  TestAccBackupVault_forceDestroyEmpty
--- PASS: TestAccBackupVault_tags (29.17s)
--- PASS: TestAccBackupVault_forceDestroyEmpty (12.81s)
--- PASS: TestAccBackupVault_forceDestroyWithRecoveryPoint (98.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	117.190s

% make testacc TESTARGS='-run=TestAccBackupVaultDataSource_' PKG=backup ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.1 test ./internal/service/backup/... -v -count 1 -parallel 3  -run=TestAccBackupVaultDataSource_ -timeout 360m
=== RUN   TestAccBackupVaultDataSource_basic
=== PAUSE TestAccBackupVaultDataSource_basic
=== CONT  TestAccBackupVaultDataSource_basic
--- PASS: TestAccBackupVaultDataSource_basic (11.18s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/backup	16.589s

ewbankkit · 2024-10-02T21:40:57Z

@aristosvo Thanks for the contribution 🎉 👏.

github-actions · 2024-10-04T12:15:44Z

This functionality has been released in v5.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

aristosvo force-pushed the f-aws_backup_logically_air_gapped_vault-resource branch from 09bc2cb to 5efaaf2 Compare August 30, 2024 19:18

aristosvo marked this pull request as ready for review September 3, 2024 14:04

aristosvo requested a review from a team as a code owner September 3, 2024 14:04

justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2024

aristosvo added 5 commits September 30, 2024 21:23

[New Resource] aws_backup_logically_air_gapped_vault

2c0944f

docs fix

6634f64

changelog

83fa18b

fix imports

2b3f914

semgrep fixes

01a3b11

aristosvo force-pushed the f-aws_backup_logically_air_gapped_vault-resource branch from 01d7215 to 01a3b11 Compare September 30, 2024 19:25

Merge branch 'main' into HEAD

93203b9

ewbankkit self-assigned this Oct 2, 2024

github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 2, 2024

ewbankkit added 9 commits October 2, 2024 11:27

r/aws_backup_logically_air_gapped_vault: Tidy up.

2775ba8

r/aws_backup_framework: Reduce visibility.

af25a50

d/aws_backup_framework: Reduce visibility.

5bd9db4

'testAccFramework_updateTags' -> 'testAccFramework_tags'.

77ba805

Remove 'testAccFrameworkDataSource_controlScopeTag'.

480be4e

r/aws_backup_global_settings: Reduce visibility.

595d6ec

r/aws_backup_region_settings: Reduce visibility.

ecd4d09

r/aws_backup_plan: Reduce visibility.

334c676

ewbankkit added 12 commits October 2, 2024 15:09

d/aws_backup_plan: Reduce visibility.

f724367

r/aws_backup_report_plan: Reduce visibility.

68e2b5f

d/aws_backup_report_plan: Reduce visibility.

c549d9f

r/aws_backup_selection: Reduce visibility.

c33c603

d/aws_backup_selection: Reduce visibility.

6ba32b5

r/aws_backup_vault_lock_configuration: Reduce visibility.

97de21c

r/aws_backup_vault_notifications: Reduce visibility.

5e60aca

r/aws_backup_vault_policy: Reduce visibility.

8ccd5b8

r/aws_backup_vault: Reduce visibility.

9c2ce1f

d/aws_backup_vault: Reduce visibility.

f472cce

Fix semgrep 'ci.semgrep.framework.flex-type-from-framework'.

8e2a75a

Fix semgrep 'ci.backup-in-func-name' and 'ci.backup-in-var-name'.

a4b4e28

ewbankkit approved these changes Oct 2, 2024

View reviewed changes

Cosmetics.

18410ce

ewbankkit merged commit 2d48d13 into hashicorp:main Oct 2, 2024
40 checks passed

github-actions bot added this to the v5.70.0 milestone Oct 2, 2024

github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New resource] AWS Backup logically air gapped vault #39098

[New resource] AWS Backup logically air gapped vault #39098

aristosvo commented Aug 30, 2024 •

edited

Loading

github-actions bot commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

ewbankkit left a comment

ewbankkit commented Oct 2, 2024

github-actions bot commented Oct 4, 2024

[New resource] AWS Backup logically air gapped vault #39098

[New resource] AWS Backup logically air gapped vault #39098

Conversation

aristosvo commented Aug 30, 2024 • edited Loading

Description

Relations

References

Output from Acceptance Testing

github-actions bot commented Aug 30, 2024

Community Note

github-actions bot commented Aug 30, 2024

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Oct 2, 2024

github-actions bot commented Oct 4, 2024

aristosvo commented Aug 30, 2024 •

edited

Loading