Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Neptune #4713

Closed
atsushi-ishibashi opened this issue May 31, 2018 · 18 comments · Fixed by #5050
Closed

Support Neptune #4713

atsushi-ishibashi opened this issue May 31, 2018 · 18 comments · Fixed by #5050
Labels
new-resource Introduces a new resource. service/neptune Issues and PRs that pertain to the neptune service.
Milestone

Comments

@atsushi-ishibashi
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

New or Affected Resource(s)

  • aws_neptune_cluster
  • aws_neptune_cluster_instance
  • aws_neptune_subnet_group
  • aws_neptune_parameter_group
  • aws_neptune_cluster_parameter_group
  • aws_neptune_event_subscription

Potential Terraform Configuration

resource "aws_neptune_cluster" "example" {
  cluster_identifier = "example"
  engine = "neptune"
  engine_version = "1.0.1"
  cluster_parameter_group_name = "${aws_neptune_cluster_parameter_group.example.name}"
  subnet_group_name = "${aws_neptune_subnet_group.example.name}"
  database_name = "database"
  master_username = "user"
  master_password = "password"
  ...

}

resource "aws_neptune_cluster_instance" "example" {
  identifier = "example"
  cluster_identifier = "${aws_neptune_cluster.example.id}"
  engine = "neptune"
  instance_class = "db.m4.large"
  ...

}

resource "aws_neptune_subnet_group" "example" {
  name = "example"
  description = "example description"
  subnet_ids = ["${aws_subnet.frontend.id}", "${aws_subnet.backend.id}"]
}

resource "aws_neptune_parameter_group" "example" {
  name = "example"
  family = "example"
  description = "example description"
}

resource "aws_neptune_cluster_parameter_group" "example" {
  name = "example"
  family = "example"
  description = "example description"
}

resource "aws_neptune_event_subscription" "example" {
  name = "example"
  sns_topic = "${aws_sns_topic.example.arn}"
  source_type = "db-instance"
  source_ids = ["${aws_neptune_cluster_instance.example.id}"]
  event_categories = [
    "creation",
    "failover",
    ...
  ]
}

Order

  1. aws_neptune_parameter_group,aws_neptune_cluster_parameter_group,aws_neptune_subnet_group
  2. aws_neptune_cluster
  3. aws_neptune_cluster_instance
  4. aws_neptune_event_subscription

References

@bflad bflad added new-resource Introduces a new resource. service/neptune Issues and PRs that pertain to the neptune service. labels May 31, 2018
@dav009
Copy link
Contributor

dav009 commented Jun 1, 2018

opened PR for aws_neptune_parameter_group #4724

@saravanan30erd
Copy link
Contributor

@atsushi-ishibashi @dav009 I would like to work on aws_neptune_subnet_group, anyone working on this?

@atsushi-ishibashi
Copy link
Contributor Author

@saravanan30erd I'm not👍

@dav009
Copy link
Contributor

dav009 commented Jun 5, 2018

@saravanan30erd go for it 👍.
I will address the requested changes in the open PR soon 🙇

@saravanan30erd
Copy link
Contributor

@atsushi-ishibashi @bflad It looks like both RDS and Neptune using same resource DB Subnet Group for subnet groups, so I think we can use the same resource aws_db_subnet_group with just updating document, any thoughts?

@bflad
Copy link
Contributor

bflad commented Jun 5, 2018

@saravanan30erd each service requires its own connection/endpoint and resource handling will likely vary between the two. Definitely create separate resources even if they look very similar.

saravanan30erd added a commit to saravanan30erd/terraform-provider-aws that referenced this issue Jun 5, 2018
saravanan30erd added a commit to saravanan30erd/terraform-provider-aws that referenced this issue Jun 9, 2018
@saravanan30erd
Copy link
Contributor

@atsushi-ishibashi @dav009 I am working on aws_neptune_cluster_parameter_group

@bflad
Copy link
Contributor

bflad commented Jun 21, 2018

For those following along:

  • aws_neptune_parameter_group resource: released in version 1.23.0 (enhanced with arn and tags in 1.24.0)
  • aws_neptune_cluster_parameter_group resource: released in version 1.24.0
  • aws_neptune_subnet_group resource: released in version 1.24.0

@saravanan30erd
Copy link
Contributor

@dav009 I am working on aws_neptune_cluster

@angelinatquach
Copy link

@saravanan30erd do you have an expected completion date? Great work so far btw! Really appreciating the rapid development.

@saravanan30erd
Copy link
Contributor

saravanan30erd commented Jun 28, 2018

@angelinatquach I am expecting to finish this resource before next release.

@austinkelleher
Copy link

We are using Neptune too and really looking forward to seeing this implemented. Thanks for your work on this @saravanan30erd!

@saravanan30erd
Copy link
Contributor

@bflad still two resources are remaining aws_neptune_cluster_instance and aws_neptune_event_subscription, I am working on aws_neptune_cluster_instance.

@bflad
Copy link
Contributor

bflad commented Aug 6, 2018

I'll be picking up aws_neptune_event_subscription this week. 👍

@saravanan30erd
Copy link
Contributor

@bflad I already started and on the half way :)-

@bflad
Copy link
Contributor

bflad commented Aug 6, 2018

@saravanan30erd even better! 😄

bflad added a commit that referenced this issue Aug 9, 2018
Issue #4713 New Resource: neptune_event_subscription
@bflad bflad added this to the v1.31.0 milestone Aug 9, 2018
@bflad
Copy link
Contributor

bflad commented Aug 9, 2018

As of version 1.31.0 of the AWS provider, releasing shortly, all the above mentioned resources have been implemented. 🎉 For future bug reports and feature requests, please submit separate issues so we have a clear definition of done. Thanks!

@bflad bflad closed this as completed Aug 9, 2018
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/neptune Issues and PRs that pertain to the neptune service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants