Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 Block Public Access #6489

Closed
oarmstrong opened this issue Nov 16, 2018 · 9 comments · Fixed by #6607
Closed

S3 Block Public Access #6489

oarmstrong opened this issue Nov 16, 2018 · 9 comments · Fixed by #6607
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3control Issues and PRs that pertain to the s3control service.
Milestone
v1.54.0

Comments

@oarmstrong
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Released yesterday is the functionality to block public access on S3 objects on the account level and the bucket level. We should implement this within the existing bucket resource as well as implement a new resource for the account-level settings.

https://aws.amazon.com/blogs/aws/amazon-s3-block-public-access-another-layer-of-protection-for-your-accounts-and-buckets/

I'm happy to take a stab at this over the weekend.

New or Affected Resource(s)

  • aws_s3_bucket
  • aws_s3_block_public_access (proposed new)
@oarmstrong oarmstrong changed the title S3 Public Access Block S3 Block Public Access Nov 16, 2018
@ewbankkit
Copy link
Contributor

Requires:

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/s3 Issues and PRs that pertain to the s3 service. labels Nov 16, 2018
@1FastSTi 1FastSTi mentioned this issue Nov 16, 2018
Closed
@oarmstrong
Copy link
Contributor Author

I'm going to work on this this evening. Hopefully I'll have something worthy of initial implementation comments soon.

@bflad bflad added service/s3control Issues and PRs that pertain to the s3control service. and removed service/s3 Issues and PRs that pertain to the s3 service. labels Nov 21, 2018
@acburdine
Copy link
Contributor

@oarmstrong have you had a chance to look at this yet? Would totally be willing to pick it up if not 😄

@oarmstrong
Copy link
Contributor Author

@acburdine unfortunately I've been busy so this slipped off my list. I'm still happy to do it but no idea when I'll really be able to get around to it (weekend maybe). If you want to pick it up instead please feel free! :)

@acburdine
Copy link
Contributor

@oarmstrong ok! I'll look into it today.

@acburdine acburdine mentioned this issue Nov 27, 2018
Merged
2 tasks
@bflad bflad mentioned this issue Dec 14, 2018
Merged
@cwyl02
Copy link

cwyl02 commented Dec 20, 2018

Hey guys, looks like the account level public access block has been added per MR above. But is the support for bucket level public access block included?

@bflad
Copy link
Contributor

bflad commented Dec 20, 2018

The aws_s3_account_public_access_block resource has been released in version 1.53.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

The bucket level support still needs to be reviewed and potentially adjusted in #6607.

acburdine added a commit to acburdine/terraform-provider-aws that referenced this issue Dec 21, 2018
@acburdine
[wip] r/s3: add public access block resource
cc3ef53 
fixes hashicorp#6489
- add new s3_bucket_public_access_block_resource and tests
@bflad bflad added this to the v1.54.0 milestone Dec 21, 2018
@bflad
Copy link
Contributor

bflad commented Dec 21, 2018

The aws_s3_bucket_public_access_block resource has now been merged as well, thanks to @acburdine!

We were anticipating cutting 1.54.0 in early January after our end of year break, but this one might be good to get out today beforehand due to popularity... more soon. 😄

jaspervdj-luminal pushed a commit to LuminalHQ/terraform-provider-aws that referenced this issue Oct 8, 2019
@acburdine @jaspervdj-luminal
[wip] r/s3: add public access block resource
c630b93 
fixes hashicorp#6489
- add new s3_bucket_public_access_block_resource and tests
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/s3control Issues and PRs that pertain to the s3control service.
Projects
None yet
Milestone
v1.54.0
Development

Successfully merging a pull request may close this issue.

r/s3: add public access block resource acburdine/terraform-provider-aws
5 participants
@oarmstrong @bflad @ewbankkit @acburdine @cwyl02