Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_athena_workgroup: Add support for resource tags #7667

Closed
ewbankkit opened this issue Feb 23, 2019 · 4 comments · Fixed by #9290
Closed

r/aws_athena_workgroup: Add support for resource tags #7667

ewbankkit opened this issue Feb 23, 2019 · 4 comments · Fixed by #9290
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service.
Milestone
v2.19.0

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Support for tagging Amazon Athena Workgroups added in AWS SDK v1.17.4:

This release adds tagging support for Workgroups to Amazon Athena. Use these APIs to add, remove, or list tags on Workgroups, and leverage the tags for various authorization and billing scenarios.
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 23, 2019
@ewbankkit ewbankkit mentioned this issue Feb 24, 2019
Merged
@ewbankkit
Copy link
Contributor Author

Here's the announcement.

@marcotesch marcotesch mentioned this issue Mar 18, 2019
Closed
@bflad bflad added the service/athena Issues and PRs that pertain to the athena service. label Mar 18, 2019
@teraken0509 teraken0509 mentioned this issue Mar 31, 2019
Closed
bflad added a commit that referenced this issue Jul 10, 2019
@bflad
resource/aws_athena_workgroup: Implement tags support
58050b2 
Reference: #7667

Output from acceptance testing:

```
--- PASS: TestAccAWSAthenaWorkGroup_SseS3Encryption (15.52s)
--- PASS: TestAccAWSAthenaWorkGroup_basic (17.55s)
--- PASS: TestAccAWSAthenaWorkGroup_EnforceWorkgroupConfiguration (20.21s)
--- PASS: TestAccAWSAthenaWorkGroup_Description (20.46s)
--- PASS: TestAccAWSAthenaWorkGroup_PublishCloudWatchMetricsEnabled (22.00s)
--- PASS: TestAccAWSAthenaWorkGroup_BytesScannedCutoffPerQuery (26.63s)
--- PASS: TestAccAWSAthenaWorkGroup_Tags (32.47s)
--- PASS: TestAccAWSAthenaWorkGroup_OutputLocation (54.68s)
--- PASS: TestAccAWSAthenaWorkGroup_KmsEncryption (60.36s)
```
@bflad bflad mentioned this issue Jul 10, 2019
Merged
@bflad bflad added this to the v2.19.0 milestone Jul 11, 2019
@bflad
Copy link
Contributor

bflad commented Jul 11, 2019

The new aws_athena_workgroup resource has been merged including tagging support and will release with version 2.19.0 of the Terraform AWS Provider, likely later today. 👍

@bflad
Copy link
Contributor

bflad commented Jul 11, 2019

This has been released in version 2.19.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ewbankkit ewbankkit mentioned this issue Oct 19, 2019
Closed
@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/athena Issues and PRs that pertain to the athena service.
Projects
None yet
Milestone
v2.19.0
2 participants
@bflad @ewbankkit