Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QuickSight support #8146

Closed
jrobison-sb opened this issue Apr 1, 2019 · 4 comments
Closed

Add QuickSight support #8146

jrobison-sb opened this issue Apr 1, 2019 · 4 comments
Assignees
@bflad
Labels
new-resource Introduces a new resource. service/quicksight Issues and PRs that pertain to the quicksight service.
Milestone
v2.33.0

Comments

@jrobison-sb
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It would be nice if Terraform supported AWS QuickSight. Support for this service has been part of aws-sdk-go as of 1.15.80

New or Affected Resource(s)

Thanks to anyone who can make this happen.
@jrobison-sb jrobison-sb added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 1, 2019
@bflad bflad added new-resource Introduces a new resource. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Apr 1, 2019
bflad added a commit that referenced this issue Apr 1, 2019
@bflad
provider: Add QuickSight client
0dda224 
Reference: #8146

This change verifies the new AWS Go SDK client addition process after #8096

Go Modules updated via:

```
go test ./aws
go mod tidy
go mod vendor
```
@bflad bflad mentioned this issue Apr 1, 2019
Merged
@bflad bflad added the service/quicksight Issues and PRs that pertain to the quicksight service. label Apr 2, 2019
@teraken0509 teraken0509 mentioned this issue Apr 6, 2019
Merged
@nywilken
Copy link
Contributor

The new aws_quicksight_group resource, has been released in version 2.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this resource, please create a new GitHub issue following the template for triage. Thanks!

@mjgpy3 mjgpy3 mentioned this issue Oct 6, 2019
Merged
@mjgpy3
Copy link
Contributor

mjgpy3 commented Oct 10, 2019

Note that QuickSight dashboard URLs (as linked above) are ephemeral (signed/secured to logged-in user and only valid for 5 minutes). So, they're probably not the kind of thing that should be managed via terraform.

@bflad bflad added this to the v2.33.0 milestone Oct 11, 2019
@bflad bflad self-assigned this Oct 11, 2019
@bflad
Copy link
Contributor

bflad commented Oct 11, 2019

Hi everyone 👋 A new aws_quicksight_user resource has been merged (#10401) which will release in version 2.33.0 of the Terraform AWS Provider, Thursday. Thanks to @mjgpy3 for the implementation there. 😄

Given that the two initial new resource asks have been completed and since these "support service" feature requests tend to have increasing scope over time, we are going to opt to close this GitHub issue to encourage future feature requests and bug reports to be handled separately in targeted new GitHub issues. Thank you!

@bflad bflad closed this as completed Oct 11, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
new-resource Introduces a new resource. service/quicksight Issues and PRs that pertain to the quicksight service.
Projects
None yet
Milestone
v2.33.0
Development

No branches or pull requests
4 participants
@bflad @mjgpy3 @nywilken @jrobison-sb