Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional authentication providers in Appsync #8715

Closed
acburdine opened this issue May 20, 2019 · 3 comments · Fixed by #8587
Closed

Support additional authentication providers in Appsync #8715

acburdine opened this issue May 20, 2019 · 3 comments · Fixed by #8587
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service.
Milestone

Comments

@acburdine
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Announced here, Appsync now supports specifying additional auth methods. The aws_appsync_graphql_api resource should be updated to allow configuring of these additional auth methods.

New or Affected Resource(s)

  • aws_appsync_graphql_api

Potential Terraform Configuration

resource "aws_appsync_graphql_api" "example" {
  authentication_type = "AWS_IAM"
  name = "example"

  additional_authentication_provider {
    authentication_type = "API_KEY"
  }
}

References

https://aws.amazon.com/about-aws/whats-new/2019/05/aws-appsync-now-supports-configuring-multiple-authorization-type/

There's a PR open already that should fix this issue: #8587 Opening an issue for greater visibility/tracking.

@acburdine acburdine added the enhancement Requests to existing resources that expand the functionality or scope. label May 20, 2019
@bflad bflad added the service/appsync Issues and PRs that pertain to the appsync service. label May 21, 2019
@bflad bflad self-assigned this Sep 24, 2019
@bflad bflad added this to the v2.30.0 milestone Sep 25, 2019
@bflad
Copy link
Contributor

bflad commented Sep 25, 2019

Support for additional_authentication_provider configuration blocks in the aws_appsync_graphql_api resource has been merged and will release with version 2.30.0 of the Terraform AWS Provider, later this week. Thanks to @acburdine for the implementation. 👍

@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants