r/appsync_graphql_api: support additional_authentication_providers

[acburdine]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #8715

Release note for CHANGELOG:

resource/aws_appsync_graphql_api: support `additional_authentication_providers`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAppsyncGraphqlApi'
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (16.66s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (16.94s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (18.77s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_CognitoUserPools (19.31s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_Multiple (19.57s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_APIKey (23.70s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_AWSIAM (24.62s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (25.69s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (25.72s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (26.03s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_OpenIDConnect (26.68s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (26.96s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (27.96s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (29.07s)
--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (12.64s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (35.69s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (36.28s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (36.64s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (37.32s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (37.93s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (39.45s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (26.14s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (29.58s)
PASS

[acburdine]

this particular bit probably needs better wording - the default_action parameter isn't supported in the additional_auth_provider's user_pool_config block, but I wasn't sure if this is the better way, or if I should create an entirely separate user_pool_config block specifically for the additional_authentication_provider.

[acburdine]

other than the minor documentation question - this should be good to go now

[acburdine]

@bflad apologies for the direct ping, wasn't sure how else to get this looked at 😕 is there any way I could help get this merged in?

[Vlaaaaaaad]

Is there anything blocking this?

[tgroshon]

Does this need any additional work? This is very important to a project I am working on.

[JustinPlute]

Why is this still open and not merged in yet?

[falcon47]

Hey guys, is there any plans to merge this soon? Any updates?

[aeschright]

Hi everyone, we're still working through the sizable backlog of PRs and have new team members ramping up. We'll get to this one as soon as we can, and you can help by making sure you've addressed the common review items. Thanks!

[bflad]

Thanks so much and sorry for the delayed review, @acburdine, great work, especially with all the additional testing. 🚀 The only change I made was to the PR description with Closes #8715. For the documentation, we can always adjust that in a future change for further clarification.

Output from acceptance testing:

--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_AWSIAM (12.79s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_APIKey (12.95s)
--- PASS: TestAccAWSAppsyncGraphqlApi_disappears (14.13s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (17.62s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (19.76s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (20.31s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (23.03s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (24.56s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (24.74s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_CognitoUserPools (12.92s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (26.53s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (27.06s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_Multiple (13.61s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (29.20s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AdditionalAuthentication_OpenIDConnect (17.13s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (31.81s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (33.09s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (33.20s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (34.96s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (36.78s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (36.61s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Schema (37.28s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Tags (37.77s)

[ghost]

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[tgroshon]

Everyone is awesome here

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!