tests/resource/aws_cloudtrail: Remove troublesome slash prefix #10229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/XS
Acceptance test after change
```
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudTrail/Trail/basic -timeout 120m
=== RUN TestAccAWSCloudTrailServiceAccount_basic
=== PAUSE TestAccAWSCloudTrailServiceAccount_basic
=== RUN TestAccAWSCloudTrailServiceAccount_Region
=== PAUSE TestAccAWSCloudTrailServiceAccount_Region
=== RUN TestAccAWSCloudTrail
=== RUN TestAccAWSCloudTrail/Trail
=== RUN TestAccAWSCloudTrail/Trail/basic
--- PASS: TestAccAWSCloudTrail (72.62s)
--- PASS: TestAccAWSCloudTrail/Trail (72.62s)
--- PASS: TestAccAWSCloudTrail/Trail/basic (72.62s)
=== CONT TestAccAWSCloudTrailServiceAccount_basic
=== CONT TestAccAWSCloudTrailServiceAccount_Region
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (15.04s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (15.12s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 87.776s
```
nywilken
force-pushed
the
td-aws_cloudtrail-prefix-cleanup
branch
from
16a1f83
to
7d2c8f1
Compare
aeschright
approved these changes
Oct 4, 2019
There was a problem hiding this comment.
👍
--- PASS: TestAccAWSCloudTrail (33.11s)
--- PASS: TestAccAWSCloudTrail/Trail (33.11s)
--- PASS: TestAccAWSCloudTrail/Trail/basic (33.11s)
--- PASS: TestAccAWSCloudTrailServiceAccount_basic (11.46s)
--- PASS: TestAccAWSCloudTrailServiceAccount_Region (11.53s)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Release note for CHANGELOG:
During testing of the S3 bucket sweeper it was found that the test changed in the PR was creating a S3 key that had an extra slash at the beginning. This key causes issues when when trying to delete the bucket object "nothing gets deleted" causing the
s3_bucketsweeper to error out.Acceptance test after change