resource/aws_vpc: Refactor to use keyvaluetags and call Read after Create #10315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated via: ```console $ make gen ```
…eate Reference: #7926 In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent keyvaluetags handling. The previous `setTags()` logic was always performing retries only necessary for resource creation and not following recommended practices to call the `Read` function after `Create`. Output from acceptance testing: ``` --- PASS: TestAccAWSVpc_disappears (16.21s) --- PASS: TestAccAWSVpc_coreMismatchedDiffs (23.55s) --- PASS: TestAccAWSVpc_DisabledDnsSupport (28.46s) --- PASS: TestAccAWSVpc_classiclinkOptionSet (28.64s) --- PASS: TestAccAWSVpc_bothDnsOptionsSet (28.66s) --- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (29.10s) --- PASS: TestAccAWSVpc_basic (29.31s) --- PASS: TestAccAWSVpc_update (40.02s) --- PASS: TestAccAWSVpc_tags (45.37s) --- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (62.90s) --- PASS: TestAccAWSVpc_Tenancy (62.94s) ```
bflad
added
service/ec2
ryndaniels
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
🚀
Test output:
--- PASS: TestAccAWSVpc_disappears (12.30s)
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (16.61s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (17.17s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (17.16s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (18.32s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (20.36s)
--- PASS: TestAccAWSVpc_basic (21.37s)
--- PASS: TestAccAWSVpc_update (24.12s)
--- PASS: TestAccAWSVpc_tags (24.07s)
--- PASS: TestAccAWSVpc_Tenancy (29.81s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (33.69s)
bflad
added a commit
that referenced
this pull request
Oct 7, 2019
…ad after Create Reference: #7926 Similar in nature to: #10315 In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. The previous `setTags()` logic was always performing retries only necessary for resource creation and the resource itself was not following recommended practices to call the Read function after Create. Ouput from acceptance testing: ``` --- PASS: TestAccAWSSubnet_availabilityZoneId (25.22s) --- PASS: TestAccAWSSubnet_basic (25.66s) --- PASS: TestAccAWSSubnet_enableIpv6 (41.83s) --- PASS: TestAccAWSSubnet_ipv6 (66.62s) ```
|
This has been released in version 2.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
bflad
added a commit
that referenced
this pull request
Oct 25, 2019
…ad after Create (#10411) Reference: #7926 Similar in nature to: #10315 In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent `keyvaluetags` handling. The previous `setTags()` logic was always performing retries only necessary for resource creation and the resource itself was not following recommended practices to call the Read function after Create. Ouput from acceptance testing: ``` --- PASS: TestAccAWSSubnet_availabilityZoneId (25.22s) --- PASS: TestAccAWSSubnet_basic (25.66s) --- PASS: TestAccAWSSubnet_enableIpv6 (41.83s) --- PASS: TestAccAWSSubnet_ipv6 (66.62s) ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: #7926
Release note for CHANGELOG:
First things first, generated the
keyvaluetags.Ec2UpdateTagsfunction, which was different enough from the rest of the services to warrant some additional logic in the generator.In preparation for provider-wide ignore and default tag logic, here we refactor this resource to use the consistent keyvaluetags handling. The previous
setTags()logic was always performing retries only necessary for resource creation and not following recommended practices to call theReadfunction afterCreate.Output from acceptance testing: