Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/resource/aws_iam_role: Update sweeper prefix list #10369

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

nywilken
Copy link
Contributor

@nywilken nywilken commented Oct 3, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

none

While testing a few IAM roles a number of lingering IAM roles with the prefix test-role were found in our testing account. This change updates the list of known test prefixes to help clean up after acceptance tests.

2019/10/03 13:46:15 [DEBUG] Deleting IAM Role: test-role-czb6pl0e34
2019/10/03 13:46:16 [DEBUG] Deleting IAM Role: test-role-d0028y7qm1
2019/10/03 13:46:17 [DEBUG] Deleting IAM Role: test-role-dfynstp2p8
2019/10/03 13:46:18 [DEBUG] Deleting IAM Role: test-role-dwvcp903bo
2019/10/03 13:46:19 [DEBUG] Deleting IAM Role: test-role-ec2-8188536180317514030
2019/10/03 13:46:19 [DEBUG] Deleting IAM Role: test-role-ec2-8467891203856496364
2019/10/03 13:46:20 [DEBUG] Deleting IAM Role: test-role-emlb90qlxy
2019/10/03 13:46:21 [DEBUG] Deleting IAM Role: test-role-eo1x8sj7ij
2019/10/03 13:46:22 [DEBUG] Deleting IAM Role: test-role-eossli2ess
2019/10/03 13:46:23 [DEBUG] Deleting IAM Role: test-role-epbkr7nb7d
2019/10/03 13:46:24 [DEBUG] Deleting IAM Role: test-role-fvouo0zuoy
2019/10/03 13:46:25 [DEBUG] Deleting IAM Role: test-role-fyjmcb703v
2019/10/03 13:46:26 [DEBUG] Deleting IAM Role: test-role-g1e6s24tr8
2019/10/03 13:46:27 [DEBUG] Deleting IAM Role: test-role-g42ffnpvwz
2019/10/03 13:46:28 [DEBUG] Deleting IAM Role: test-role-g4qj9febuf
2019/10/03 13:46:29 [DEBUG] Deleting IAM Role: test-role-gqfgutmca1
2019/10/03 13:46:29 [DEBUG] Deleting IAM Role: test-role-h2chl68vwk
2019/10/03 13:46:30 [DEBUG] Deleting IAM Role: test-role-h2kydpe683
2019/10/03 13:46:31 [DEBUG] Deleting IAM Role: test-role-hfqzllm960
2019/10/03 13:46:32 [DEBUG] Deleting IAM Role: test-role-ho2eipx9o6
2019/10/03 13:46:33 [DEBUG] Deleting IAM Role: test-role-htnsf4k67a
2019/10/03 13:46:34 [DEBUG] Deleting IAM Role: test-role-i9ypnhdhx0
2019/10/03 13:46:35 [DEBUG] Deleting IAM Role: test-role-ibazcx71wh
2019/10/03 13:46:36 [DEBUG] Deleting IAM Role: test-role-iept7yhxf3

While testing a few IAM roles a number of lingering IAM roles with the
prefix test-role were found in our testing account. This change updates
the list of known test prefixes to help clean up after acceptance tests.

```
2019/10/03 13:46:15 [DEBUG] Deleting IAM Role: test-role-czb6pl0e34
2019/10/03 13:46:16 [DEBUG] Deleting IAM Role: test-role-d0028y7qm1
2019/10/03 13:46:17 [DEBUG] Deleting IAM Role: test-role-dfynstp2p8
2019/10/03 13:46:18 [DEBUG] Deleting IAM Role: test-role-dwvcp903bo
2019/10/03 13:46:19 [DEBUG] Deleting IAM Role: test-role-ec2-8188536180317514030
2019/10/03 13:46:19 [DEBUG] Deleting IAM Role: test-role-ec2-8467891203856496364
2019/10/03 13:46:20 [DEBUG] Deleting IAM Role: test-role-emlb90qlxy
2019/10/03 13:46:21 [DEBUG] Deleting IAM Role: test-role-eo1x8sj7ij
2019/10/03 13:46:22 [DEBUG] Deleting IAM Role: test-role-eossli2ess
2019/10/03 13:46:23 [DEBUG] Deleting IAM Role: test-role-epbkr7nb7d
2019/10/03 13:46:24 [DEBUG] Deleting IAM Role: test-role-fvouo0zuoy
2019/10/03 13:46:25 [DEBUG] Deleting IAM Role: test-role-fyjmcb703v
2019/10/03 13:46:26 [DEBUG] Deleting IAM Role: test-role-g1e6s24tr8
2019/10/03 13:46:27 [DEBUG] Deleting IAM Role: test-role-g42ffnpvwz
2019/10/03 13:46:28 [DEBUG] Deleting IAM Role: test-role-g4qj9febuf
2019/10/03 13:46:29 [DEBUG] Deleting IAM Role: test-role-gqfgutmca1
2019/10/03 13:46:29 [DEBUG] Deleting IAM Role: test-role-h2chl68vwk
2019/10/03 13:46:30 [DEBUG] Deleting IAM Role: test-role-h2kydpe683
2019/10/03 13:46:31 [DEBUG] Deleting IAM Role: test-role-hfqzllm960
2019/10/03 13:46:32 [DEBUG] Deleting IAM Role: test-role-ho2eipx9o6
2019/10/03 13:46:33 [DEBUG] Deleting IAM Role: test-role-htnsf4k67a
2019/10/03 13:46:34 [DEBUG] Deleting IAM Role: test-role-i9ypnhdhx0
2019/10/03 13:46:35 [DEBUG] Deleting IAM Role: test-role-ibazcx71wh
2019/10/03 13:46:36 [DEBUG] Deleting IAM Role: test-role-iept7yhxf3
```
@nywilken nywilken requested a review from a team October 3, 2019 17:50
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 3, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nywilken nywilken added this to the v2.32.0 milestone Oct 3, 2019
@nywilken nywilken merged commit 5e70f02 into master Oct 3, 2019
@nywilken nywilken deleted the td-aws_iam_role-sweeper-prefixes branch October 3, 2019 19:42
@ghost
Copy link

ghost commented Oct 10, 2019

This has been released in version 2.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants