Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(resource_vpc_flow_log): logformat field added #10374

Merged
merged 1 commit into from
Oct 31, 2019
Merged

feat(resource_vpc_flow_log): logformat field added #10374

merged 1 commit into from
Oct 31, 2019

Conversation

nebi-frame
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #10081

Release note for CHANGELOG:

This PR depends on aws sdk to be 1.24.x

@nebi-frame nebi-frame requested a review from a team October 3, 2019 19:51
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 3, 2019
@billyshambrook
Copy link

This is a much needed feature so we can get more context in our VPC Flow logs to do deeper analysis for security purposes.

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 10, 2019
bflad
bflad suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nebi-frame 👋 Thank you for submitting this and its off to a good start -- two things and we should be able to get this in. Please reach out if you have any questions or do not have time to implement the feedback.

aws/resource_aws_flow_log.go Show resolved Hide resolved
aws/resource_aws_flow_log_test.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 10, 2019
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 10, 2019
@nebi-frame
Copy link
Contributor Author

nebi-frame commented Oct 10, 2019 •
edited
Loading

Hi @bflad, I'm done with the changes you asked.

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 10, 2019
@bflad bflad self-requested a review October 10, 2019 19:24
@bflad bflad self-assigned this Oct 10, 2019
@bflad bflad added this to the v2.33.0 milestone Oct 10, 2019
bflad
bflad suggested changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi again @nebi-frame 👋 Left another round of feedback below. Are you able to run the acceptance testing? If you're unsure about how to do so, please see the Acceptance Testing section in the Contribution Guide (the test pattern for this resource is TestAccAWSFlowLog_). If you're not able to run the acceptance testing for this resource, please let us know. Thanks!

aws/resource_aws_flow_log_test.go Show resolved Hide resolved
aws/resource_aws_flow_log.go Show resolved Hide resolved
website/docs/r/flow_log.html.markdown Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 12, 2019
@nebi-frame
Copy link
Contributor Author

@bflad, I've made the changes that you asked, now acceptance is working.
Can you please give it another go?

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Oct 14, 2019
@nywilken nywilken modified the milestones: v2.33.0, v2.34.0 Oct 17, 2019
@nebi-frame
Copy link
Contributor Author

Hi @nywilken ,
Just checking in, is there anything I should do at this stage or just waiting to hear back from you?

@nebi-frame
Copy link
Contributor Author

nebi-frame commented Oct 23, 2019 •
edited
Loading

Hi @nywilken @bflad ,
Another checking in cause release date is close by. Any update?

@bflad bflad self-requested a review October 31, 2019 01:26
bflad
bflad approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the updates, @nebi-frame, and sorry for the delay in getting this merged. Let's get this in. 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (7.57s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (11.18s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (12.19s)
--- PASS: TestAccAWSFlowLog_SubnetID (12.43s)
--- PASS: TestAccAWSFlowLog_VPCID (17.84s)
--- PASS: TestAccAWSFlowLog_LogFormat (18.09s)

Output from acceptance testing in AWS GovCloud (US) (test failure unrelated):

--- FAIL: TestAccAWSFlowLog_LogDestinationType_S3_Invalid (4.65s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (6.14s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (7.25s)
--- PASS: TestAccAWSFlowLog_SubnetID (7.55s)
--- PASS: TestAccAWSFlowLog_VPCID (8.65s)
--- PASS: TestAccAWSFlowLog_LogFormat (9.10s)

@bflad bflad merged commit 19aa4f0 into hashicorp:master Oct 31, 2019
bflad added a commit that referenced this pull request Oct 31, 2019
@bflad
Update CHANGELOG for #10374
dc731c2
@bflad
Copy link
Contributor

bflad commented Oct 31, 2019

This has been released in version 2.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.34.0
Development

Successfully merging this pull request may close these issues.

Add support for custom Flow Logs format
4 participants
@nebi-frame @billyshambrook @bflad @nywilken