-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_elasticsearch_domain DomainEndpointOptions #10430
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d9c421f
Merge branch 'master' of https://github.com/terraform-providers/terra…
barrytam20 06905c6
Merge branch 'master' of https://github.com/barrytam20/terraform-prov…
barrytam20 3a61b59
Merge branch 'master' of https://github.com/terraform-providers/terra…
barrytam20 462b26b
Merge branch 'master' of https://github.com/terraform-providers/terra…
barrytam20 c22b34d
Merge branch 'master' of https://github.com/terraform-providers/terra…
barrytam20 071671b
Merge branch 'master' of https://github.com/terraform-providers/terra…
barrytam20 ac8d447
init commit of elasticsearch require https
barrytam20 8c75775
Merge branch 'master' of https://github.com/terraform-providers/terra…
4a2e050
adding tests
3c9b27c
merging in master
barrytam20 e4f6229
merging in master
b6ab109
merging in master
d880754
removing default value
barrytam20 071299f
Merge branch 'master' of https://github.com/terraform-providers/terra…
863138c
domain endpoint options
5860909
PR review changes
barrytam20 b34fb97
fixing tests
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -224,6 +224,7 @@ The following arguments are supported: | |
* `vpc_options` - (Optional) VPC related options, see below. Adding or removing this configuration forces a new resource ([documentation](https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-vpc.html#es-vpc-limitations)). | ||
* `log_publishing_options` - (Optional) Options for publishing slow logs to CloudWatch Logs. | ||
* `elasticsearch_version` - (Optional) The version of Elasticsearch to deploy. Defaults to `1.5` | ||
* `enforce_httpsnt_options` - (Optional) Domain endpoint HTTP(S) related options. See below. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this fix got transposed between here and line 246 -- will fix on merge. 👍 |
||
* `tags` - (Optional) A mapping of tags to assign to the resource | ||
|
||
**ebs_options** supports the following attributes: | ||
|
@@ -240,6 +241,11 @@ The following arguments are supported: | |
* `enabled` - (Required) Whether to enable encryption at rest. If the `encrypt_at_rest` block is not provided then this defaults to `false`. | ||
* `kms_key_id` - (Optional) The KMS key id to encrypt the Elasticsearch domain with. If not specified then it defaults to using the `aws/es` service KMS key. | ||
|
||
**domain_endpoint_options** supports the following attributes: | ||
|
||
* `require_https` - (Required) Whether or not to require HTTPS | ||
* `tls_security_policy` - (Optional) The name of the TLS security policy that needs to be applied to the HTTPS endpoint. Valid values: `Policy-Min-TLS-1-0-2019-07` and `Policy-Min-TLS-1-2-2019-07`. Terraform will only perform drift detection if a configuration value is provided. | ||
|
||
**cluster_config** supports the following attributes: | ||
|
||
* `instance_type` - (Optional) Instance type of data nodes in the cluster. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include two additional
TestStep
that verify that imports and in-place updates work as expected with this new functionality, e.g.