Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support import for aws_waf_rate_based_rule resource #10475

Merged
merged 3 commits into from
Oct 11, 2019

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9212

Release note for CHANGELOG:

resource/aws_waf_rate_based_rule: Support resource import

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSWafRateBasedRule_'

=== RUN   TestAccAWSWafRateBasedRule_basic
=== PAUSE TestAccAWSWafRateBasedRule_basic
=== CONT  TestAccAWSWafRateBasedRule_basic
=== RUN   TestAccAWSWafRateBasedRule_changeNameForceNew
=== PAUSE TestAccAWSWafRateBasedRule_changeNameForceNew
=== RUN   TestAccAWSWafRateBasedRule_disappears
=== PAUSE TestAccAWSWafRateBasedRule_disappears
=== CONT  TestAccAWSWafRateBasedRule_disappears
=== RUN   TestAccAWSWafRateBasedRule_changePredicates
=== PAUSE TestAccAWSWafRateBasedRule_changePredicates
=== CONT  TestAccAWSWafRateBasedRule_changePredicates
=== RUN   TestAccAWSWafRateBasedRule_noPredicates
=== PAUSE TestAccAWSWafRateBasedRule_noPredicates
=== CONT  TestAccAWSWafRateBasedRule_noPredicates
--- PASS: TestAccAWSWafRateBasedRule_noPredicates (59.89s)
=== CONT  TestAccAWSWafRateBasedRule_changeNameForceNew
--- PASS: TestAccAWSWafRateBasedRule_disappears (81.40s)
--- PASS: TestAccAWSWafRateBasedRule_basic (109.11s)
--- PASS: TestAccAWSWafRateBasedRule_changePredicates (162.43s)
--- PASS: TestAccAWSWafRateBasedRule_changeNameForceNew (141.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	221.503s
...

@DrFaust92 DrFaust92 requested a review from a team October 11, 2019 17:59
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 11, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 11, 2019
@bflad bflad added this to the v2.33.0 milestone Oct 11, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation, thanks @DrFaust92 🚀

--- PASS: TestAccAWSWafRateBasedRule_noPredicates (13.60s)
--- PASS: TestAccAWSWafRateBasedRule_disappears (35.97s)
--- PASS: TestAccAWSWafRateBasedRule_changePredicates (48.42s)
--- PASS: TestAccAWSWafRateBasedRule_basic (78.73s)
--- PASS: TestAccAWSWafRateBasedRule_changeNameForceNew (88.31s)

@bflad bflad merged commit 74bbf8a into hashicorp:master Oct 11, 2019
bflad added a commit that referenced this pull request Oct 11, 2019
@DrFaust92 DrFaust92 deleted the import-waf-rated-rule branch November 2, 2019 06:40
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants