Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glue_version property to the aws_glue_job resource #10564

Closed
wants to merge 1 commit into from

Conversation

bdoepf
Copy link
Contributor

@bdoepf bdoepf commented Oct 20, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9524

Release note for CHANGELOG:

Add `glue_version` property to aws_glue_job resource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueJob_GlueVersion'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueJob_GlueVersion -timeout 120m
=== RUN   TestAccAWSGlueJob_GlueVersion
=== PAUSE TestAccAWSGlueJob_GlueVersion
=== CONT  TestAccAWSGlueJob_GlueVersion
--- PASS: TestAccAWSGlueJob_GlueVersion (81.22s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       81.272s

@bdoepf bdoepf requested a review from a team October 20, 2019 10:30
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 20, 2019
@ewbankkit
Copy link
Contributor

@bdoepf
Copy link
Contributor Author

bdoepf commented Oct 20, 2019

Similar:

That's true, thanks. I didn't see the other PR before. However, I've updated this PR due to the two improvements @bflad suggested there.

  • Using a computed field for glue_version. Let AWS glue decide which version to use as default.
  • Documentation: Insert the new glue_version field into the correct alphabetic position

Would be great if you could merge one of the two almost identical Pull Requests.

@bdoepf bdoepf closed this Nov 1, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability for aws_glue_job to use Python 3 and glue version 1.0
2 participants