Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor API Gateway Stage Resource - use keyvaluetags + enums #10570

Merged
merged 6 commits into from
Nov 8, 2019
Merged

Refactor API Gateway Stage Resource - use keyvaluetags + enums #10570

merged 6 commits into from
Nov 8, 2019

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 20, 2019 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #10688
Closes #9071

Release note for CHANGELOG:

NONE

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayStage_'

=== RUN   TestAccAWSAPIGatewayStage_basic
=== PAUSE TestAccAWSAPIGatewayStage_basic
=== CONT  TestAccAWSAPIGatewayStage_basic
--- PASS: TestAccAWSAPIGatewayStage_basic (473.67s)
=== RUN   TestAccAWSAPIGatewayStage_accessLogSettings
=== PAUSE TestAccAWSAPIGatewayStage_accessLogSettings
=== CONT  TestAccAWSAPIGatewayStage_accessLogSettings
--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (352.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	494.598s

...

@DrFaust92 DrFaust92 requested a review from a team October 20, 2019 20:54
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 20, 2019
@bflad bflad mentioned this pull request Nov 7, 2019
Closed
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 7, 2019
@bflad bflad added this to the v2.36.0 milestone Nov 8, 2019
bflad
bflad approved these changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSAPIGatewayStage_accessLogSettings (208.06s)
--- PASS: TestAccAWSAPIGatewayStage_basic (414.68s)

website/docs/r/api_gateway_stage.html.markdown
@@ -129,6 +129,7 @@ In addition to all arguments above, the following attributes are exported:
* `execution_arn` - The execution ARN to be used in [`lambda_permission`](/docs/providers/aws/r/lambda_permission.html)'s `source_arn`
when allowing API Gateway to invoke a Lambda function,
e.g. `arn:aws:execute-api:eu-west-2:123456789012:z4675bid1j/prod`
* `arn` - Amazon Resource Name (ARN)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Looks like this is indented. Will fix on merge along with alphabetizing in the list.

@bflad bflad merged commit c0ee1bb into hashicorp:master Nov 8, 2019
bflad added a commit that referenced this pull request Nov 8, 2019
@bflad
docs/resource/aws_api_gateway_stage: Fix arn attribute indentation an…
c5d2e23 
…d alphabetize

Reference: #10570 (review)
bflad added a commit that referenced this pull request Nov 8, 2019
@bflad
Update CHANGELOG for #10570
d8ad253
bflad added a commit that referenced this pull request Nov 8, 2019
@bflad
Adjust CHANGELOG for #10570
d26c499
@DrFaust92 DrFaust92 deleted the api-gateway-stage-refactor-tags branch November 9, 2019 12:41
@ghost
Copy link

ghost commented Nov 14, 2019

This has been released in version 2.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.36.0
Development

Successfully merging this pull request may close these issues.

Expose resource ARN for AWS API Gateway Stage
2 participants
@DrFaust92 @bflad