Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ses_identity_policy documentation #10616

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Fix ses_identity_policy documentation #10616

merged 1 commit into from
Oct 24, 2019

Conversation

ivanvc
Copy link
Contributor

@ivanvc ivanvc commented Oct 23, 2019

This is a tiny improvement to the documentation, I was reading it and found it to be outdated.
Examples refer to aws_ses_identity_policy.test. However, the actual resource is called aws_ses_identity_policy.example.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ivanvc
Fix ses_identity_policy documentation
62b2d58 
Examples refer to aws_ses_identity_policy.test. However, the actual
resource is called aws_ses_identity_policy.example.
@ivanvc ivanvc requested a review from a team October 23, 2019 22:27
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service. labels Oct 23, 2019
aeschright
aeschright approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! 👍

@aeschright aeschright merged commit 54c6724 into hashicorp:master Oct 24, 2019
@ivanvc ivanvc deleted the patch-1 branch October 24, 2019 20:16
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschright aeschright aeschright approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanvc @aeschright